0017568: Amount and date ranges excluding limit values (> and <) and NPE when data not found

Description

Amount and Date filters (from - to) are not taking in account limit values.
They are using > and < operators when they should use (>= and <=).

For example if you have a payment on 05-05-2011 and you filter by
from 05-05-2011 to 05-05-2011 you will not see previous payment.

I think the date and amount filters behave different in the application.

---------------------------------------------------------------

When selected filters don't show any information you get a NPE (not affecting at all the report) but is present in the log.

java.lang.NullPointerException
    at org.openbravo.erpCommon.utility.FieldProviderFactory.setField(FieldProviderFactory.java:137)
    at org.openbravo.financial.paymentreport.erpCommon.ad_reports.PaymentReportDao.getPaymentReport(PaymentReportDao.java:672)
    at org.openbravo.financial.paymentreport.erpCommon.ad_reports.PaymentReport.printPageDataSheet(PaymentReport.java:257)
    at org.openbravo.financial.paymentreport.erpCommon.ad_reports.PaymentReport.doPost(PaymentReport.java:159)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:483)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
    at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
    at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
    at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
    at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
    at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
    at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
    at java.lang.Thread.run(Thread.java:662)

Steps To Reproduce

1) Go to Financial Management || Receivables & Payables || Analysis Tools || Payment Report || Payment Report
2) Identify before a payment with due date x
3) Set filters due date from x and due date to x

-----------------------------------------------------

1) Go to Financial Management || Receivables & Payables || Analysis Tools || Payment Report || Payment Report
2) Select filters that won't retrieve information and you will see the following message:
Warning:
No data has been found. Please ensure that the selected filter options are correct.
3) See the log.

Issue History
Date Modified	Username	Field	Change
2011-06-08 18:39	mirurita	New Issue
2011-06-08 18:39	mirurita	Assigned To	=> ioritzCia
2011-06-08 18:39	mirurita	Modules	=> Payment Report
2011-06-08 18:39	mirurita	OBNetwork customer	=> No
2011-07-15 13:29	xabiermerino	Relationship added	related to 0017995
2011-08-11 09:47	ioritzCia	Status	new => scheduled
2011-08-11 09:47	ioritzCia	fix_in_branch	=> pi
2011-08-11 09:47	ioritzCia	Status	scheduled => resolved
2011-08-11 09:47	ioritzCia	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/0d9d11f4ab722ea1e1ac8e7ff8bcd69aa7d6c12f [^]
2011-08-11 09:47	ioritzCia	Resolution	open => fixed
2011-09-05 12:02	mirurita	Note Added: 0040743
2011-09-05 12:02	mirurita	Status	resolved => closed

Notes
(0040743) mirurita (viewer) 2011-09-05 12:02	Working fine.