Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0011980
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 08. Project and service managementmajoralways2010-01-15 16:522010-01-20 23:26
ReporterrafarodaView Statuspublic 
Assigned Torafaroda 
PriorityhighResolutionfixedFixed in Version2.50MP11
StatusclosedFix in branchFixed in SCM revisiond59fddf83138
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.5
OS VersionUbuntu 7.10Database version8.3Ant version1.7
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011980: Avoid inconsistent data in expense sheet lines.

DescriptionWhen creating sales orders from expense sheet lines, some validations are made. If some of the lines pass the validation and lead to a sales order line but some not, one can not unprocess this expense sheet and add a price to a line (one is obliged to add this product to a price list).
Steps To Reproduce1) Create a new expense sheet header.
2) Create a line for product Food, checking Reinvoicing and Business Partner = Millman (do not set a price since Food is included in Millman's price list)
3) Create a line for product Electricity, checking Reinvoicing, Business Partner = Millman and Project = Consulting Project (Electricity is NOT included in Millman's price list)

In Create Sales Orders form Expenses process this would lead to 2 sales orders created (since one line has not a project and another one has).

4) Navigate to Create Sales Orders from Expenses process, select Business Partner = Millman and click on Process button.

One sales order is properly created but the other one not.

5) Navigate to the Electricity line of the expense sheet. Try adding a price for the Electricity line: you can not since the expense sheet is processed and you can not unprocess it (since a line is already in a sales order).
Proposed SolutionIn order to avoid this issue, check that there exists some price for the product and business partner before saving an expense sheet line.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0010431 closedrafaroda UOM is not properly updated in expense sheet lines. 
related to defect 00113362.50MP11 closedrafaroda 'Create Sales Orders from Expenses' process assumes that it will always find a price 

-  Notes
(0023477)
hgbot (developer)
2010-01-15 17:29

 Repository: erp/devel/pi
Changeset: 076cc6b74befa977a3d56b2364a7bbf416febb3d
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Thu Jan 14 22:45:40 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/076cc6b74befa977a3d56b2364a7bbf416febb3d [^]

Fixes issue 11980 Extra checks done in expense sheet lines looking for a price.

---
M src-db/database/model/triggers/S_TIMEEXPENSELINE_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0023479)
rafaroda (developer)
2010-01-15 20:20

 1) Create a new Product in Master Data Management || Product
* Name = My Expense
* Product Type = Expense Type
* UOM = Minutes

2) Create a new expense sheet for Employee John Moneymaker in Project & Service Management || Transactions || Expense Sheet || Header

3) Navigate to Lines and create a new record:
* Reinvoicing = No
* Product = MyExpense
* UOM = Minutes
* Invoice Price = null (notice that MyExpense is not in a price list)
When trying to save you will get success message (CORRECT): since there is no business partner to be re-billed, you are not asked to define a price.

4) Edit this same Line:
* Reinvoicing = Yes
* Product = MyExpense
* UOM = Minutes
* Invoice Price = null (notice that MyExpense is not in a price list)
When trying to save you will get error message (CORRECT): You have checked Reinvoicing. You must also select the corresponding Business Partner.

5) Edit this same Line:
* Reinvoicing = Yes
* Product = MyExpense
* UOM = Minutes
* Invoice Price = null (notice that MyExpense is not in a price list)
* Business Partner = Millman
When trying to save you will get error message (CORRECT): Price not found for current partner and product.

6) Edit this same Line:
* Reinvoicing = Yes
* Product = MyExpense
* UOM = Minutes
* Invoice Price = 9
* Business Partner = Millman
When trying to save you will get success message (CORRECT).

7) Navigate to Product MyExpense.

8) Navigate to tab Price and create a new record:
* Price List version = Sales 2006 (the sales price list defined for business partner Millman)
* List Price = 7
* Standard Price = 6
* Price Limit = 5

9) Go back to the Expense Sheet Line and edit it:
* Reinvoicing = Yes
* Product = MyExpense
* UOM = Minutes
* Invoice Price = null (notice that MyExpense is now in a price list)
* Business Partner = Millman
When trying to save you will get success message (CORRECT).
(0023481)
hgbot (developer)
2010-01-17 11:33

 Repository: erp/devel/pi
Changeset: 674305abf9acc6ef5a8c27d553afe70a992ece1d
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Sun Jan 17 11:30:42 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/674305abf9acc6ef5a8c27d553afe70a992ece1d [^]

Issue 11980 Fixes PostgreSQL DB inconsistency

---
M src-db/database/model/triggers/S_TIMEEXPENSELINE_TRG.xml
---
(0023482)
hgbot (developer)
2010-01-17 12:01

 Repository: erp/devel/pi
Changeset: d59fddf83138fc22328947494928ef0da5bbcf0a
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Sun Jan 17 12:00:46 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d59fddf83138fc22328947494928ef0da5bbcf0a [^]

Issue 11980 Fixes PostgreSQL DB inconsistency

---
M src-db/database/model/triggers/S_TIMEEXPENSELINE_TRG.xml
---
(0023484)
arunkumar (reporter)
2010-01-18 08:30

 Tested & Working fine.
(0023659)
hudsonbot (developer)
2010-01-20 23:26

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/076cc6b74bef [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/fa6621f85351 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15942.obx [^]
(0023660)
hudsonbot (developer)
2010-01-20 23:26

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/674305abf9ac [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/fa6621f85351 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15942.obx [^]
(0023661)
hudsonbot (developer)
2010-01-20 23:26

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d59fddf83138 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/fa6621f85351 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15942.obx [^]

- Issue History
Date Modified Username Field Change
2010-01-15 16:52 rafaroda New Issue
2010-01-15 16:52 rafaroda Assigned To => rafaroda
2010-01-15 16:53 rafaroda Relationship added related to 0011336
2010-01-15 16:53 rafaroda Status new => scheduled
2010-01-15 17:29 hgbot Checkin
2010-01-15 17:29 hgbot Note Added: 0023477
2010-01-15 17:29 hgbot Status scheduled => resolved
2010-01-15 17:29 hgbot Resolution open => fixed
2010-01-15 17:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/076cc6b74befa977a3d56b2364a7bbf416febb3d [^]
2010-01-15 17:32 rafaroda Relationship added related to 0010431
2010-01-15 20:20 rafaroda Note Added: 0023479
2010-01-17 11:33 hgbot Checkin
2010-01-17 11:33 hgbot Note Added: 0023481
2010-01-17 11:33 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/076cc6b74befa977a3d56b2364a7bbf416febb3d [^] => http://code.openbravo.com/erp/devel/pi/rev/674305abf9acc6ef5a8c27d553afe70a992ece1d [^]
2010-01-17 12:01 hgbot Checkin
2010-01-17 12:01 hgbot Note Added: 0023482
2010-01-17 12:01 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/674305abf9acc6ef5a8c27d553afe70a992ece1d [^] => http://code.openbravo.com/erp/devel/pi/rev/d59fddf83138fc22328947494928ef0da5bbcf0a [^]
2010-01-18 08:30 arunkumar Note Added: 0023484
2010-01-18 08:30 arunkumar Status resolved => closed
2010-01-18 08:30 arunkumar Fixed in Version => 2.50MP10
2010-01-19 00:00 anonymous sf_bug_id 0 => 2934612
2010-01-20 07:44 sureshbabu Fixed in Version 2.50MP10 => 2.50MP11
2010-01-20 23:26 hudsonbot Checkin
2010-01-20 23:26 hudsonbot Note Added: 0023659
2010-01-20 23:26 hudsonbot Checkin
2010-01-20 23:26 hudsonbot Note Added: 0023660
2010-01-20 23:26 hudsonbot Checkin
2010-01-20 23:26 hudsonbot Note Added: 0023661

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker