0011959: 347 does not group by Fiscal name - Openbravo Issue Tracking System

diff -r 7d0e4f6fe554 src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql --- a/src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql Wed Jan 13 17:56:19 2010 +0100 +++ b/src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql Wed Jan 13 18:13:25 2010 +0100 @@ -167,7 +167,7 @@ COALESCE(LPAD(replace(translate((SELECT MAX(TAXID) FROM AD_ORGINFO),'.-_/'||CHR(92),' '),' ',''), 9, '0'), '000000000') AS NIF_DECLARANTE, COALESCE(LPAD((CASE BP.TAXID WHEN NULL THEN '0' ELSE replace(translate(BP.TAXID,'.-_/'||CHR(92),' '),' ','') END), 9, '0'), '000000000') AS NIF_DECLARADO, COALESCE(LPAD(' ', 9, ' '), ' ') AS NIF_REPRESENTANTE, - COALESCE(TO_CHAR(RPAD(UPPER((CASE WHEN MIN(BP.NAME) IS NULL THEN MIN(BP.NAME2) WHEN MIN(BP.NAME)='' THEN MIN(BP.NAME2) ELSE MIN(BP.NAME) END)), 40, ' ')), ' ') AS NOMBRE_SOCIAL, + COALESCE(TO_CHAR(RPAD(UPPER((CASE WHEN MIN(BP.NAME2) IS NULL THEN MIN(BP.NAME) WHEN MIN(BP.NAME2)='' THEN MIN(BP.NAME) ELSE MIN(BP.NAME2) END)), 40, ' ')), ' ') AS NOMBRE_SOCIAL, 'D' AS TIPO_DECLARACION, /*LPAD(R.value,2,'0') AS CODIGO_PROVINCIA, this should be like this when region.value is added*/ COALESCE(SUBSTR(MIN(L.POSTAL),1,2), ' ') AS CODIGO_PROVINCIA, @@ -432,7 +432,7 @@ COALESCE(LPAD(replace(translate((SELECT MAX(TAXID) FROM AD_ORGINFO),'.-_/'||CHR(92),' '),' ',''), 9, '0'), ' ') AS NIF_DECLARANTE, COALESCE(LPAD((CASE BP.TAXID WHEN NULL THEN '0' ELSE replace(translate(BP.TAXID,'.-_/'||CHR(92),' '),' ','') END), 9, '0'), ' ') AS NIF_DECLARADO, COALESCE(LPAD(' ', 9, ' '), ' ') AS NIF_REPRESENTANTE, - COALESCE(TO_CHAR(RPAD(UPPER((CASE WHEN MIN(BP.NAME) IS NULL THEN MIN(BP.NAME2) WHEN MIN(BP.NAME)='' THEN MIN(BP.NAME2) ELSE MIN(BP.NAME) END)), 40, ' ')), ' ') AS NOMBRE_SOCIAL, + COALESCE(TO_CHAR(RPAD(UPPER((CASE WHEN MIN(BP.NAME2) IS NULL THEN MIN(BP.NAME) WHEN MIN(BP.NAME2)='' THEN MIN(BP.NAME) ELSE MIN(BP.NAME2) END)), 40, ' ')), ' ') AS NOMBRE_SOCIAL, 'D' AS TIPO_DECLARACION, COALESCE(SUBSTR(MAX(BPL.ISTAXLOCATION||L.POSTAL),2,2), ' ') AS CODIGO_PROVINCIA, ' ' AS CODIGO_PAIS, ' ' AS ESPACIO,

Notes
(0023399) rafaroda (viewer) 2010-01-13 18:15	"Name 2" field inside Business Partner window may or may not be used as the "Fiscal Name". If you want this "Name 2" field to display in the 347 report as the "Fiscal Name" just apply the patch attached. The action performed in the code has been swapping BP.NAME and BP.NAME2 in the lines 170 (method selectNavarraType2) [1] and 435 (method selectAEATType2) [2] of file src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql [3] [1] https://code.openbravo.com/erp/stable/2.40/file/7d0e4f6fe554/src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql#l170 [^] [2] https://code.openbravo.com/erp/stable/2.40/file/7d0e4f6fe554/src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql#l435 [^] [3] https://code.openbravo.com/erp/stable/2.40/file/7d0e4f6fe554/src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql [^]

(0023554) hgbot (developer) 2010-01-19 10:16	Repository: erp/stable/2.40 Changeset: dcaa885db0d946ad03e73f0164e95562b258e8c7 Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com> Date: Sun Jan 17 21:39:34 2010 +0100 URL: http://code.openbravo.com/erp/stable/2.40/rev/dcaa885db0d946ad03e73f0164e95562b258e8c7 [^] Fixes issue 11959 347 report is now grouped by Fiscal Name (Name 2). --- M src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql ---

(0024254) arunkumar (viewer) 2010-02-15 11:14	Based on the proposed solution the fix is made.BP.NAME is replaced by BP.NAME2.

Issue History
Date Modified	Username	Field	Change
2010-01-13 14:18	rafaroda	Type	defect => backport
2010-01-13 14:18	rafaroda	fix_in_branch	=> 2.40
2010-01-13 14:18	rafaroda	Relationship added	related to 0011699
2010-01-13 18:14	rafaroda	File Added: patch-issue-11959.diff
2010-01-13 18:15	rafaroda	Note Added: 0023399
2010-01-13 18:15	rafaroda	Status	scheduled => closed
2010-01-13 18:15	rafaroda	Resolution	open => no change required
2010-01-19 10:16	hgbot	Checkin
2010-01-19 10:16	hgbot	Note Added: 0023554
2010-01-19 10:16	hgbot	Status	closed => resolved
2010-01-19 10:16	hgbot	Resolution	no change required => fixed
2010-01-19 10:16	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/stable/2.40/rev/dcaa885db0d946ad03e73f0164e95562b258e8c7 [^]
2010-02-15 11:14	arunkumar	Note Added: 0024254
2010-02-15 11:14	arunkumar	Status	resolved => closed
2010-02-15 11:14	arunkumar	Fixed in Version	=> 2.40MP12
2019-10-02 14:35	Leyre	Issue Monitored: Leyre
2019-10-02 14:36	Leyre	Issue End Monitor: Leyre