0011261: In Sqlc generated code include stack trace in error logs

Description

Sqlc generated code does not include stack trace in error level. This makes problem solving unnessessary difficult in production environments.

Proposed Solution

Include that stack trace when log level is ERROR. See the attached patch.

Tags

No tags attached.

Attached Files

sqlc-include-stacktrace-in-error.diff [^] (3,725 bytes) 2009-11-05 15:56 [Show Content] [Hide Content]

Index: src-core/src/org/openbravo/data/Sqlc.java
===================================================================
--- src-core/src/org/openbravo/data/Sqlc.java	(revision 14953)
+++ src-core/src/org/openbravo/data/Sqlc.java	(working copy)
@@ -943,11 +943,11 @@
       out2.append("      }\n");
       out2.append("      resultKey.close();\n");
       out2.append("    } catch(SQLException e){\n");
-      out2.append("      log4j.error(\"SQL error in query: \" + strSql1 + \"Exception:\"+ e);\n");
+      out2.append("      log4j.error(\"SQL error in query: \" + strSql1 + \"Exception:\"+ e, e);\n");
       out2
           .append("      throw new ServletException(\"@CODE=\" + Integer.toString(e.getErrorCode()) + \"@\" + e.getMessage());\n");
       out2.append("    } catch(Exception ex){\n");
-      out2.append("      log4j.error(\"Exception in query: \" + strSql1 + \"Exception:\"+ ex);\n");
+      out2.append("      log4j.error(\"Exception in query: \" + strSql1 + \"Exception:\"+ ex, ex);\n");
       out2.append("      throw new ServletException(\"@CODE=@\" + ex.getMessage());\n");
       out2.append("    } finally {\n");
       out2.append("      try {\n");
@@ -1077,11 +1077,11 @@
       }
     }
     out2.append("    } catch(SQLException e){\n");
-    out2.append("      log4j.error(\"SQL error in query: \" + strSql + \"Exception:\"+ e);\n");
+    out2.append("      log4j.error(\"SQL error in query: \" + strSql + \"Exception:\"+ e, e);\n");
     out2
         .append("      throw new ServletException(\"@CODE=\" + Integer.toString(e.getErrorCode()) + \"@\" + e.getMessage());\n");
     out2.append("    } catch(Exception ex){\n");
-    out2.append("      log4j.error(\"Exception in query: \" + strSql + \"Exception:\"+ ex);\n");
+    out2.append("      log4j.error(\"Exception in query: \" + strSql + \"Exception:\"+ ex, ex);\n");
     out2.append("      throw new ServletException(\"@CODE=@\" + ex.getMessage());\n");
     out2.append("    } finally {\n");
     out2.append("      try {\n");
@@ -1137,19 +1137,19 @@
       if (outParams > 0)
         out2.append(paramsReceipt.toString());
       out2.append("      } catch(SQLException e){\n");
-      out2.append("        log4j.error(\"SQL error in query: \" + strSql + \"Exception:\"+ e);\n");
+      out2.append("        log4j.error(\"SQL error in query: \" + strSql + \"Exception:\"+ e, e);\n");
       out2
           .append("        throw new ServletException(\"@CODE=\" + Integer.toString(e.getErrorCode()) + \"@\" + e.getMessage());\n");
       out2.append("      } catch(NoConnectionAvailableException ec){\n");
       out2
-          .append("        log4j.error(\"Connection error in query: \" + strSql + \"Exception:\"+ ec);\n");
+          .append("        log4j.error(\"Connection error in query: \" + strSql + \"Exception:\"+ ec, ec);\n");
       out2.append("        throw new ServletException(\"@CODE=NoConnectionAvailable\");\n");
       out2.append("      } catch(PoolNotFoundException ep){\n");
       out2
-          .append("        log4j.error(\"Pool error in query: \" + strSql + \"Exception:\"+ ep);\n");
+          .append("        log4j.error(\"Pool error in query: \" + strSql + \"Exception:\"+ ep, ep);\n");
       out2.append("        throw new ServletException(\"@CODE=NoConnectionAvailable\");\n");
       out2.append("      } catch(Exception ex){\n");
-      out2.append("        log4j.error(\"Exception in query: \" + strSql + \"Exception:\"+ ex);\n");
+      out2.append("        log4j.error(\"Exception in query: \" + strSql + \"Exception:\"+ ex, ex);\n");
       out2.append("        throw new ServletException(\"@CODE=@\" + ex.getMessage());\n");
       out2.append("      }\n");
       out2.append("    }\n");

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

defect

0036444

closed

alostale

SqlC generated code hides stack traces in case of error

Notes
(0021674) shuehner (administrator) 2009-11-10 10:54	Agreed with proposed solution. When doing the change the generated printStracktrace calls should also be converted to proper log4j.error(String,Throwable)

Issue History
Date Modified	Username	Field	Change
2009-11-05 15:56	villind	New Issue
2009-11-05 15:56	villind	Assigned To	=> rafaroda
2009-11-05 15:56	villind	File Added: sqlc-include-stacktrace-in-error.diff
2009-11-10 10:54	shuehner	Note Added: 0021674
2009-11-10 10:54	shuehner	Issue Monitored: shuehner
2009-11-10 11:56	rafaroda	Assigned To	rafaroda => iciordia
2009-11-13 07:33	iciordia	Assigned To	iciordia => shuehner
2012-02-20 11:31	shuehner	Assigned To	shuehner => alostale
2017-04-10 14:37	alostale	Assigned To	alostale => platform
2017-11-06 08:31	alostale	Relationship added	duplicate of 0036444
2017-11-06 08:31	alostale	Status	new => closed
2017-11-06 08:31	alostale	Resolution	open => duplicate
2017-11-06 08:31	alostale	Fixed in Version	=> 3.0PR17Q4