Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0010850 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | minor | always | 2009-10-03 12:22 | 2009-11-20 00:00 | |||
| Reporter | psarobe | View Status | public | |||||
| Assigned To | vmromanos | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 2.50MP9 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 19efa195fcc6 | ||||
| Projection | none | ETA | none | Target Version | 2.50MP9 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0010850: Message after reseting the accounting is not clear nor useful so mislead the user | |||||||
| Description | When you reset the accounting using the process "Reset accounting process" there is a message after the process is finished. This message tells you two things (See attach): As an example: Updated:163 Deleted:506 Supposing that "Updated" means the number of documents (that I guess yes) that has been updated (Posted "Y"-->"N") the messages should be: Number of documents unposting: 163 Regarding on "Deleted" message: Each document has its own book entry/journal entry so if we have 163 documents we will have 163 book entries Right now what is being counting is the number of lines deleted from the fact_acct table, which is the sum of all the total lines that a book entry has. For example let's write a book entry for a sales invoice: Customer---->1127 Goods sales->1000 Taxes------->127 So we have one document then one book entry but three lines and that's what is addend So for having a consistent message the "Deleted" one should take into account the journal entries but not the lines. To do so you have to group by the column fact_acct_group_id that is in the table Fact_acct So finally you would have: Number of documents unposting:163 Number of book entries deleted:163 | |||||||
| Steps To Reproduce | 1. Login 2. Go to Financial management->Accounting->Transactions->Reset accounting | |||||||
| Proposed Solution | See the description | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  reset_accounting.PNG [^] (37,400 bytes) 2009-10-03 12:22
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0021874) vmromanos (viewer) 2009-11-16 17:09 |
Pablo, I think it makes sense to keep the displayed numbers as they are right now. I agree with you that the labels are not very clear, and I propose you to change: Updated:163 Deleted:506 by: Number of unposted documents: 163 Number of deleted accounting lines: 506 From my point of view, it's very important to keep track of the deleted lines in the Fact_Acct table, and not hiding this number to the user. |
|
(0021911) psarobe (viewer) 2009-11-17 11:13 |
Victor, I have talked with several end users and they agree with my approach. But we should also take into consideration another thing, which is that you can either have marked the flag "Delete existing Accounting Entries" or not marked. Solution based on the scenarios: 1. Scenario "Delete existing Accounting Entries" marked Number of unposted documents: 163 (Número de documentos descontablicados) Number of deleted book entries : 163 (Número de asientos borrados) 2. Scenario "Delete existing Accounting Entries" not marked Number of updated documents: 23 (Número de documentos actualizados) |
|
(0021914) vmromanos (viewer) 2009-11-17 11:53 |
Thanks Pablo. It's clear |
|
(0021932) dalsasua (viewer) 2009-11-17 19:21 |
One thing that we haven't considered is that: unposted documents are, not only documents that changes from Y to N the IsPosted value, but also those in statuses such us period closed, error, etc. Because of this, it's not true that when activating the "Delete existing Accounting Entries" flag, number of entries deleted and number of documents set to not posted should be the same. To fix this bug, will group by the fact_acct_group_id value, so not line numbers will be displayed, but number of entries. |
|
(0021933) psarobe (viewer) 2009-11-17 19:44 |
Hi David, I think you are not right. When the flag is marked only deletes accounting entries so update the documents from Posted=Y to N. You can test it by yourself. When you have a document with posted=e (error) and then you delete the accounting marking the flag "Delete existing Accounting Entries" that documents remains as posted=e Only when "Delete existing Accounting Entries" is not marked the updating action is triggered |
|
(0021991) hgbot (developer) 2009-11-18 19:25 |
Repository: erp/devel/pi Changeset: 19efa195fcc6dfef19b770229e016eed87d3a6f7 Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Wed Nov 18 19:24:59 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/19efa195fcc6dfef19b770229e016eed87d3a6f7 [^] Fixes issue 10850: New message and new way to calculate numbers --- M src-db/database/model/functions/FACT_ACCT_RESET.xml M src-db/database/sourcedata/AD_MESSAGE.xml --- |
|
(0022003) sureshbabu (viewer) 2009-11-19 06:54 |
Tested success message appears as below "Process completed successfully Number of unposted documents = X, Number of deleted journal entries = Y" |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-10-03 12:22 | psarobe | New Issue | |
| 2009-10-03 12:22 | psarobe | Assigned To | => vmromanos |
| 2009-10-03 12:22 | psarobe | File Added: reset_accounting.PNG | |
| 2009-10-03 12:22 | psarobe | OBNetwork customer | => No |
| 2009-10-03 12:23 | psarobe | Status | new => scheduled |
| 2009-10-03 12:23 | psarobe | fix_in_branch | => pi |
| 2009-11-16 17:09 | vmromanos | Note Added: 0021874 | |
| 2009-11-16 17:09 | vmromanos | Assigned To | vmromanos => psarobe |
| 2009-11-16 17:09 | vmromanos | Status | scheduled => feedback |
| 2009-11-17 11:13 | psarobe | Note Added: 0021911 | |
| 2009-11-17 11:13 | psarobe | Assigned To | psarobe => vmromanos |
| 2009-11-17 11:13 | psarobe | Status | feedback => scheduled |
| 2009-11-17 11:13 | psarobe | fix_in_branch | pi => |
| 2009-11-17 11:53 | vmromanos | Note Added: 0021914 | |
| 2009-11-17 19:21 | dalsasua | Note Added: 0021932 | |
| 2009-11-17 19:44 | psarobe | Note Added: 0021933 | |
| 2009-11-18 19:25 | hgbot | Checkin | |
| 2009-11-18 19:25 | hgbot | Note Added: 0021991 | |
| 2009-11-18 19:25 | hgbot | Status | scheduled => resolved |
| 2009-11-18 19:25 | hgbot | Resolution | open => fixed |
| 2009-11-18 19:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/19efa195fcc6dfef19b770229e016eed87d3a6f7 [^] |
| 2009-11-19 06:54 | sureshbabu | Note Added: 0022003 | |
| 2009-11-19 06:54 | sureshbabu | Status | resolved => closed |
| 2009-11-19 06:54 | sureshbabu | Fixed in Version | => 2.50MP9 |
| 2009-11-20 00:00 | anonymous | sf_bug_id | 0 => 2900811 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |