0010356: Hardcoded Error Messages in LoginHandler java thus impossible to translate

Notes
(0020365) hgbot (developer) 2009-09-25 11:41	Repository: erp/devel/pi Changeset: d6e4a942ac7beb45b17dcaa7bd90c966626c0250 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 24 15:57:13 2009 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d6e4a942ac7beb45b17dcaa7bd90c966626c0250 [^] Fixed issue 10356. Messages related to Openbravo Professional Subscription login issues can now be translated. --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/base/secureApp/LoginHandler.java ---

(0020514) hgbot (developer) 2009-09-29 14:18	Repository: erp/devel/pi-pageddatagrid Changeset: d6e4a942ac7beb45b17dcaa7bd90c966626c0250 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 24 15:57:13 2009 +0200 URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/d6e4a942ac7beb45b17dcaa7bd90c966626c0250 [^] Fixed issue 10356. Messages related to Openbravo Professional Subscription login issues can now be translated. --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/base/secureApp/LoginHandler.java ---

(0021037) dbaz (developer) 2009-10-15 12:43	Not fixed. Steps to reproduce: * Login As System Administrator * General Setup \|\| Application \|\| Instance Activation * Activate online (Get a key code with 1 uesr limitation) * Logut * Login As System Administrator * General Setup \|\| Application \|\| Module Management > Add Modules * Translation: Spanish-Spain > Install Now Once Installed * Login As System Administrator * Application Dictionary \|\| Message * Search for this Message Text (with Message Type: Error) : "Maximum number of concurrent users reached" and select it * Go to "Translation" tab * Go to "Language -> Spanish" record * As the installed language pack version is older than the partial fix done in this issue, the message it is not translated, so put whatever you want in "Message Text" input. * Save Go to "User Options" window * Select "Language: Spanish (Spain)" * Check "Set as default" * Press "OK" Logout Login (you can see that you have the menu in spanish) Now open another browser and try to login again. Since you have 1 user limitation, you are not able to login, and the error message title is still in english

(0021042) dbaz (developer) 2009-10-15 12:48 edited on: 2009-10-15 12:52	Note: The first step of the bug description "Some messages displayed to the user like 'You have exceeded the number of licensed user....' are hardocded in LoginHandler as java String thus they cannot be translated." is fixed since the message have been introduced as a OB Message The second step of the bug description "As these are shown on/after login the user is known so the default language is known and a translation would be possible." is not fixed since the message displays in english independently of the selected default language

(0021065) marvintm (developer) 2009-10-15 16:21	There is no change required. There is a feature request related to this: https://issues.openbravo.com/view.php?id=10987 [^] Currently, messages in the login window are not translated even if they use our AD_MESSAGE entries.

Issue History
Date Modified	Username	Field	Change
2009-08-20 16:27	shuehner	New Issue
2009-08-20 16:27	shuehner	Assigned To	=> rafaroda
2009-08-20 16:28	shuehner	Priority	normal => urgent
2009-08-20 16:28	shuehner	Assigned To	rafaroda => marvintm
2009-08-20 16:29	shuehner	Tag Attached: OBPS-Security
2009-08-20 21:10	plujan	Status	new => scheduled
2009-09-25 11:41	hgbot	Checkin
2009-09-25 11:41	hgbot	Note Added: 0020365
2009-09-25 11:41	hgbot	Status	scheduled => resolved
2009-09-25 11:41	hgbot	Resolution	open => fixed
2009-09-25 11:41	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/d6e4a942ac7beb45b17dcaa7bd90c966626c0250 [^]
2009-09-29 14:18	hgbot	Checkin
2009-09-29 14:18	hgbot	Note Added: 0020514
2009-09-29 14:18	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/devel/pi/rev/d6e4a942ac7beb45b17dcaa7bd90c966626c0250 [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/d6e4a942ac7beb45b17dcaa7bd90c966626c0250 [^]
2009-10-15 12:43	dbaz	Note Added: 0021037
2009-10-15 12:43	dbaz	Status	resolved => new
2009-10-15 12:43	dbaz	Resolution	fixed => open
2009-10-15 12:48	dbaz	Note Added: 0021042
2009-10-15 12:52	dbaz	Note Edited: 0021042
2009-10-15 16:21	marvintm	Status	new => closed
2009-10-15 16:21	marvintm	Note Added: 0021065
2009-10-15 16:21	marvintm	Resolution	open => no change required
2009-10-16 00:00	anonymous	sf_bug_id	0 => 2880171

Relationships [ Relation Graph ] [ Dependency Graph ]