Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005880Openbravo ERP09. Financial managementpublic2008-11-08 10:242008-12-15 15:26
Reportergalderromo 
Assigned Todalsasua 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionduplicate 
PlatformOS20OS VersionGentoo 2.6.24
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0005880: Spanish bank rule 34: Does not manage business partner bank accounts properly
DescriptionWhen a business partner has more than a bank account registered on the application, and the user creates a payment 34 bank rule, the generated file includes as payment per registered bank account.

It doesn't matter if the banks are active or not.
Steps To ReproduceRegister a business partner with 3 bank accounts.
Register a purchase invoice to this business partner.
Create an Spanish Cuaderno34 an include the debt payment from the previous invoice.
Process the remittance.
Generate the file.
Check you are paying 3 times the same person.
Proposed SolutionCheck the business partner has only an active bank account.
Throw an error if more than one bank is registered for any business partner on the remittance and do not generate the file.
Specify which business partners creates the exception.
The user will make sure a single bank account is activated for this business partner.
Make sure, the generated file, just includes a line per each activated bank account.
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0005697 closed vmromanos CreateFile creates several lines for each remittance line 
depends on backport 0005884 closed dalsasua Spanish bank rule 34: Does not manage business partner bank accounts properly 
depends on backport 0005885 closed dalsasua Spanish bank rule 34: Does not manage business partner bank accounts properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-11-08 10:24galderromoNew Issue
2008-11-08 10:24galderromoAssigned To => rafaroda
2008-11-08 10:24galderromosf_bug_id0 => 2240539
2008-11-09 19:29psarobeStatusnew => scheduled
2008-11-09 19:29psarobeNote Added: 0010095
2008-11-09 19:29psarobeAssigned Torafaroda => dalsasua
2008-11-09 19:29psarobefix_in_branch => trunk
2008-12-02 11:00dalsasuaNote Added: 0010869
2008-12-02 11:00dalsasuaStatusscheduled => feedback
2008-12-02 23:27galderromoNote Added: 0010917
2008-12-03 19:03pjuvaraPrioritynormal => high
2008-12-15 15:25dalsasuaRegression testing => No
2008-12-15 15:25dalsasuaRelationship addedduplicate of 0005697
2008-12-15 15:25dalsasuaStatusfeedback => closed
2008-12-15 15:25dalsasuaDuplicate ID0 => 5697
2008-12-15 15:25dalsasuaResolutionopen => duplicate
2008-12-15 15:26dalsasuaNote Added: 0011371

Notes
(0010095)
psarobe   
2008-11-09 19:29   
DAL, I think this also applies for the rest of the banking rules (C19,C58) that exist in the application. But my proposal it's quite similar as Galder's but different. I would add three new fields: Isvendor, Iscustomer, Isdefault. Thinking that a business partner can be a vendor an a customer at the same time and also to not use Isactive as a Isdefault field. The logic would be:
--For Sales transactions--
1. Select the ones where isdefault='Y'. If more than one filter by Iscustomer='Y', if more than one show an error message
--For Purchase transactions--
1. Select the ones where isdefault='Y'. If more than one filter by Isvendor='Y', if more than one show an error
(0010869)
dalsasua   
2008-12-02 11:00   
Hi Galder,

Does this solution fit your needs: https://issues.openbravo.com/view.php?id=5697 [^] ?

Regards.
(0010917)
galderromo   
2008-12-02 23:27   
It does fit if:
- Makes sure the length of each field is what should be.
- Throws an exception when a business partner on the remittance has no bank account.
- Throws and exception when a business partner on the remittance has more than an active bank account.
(0011371)
dalsasua   
2008-12-15 15:26   
QA confirms that fix of bug 0005697 fixes this defect as well.