Openbravo Issue Tracking System - POS2 | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0057455 | POS2 | POS | public | 2024-12-16 10:40 | 2024-12-20 09:03 |
| Reporter | jayala | ||||
| Assigned To | guilleaer | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | scheduled | Resolution | open | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Merge Request Status | |||||
| Review Assigned To | |||||
| OBNetwork customer | |||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0057455: Suggestions Engine use initial form values to make suggestions | ||||
| Description | In POS, if Suggestion Engine should suggest something, it's using the initial form values to make suggestions, instead the updated values. | ||||
| Steps To Reproduce | 1. Select a customer an edit any address. 2. Change Postal Code. 3. Type something into Address Line 1 to get suggestions. This suggestions will be related to initial Postal Code, and not to the changed. Once you save the form, and opened again, data is saved, and the suggestions will be correctly generated. This is also easily noticeable by using the network debugger, watching the network requests done to "getPropertySuggestion" endpoint (this is automatically requested when a the POS is going to show suggestions). Inside the request, the sent entity will contain the old data. | ||||
| Proposed Solution | At CustomerFormHandlerUtils.js: 1. Inside function "setFieldProperties", probably in payload.properties, another property is necessary >> valueChanged: true 2. Inside function "propertyFormSuggestionSelected": 2.1. Inside if "useSuggestionEngine" and "field.obAutoResolveSelection", the function "setFieldProperties" is executed with some arguments. Probably one of them is incorrect (probably field.data). If not, the call to this function is incorrect and some code will need to be developed inside these two if's. 2.2. The variable "entityForSuggestions" is created using objectToValidate.getPlainObject(), which probably is not correct because this is using the old entity (not with the updated data). Probably this is not necessarily a bug and this code it's ok, because the real bug is in first point, and if it's solved, all be ok. Take into account that this is some developer research after a debugging session, so this solutions/conclusions are not necessary correct. Have fun! ¯\_( ͡❛ ͜ʖ ͡❛)_/¯ | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2024-12-16 10:40 | jayala | New Issue | |||
| 2024-12-16 10:40 | jayala | Assigned To | => Retail | ||
| 2024-12-16 10:40 | jayala | Triggers an Emergency Pack | => No | ||
| 2024-12-16 10:40 | jayala | Assigned To | Retail => guilleaer | ||
| 2024-12-16 10:42 | jayala | Proposed Solution updated | |||
| 2024-12-16 12:12 | jayala | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=28929#r28929 | ||
| 2024-12-16 13:16 | guilleaer | Severity | trivial => minor | ||
| 2024-12-20 09:03 | guilleaer | Status | new => scheduled | ||
| There are no notes attached to this issue. |