Openbravo Issue Tracking System - POS2
View Issue Details
0054637POS2POSpublic2024-02-09 11:062024-05-29 16:39
frank_gonzalez 
Triage Omni OMS 
normalminoralways
closedfixed 
5
 
24Q3 
No
0054637: TaxCheck User Input Value text displayed as 'undefined' if the User Action Input isn't configured as 'Mandatory'
If a User Action Input for the TaxCheck User Action isn't set as 'Mandatory', if it is later used in POS2 and no value is selected in the popup, the text at line level is displayed as 'undefined'.

The cause of the bug is identical to issue 54568, so the fix should be very similar.
Backoffice Configuration:
1-Login POS2 backoffice and go to User Input window
2-Create a record of type List and add a test value in the Input Value tab
3-Navigate to the User Action Input window and create a record with the following configuration-
  User Action: "Tax Check"
  User Input: select the previously created user input
  Sequence Number: 10
  Mandatory: false
  Active: true
4-Navigate to the Tax Rate window, search for and select the record for "Entregas IVA 21%" and create a new record in the Tax User Input Value tab with the following configuration-
  User Action: Tax Check
  User Input Value: select the previously created user input's value
  Active: true

POS2 flow:
1-Login POS2 using the VBS-2 terminal and "vallblanca" user
2-Add "Avalanche transceiver" to the ticket
3-Click on the just added product line and, in the menu popup, click "Tax Reason" button
4-Without picking a value in the new popup window, click the OK button
 
BUG: At line level, "undefined" is shown as the value's text (check attached image)
Check solution to https://issues.openbravo.com/view.php?id=54568 [^]
No tags attached.
png livebuilds.openbravo.com_context_retail_pos2_modules_pgsql_web_pos__terminal=VBS-2(Landscape) (2).png (95,486) 2024-02-09 11:06
https://issues.openbravo.com/file_download.php?file_id=19455&type=bug
png
Issue History
2024-02-09 11:06frank_gonzalezNew Issue
2024-02-09 11:06frank_gonzalezAssigned To => Triage Omni OMS
2024-02-09 11:06frank_gonzalezFile Added: livebuilds.openbravo.com_context_retail_pos2_modules_pgsql_web_pos__terminal=VBS-2(Landscape) (2).png
2024-02-09 11:06frank_gonzalezTriggers an Emergency Pack => No
2024-02-09 11:06frank_gonzalezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27492#r27492
2024-02-09 11:07frank_gonzalezDescription Updatedbug_revision_view_page.php?rev_id=27494#r27494
2024-05-24 15:51hgbotNote Added: 0165111
2024-05-29 16:39hgbotNote Added: 0165274
2024-05-29 16:39hgbotResolutionopen => fixed
2024-05-29 16:39hgbotStatusnew => closed
2024-05-29 16:39hgbotFixed in Version => 24Q3
2024-05-29 16:39hgbotNote Added: 0165275

Notes
(0165111)
hgbot   
2024-05-24 15:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2667 [^]
(0165274)
hgbot   
2024-05-29 16:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2667 [^]
(0165275)
hgbot   
2024-05-29 16:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 49b855932ec0410d3c15ff68289c182dce00480e
Author: Frank González <frank.gonzalez@openbravo.com>
Date: 29-05-2024 14:39:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/49b855932ec0410d3c15ff68289c182dce00480e [^]

Fixes ISSUE-54637: TaxCheck User Input Value text displayed as 'undefined' if the User Action Input isn't configured as 'Mandatory'

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineTaxUserInputValues.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLineTaxUserInputValues.test.jsx
---