Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054261POS2POSpublic2024-01-08 09:072024-02-02 08:21
Reporterucarrion 
Assigned Toucarrion 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionunable to reproduce 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054261: [Assign Customer] - Error when using Assign Customer aside a Checkout action
DescriptionWhen clicking on pay without a client assigned to a ticket > 3000€ with the Spanish Fiscalization enabled, as it is mandatory to issue an invoice, the Assign Customer window is displayed.

When clicking on the 'Cancel' button, an unclear error message is displayed “_Action Canceled_“.

When clicking on the 'Ok' button (assigning a customer) the threshold error message doesn't show up, when it should.

The problem seems related to the Assign Customer action/error handling. Please make sure the flag 'Customer Seach Before Payment' is enabled at Organization level.
Steps To ReproduceConfigure the Spanish Fiscalizaton module in a POS2 environment with modules
and enable the 'Customer Search Before Payment' at Organization level.

Add articles to go over 3000€ total amount of the ticket

Do not assign a customer

Click on pay

Click on Cancel

Error message is displayed in the left bottom corner “Action Canceled”

The correct message would be the error message displayed when trying to pay with a customer assigned but without an invoice issued.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053978 closed ifernandez Refactor Fiscalization modules to match the Fiscal API requests 
related to feature request 0054234 closed jayala Launch the customer search when a new ticket is created 
Attached Filespng image (1).png (121,804) 2024-01-08 09:07
https://issues.openbravo.com/file_download.php?file_id=19289&type=bug
png

png image (2).png (111,807) 2024-01-08 09:07
https://issues.openbravo.com/file_download.php?file_id=19290&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-01-08 09:07ucarrionNew Issue
2024-01-08 09:07ucarrionAssigned To => Retail
2024-01-08 09:07ucarrionTriggers an Emergency Pack => No
2024-01-08 09:07ucarrionAssigned ToRetail => ucarrion
2024-01-08 09:07ucarrionAssigned Toucarrion => Triage Omni OMS
2024-01-08 09:07ucarrionFile Added: image (1).png
2024-01-08 09:07ucarrionFile Added: image (2).png
2024-01-08 09:11ucarrionRelationship addedrelated to 0053978
2024-01-15 10:26ifernandezNote Added: 0159307
2024-01-15 10:26ifernandezAssigned ToTriage Omni OMS => Retail
2024-01-15 10:26ifernandezSummary[Spain Fiscal] - ActionCanceled error message when trying to pay a ticket over threshold => [Assign Customer] - Error when using Assign Customer aside a Checkout action
2024-01-15 10:26ifernandezDescription Updatedbug_revision_view_page.php?rev_id=27343#r27343
2024-01-15 10:26ifernandezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27345#r27345
2024-01-15 10:37ifernandezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27346#r27346
2024-01-31 13:42nicola_uvaAssigned ToRetail => Triage Omni OMS
2024-01-31 22:09aferrazAssigned ToTriage Omni OMS => Retail
2024-02-01 12:26Rajesh_18Assigned ToRetail => Rajesh_18
2024-02-01 12:58Rajesh_18Note Added: 0160085
2024-02-01 12:58Rajesh_18Statusnew => closed
2024-02-01 12:58Rajesh_18Resolutionopen => unable to reproduce
2024-02-01 13:00ucarrionAssigned ToRajesh_18 => ucarrion
2024-02-01 13:00ucarrionStatusclosed => new
2024-02-01 13:00ucarrionResolutionunable to reproduce => open
2024-02-02 08:19ucarrionNote Added: 0160127
2024-02-02 08:19ucarrionStatusnew => closed
2024-02-02 08:19ucarrionResolutionopen => unable to reproduce
2024-02-02 08:21ucarrionRelationship addedrelated to 0054234
2024-02-02 08:21ucarrionNote Edited: 0160127bug_revision_view_page.php?bugnote_id=0160127#r27453

Notes
(0159307)
ifernandez   
2024-01-15 10:26   
Checked out the Fiscalization modules and not encountered any error on the message handler.

Also, tried some tests with the hook openSearchForCustomer. (Changed priority, changed place from ob-init to the UserAction SwitchToPayments, and changing it from a Pre hook to a Post hook) None of them worked as expected.

The one that was closer to a solution was the priority change, in that case, the error message was displayed before the assign customer, so the action was cancelled correctly, but when using other fiscalization modules (as Italy) the popups didn't worked as expected, because there was a duplicated request.

Also, the priority change isn't a well seen solution because the Assign Customer should be performed before the Fiscalization/Checkout actions.
(0160085)
Rajesh_18   
2024-02-01 12:58   
Unable to reproduce
https://drive.google.com/file/d/1grIX4yjzD_qFlLAC-Lvrh29gbYiKrAh9/view?usp=drive_link [^]
(0160127)
ucarrion   
2024-02-02 08:19   
(edited on: 2024-02-02 08:21)
Confirmed, unable to reproduce it in the client instance:
https://vimeo.com/908976969/5e3d166195?share=copy [^]

Could be corrected by: https://issues.openbravo.com/view.php?id=54234 [^]