0053965: [External Discounts] Discount amount reset when converting a quotation into a ticket

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0053965

Retail Modules

Discounts and Promotions

public

2023-11-16 14:35

2023-12-15 07:51

Reporter

aaroncalero

Assigned To

Rajesh_18

Priority

high

Severity

major

Reproducibility

always

Status

scheduled

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0053965: [External Discounts] Discount amount reset when converting a quotation into a ticket

Description

When the External Discounts Engine is configured, and a quotation is created in WebPOS, if the quotation includes discounts from the external system and this quotation is converted into a ticket, the amounts of the discounts are returned to the initial value of the dummy discount used as template.

This issue is only visible after the fix of 0053653, which fixes the issue of discounts being removed after converting a quotation into a ticket.

Steps To Reproduce

In a modules environment (or pos2-modules).
In backoffice, configure the following:
* Organization window: Vall Blanca Store record, check "Use External Discounts Engine" and configure disc_fixed_5_euro as the discount to be used.
* External System window: Define a new record with protocol = 'Javascript - Frontend' and JS Class Name OB.CDISCTEST.DiscountsEngineSimulator?mode=test defined in its subtab
* Events Subscription window: Define a new record with event = "Event Discounts Provider" and the external system defined previously.

Steps:
Log in terminal VBS-1
Go to the menu > Create Quotation
Add two products and complete the quotation.
=> The external discounts call will be triggered and several discounts with different amounts will be added to the quotation

Go to the menu > Create Sales Order
On the "Firm quotation" popup click on Create Sales Order

Verify that all discounts have been reverted to 5€

Proposed Solution

Additional Information