Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053889Retail ModulesWeb POSpublic2023-11-07 13:112024-02-20 13:13
Reportermalsasua 
Assigned Tomalsasua 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusopen
Review Assigned Toguillermogil
OBNetwork customerGold
Support ticket79530
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053889: Payment is deleted but removePayment function is not executed
Descriptionwhen you are using the Send Email functionality in the POS, and after add the payment, and Undo button is clicked, the payment is deleted but removePayment function (doing the return of the payment) is not executed
Steps To ReproduceBO:
. configure to use the email:
 - touch point type:
   Send Email by default
   Send Document by email
 - business partner: Arturo Montoro
   incoice via email

POS
. new ticket
 - select Arturo Montoro
 - add one item
 - click in total
 - select Card payment method
 - click Pay Total -> payment is added
 - click Done button -> popup to send by email is opened
 - click in Cancel button
 - click in Undo button
 - click in total amount -> payment has been deleted but removePayment function to void the payment has not been executed

see attached video
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0054176 closed gonzalo_fernandez POS2 It should be possible to prevent undo from being available for specific state actions over an undoable model 
Attached Files? Screencast from 07-11-23 13:08:50.webm (864,841) 2023-11-07 13:11
https://issues.openbravo.com/file_download.php?file_id=19137&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-11-07 13:11malsasuaNew Issue
2023-11-07 13:11malsasuaAssigned To => Retail
2023-11-07 13:11malsasuaFile Added: Screencast from 07-11-23 13:08:50.webm
2023-11-07 13:11malsasuaOBNetwork customer => Gold
2023-11-07 13:11malsasuaSupport ticket => 79530
2023-11-07 13:11malsasuaTriggers an Emergency Pack => No
2023-11-09 06:34sreehariAssigned ToRetail => sreehari
2023-11-21 14:01sreehariStatusnew => scheduled
2023-12-02 08:18hgbotMerge Request Status => open
2023-12-02 08:18hgbotNote Added: 0157925
2024-01-15 07:55marvintmNote Added: 0159287
2024-01-31 07:21guillermogilNote Added: 0159957
2024-01-31 07:21guillermogilAssigned Tosreehari => malsasua
2024-01-31 07:21guillermogilStatusscheduled => feedback
2024-01-31 07:21guillermogilRelationship addedrelated to 0054176
2024-01-31 09:24guillermogilReview Assigned To => guillermogil
2024-01-31 09:24guillermogilNote Added: 0159971
2024-01-31 09:24guillermogilStatusfeedback => closed
2024-01-31 09:24guillermogilResolutionopen => fixed
2024-02-20 13:13hgbotNote Added: 0160997

Notes
(0157925)
hgbot   
2023-12-02 08:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/280 [^]
(0159287)
marvintm   
2024-01-15 07:55   
Platform team is working on some improvements on the undo infrastructure, we will implement a change based on those once they are finished
(0159957)
guillermogil   
2024-01-31 07:21   
Platform team implemented the following change that avoid the usage of undo in payments: https://issues.openbravo.com/view.php?id=54176 [^]
It should solve the issue, can you check it?
(0159971)
guillermogil   
2024-01-31 09:24   
Fixed on 54176
(0160997)
hgbot   
2024-02-20 13:13   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/280 [^]