Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052891Retail ModulesWeb POSpublic2023-06-29 17:202024-02-20 13:34
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052891: Re-triage old issues which as mobile-test test-cases with waitFixOf waiting for them
DescriptionWe have around 41 different issues for which we have some testcases in mobile-test which are annotated with waitFixOf.

That means those test-cases are auto-disabled until the issue has been fixed.

However many of those issues are quite old (from 2015..2021).

We should triage each to decide if it is still valid / interesting.
Depending on the outcome either:
- no action (still valid)
- close issue as wontfix and also remove the test-case with waitForFix (as it is then just dead code)
Steps To ReproduceSearch for all unique value for waitFixOr in our mobile-test code

i.e. with something like this
grep -Ir "(waitFixOf" | cut -d'(' -f2 | cut -d')' -f1 | sort | uniq
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0054726RR24Q1 closed shuehner Re-triage old issues which as mobile-test test-cases with waitFixOf waiting for them 
depends on backport 0054727RR23Q4.3 closed shuehner Re-triage old issues which as mobile-test test-cases with waitFixOf waiting for them 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-29 17:20shuehnerNew Issue
2023-06-29 17:20shuehnerAssigned To => Retail
2023-06-29 17:20shuehnerTriggers an Emergency Pack => No
2023-06-29 17:21shuehnerNote Added: 0151887
2023-06-29 17:21shuehnerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26379#r26379
2023-10-19 22:12hgbotNote Added: 0156099
2024-02-06 17:49shuehnerNote Added: 0160312
2024-02-06 17:50hgbotNote Added: 0160313
2024-02-08 14:41hgbotResolutionopen => fixed
2024-02-08 14:41hgbotStatusnew => closed
2024-02-08 14:41hgbotNote Added: 0160446
2024-02-08 14:41hgbotNote Added: 0160447
2024-02-08 14:41hgbotNote Added: 0160448
2024-02-08 14:51hgbotNote Added: 0160486
2024-02-20 13:33shuehnerAssigned ToRetail => shuehner
2024-02-20 13:33shuehnerStatusclosed => new
2024-02-20 13:33shuehnerResolutionfixed => open
2024-02-20 13:34shuehnerStatusnew => scheduled
2024-02-20 13:34shuehnerNote Added: 0160999
2024-02-20 13:34shuehnerStatusscheduled => resolved
2024-02-20 13:34shuehnerResolutionopen => fixed
2024-02-20 13:34shuehnerNote Added: 0161000
2024-02-20 13:34shuehnerStatusresolved => closed

Notes
(0151887)
shuehner   
2023-06-29 17:21   
List if issues having waitForFix tag
https://issues.openbravo.com/view.php?id=28690 [^]
https://issues.openbravo.com/view.php?id=28832 [^]
https://issues.openbravo.com/view.php?id=29106 [^]
https://issues.openbravo.com/view.php?id=29123 [^]
https://issues.openbravo.com/view.php?id=30146 [^]
https://issues.openbravo.com/view.php?id=30773 [^]
https://issues.openbravo.com/view.php?id=30794 [^]
https://issues.openbravo.com/view.php?id=31562 [^]
https://issues.openbravo.com/view.php?id=31780 [^]
https://issues.openbravo.com/view.php?id=31928 [^]
https://issues.openbravo.com/view.php?id=34819 [^]
https://issues.openbravo.com/view.php?id=35298 [^]
https://issues.openbravo.com/view.php?id=35299 [^]
https://issues.openbravo.com/view.php?id=35639 [^]
https://issues.openbravo.com/view.php?id=36127 [^]
https://issues.openbravo.com/view.php?id=36640 [^]
https://issues.openbravo.com/view.php?id=36890 [^]
https://issues.openbravo.com/view.php?id=37260 [^]
https://issues.openbravo.com/view.php?id=38495 [^]
https://issues.openbravo.com/view.php?id=39823 [^]
https://issues.openbravo.com/view.php?id=39843 [^]
https://issues.openbravo.com/view.php?id=40985 [^]
https://issues.openbravo.com/view.php?id=40997 [^]
https://issues.openbravo.com/view.php?id=40998 [^]
https://issues.openbravo.com/view.php?id=40999 [^]
https://issues.openbravo.com/view.php?id=41000 [^]
https://issues.openbravo.com/view.php?id=41001 [^]
https://issues.openbravo.com/view.php?id=41003 [^]
https://issues.openbravo.com/view.php?id=41011 [^]
https://issues.openbravo.com/view.php?id=41012 [^]
https://issues.openbravo.com/view.php?id=41014 [^]
https://issues.openbravo.com/view.php?id=41743 [^]
https://issues.openbravo.com/view.php?id=41752 [^]
https://issues.openbravo.com/view.php?id=41761 [^]
https://issues.openbravo.com/view.php?id=41798 [^]
https://issues.openbravo.com/view.php?id=41950 [^]
https://issues.openbravo.com/view.php?id=43290 [^]
https://issues.openbravo.com/view.php?id=44221 [^]
https://issues.openbravo.com/view.php?id=44222 [^]
https://issues.openbravo.com/view.php?id=47156 [^]
https://issues.openbravo.com/view.php?id=28831 [^]
(0156099)
hgbot   
2023-10-19 22:12   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/340 [^]
(0160312)
shuehner   
2024-02-06 17:49   
Spreadsheet in which above issues were triaged:
https://docs.google.com/spreadsheets/d/1UtrZeD235wYPt6uohbxP7N7xwJYXqnDfT8ukf_OFiVk/edit#gid=0 [^]

All marked as action=delete will have:
- testcase deleted (was auto-disabled already)
- Issue rejected as outdated
(0160313)
hgbot   
2024-02-06 17:50   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/362 [^]
(0160446)
hgbot   
2024-02-08 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 379d03d8bde05fa059e151a0063233daa8b96e51
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 08-02-2024 13:35:41
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/379d03d8bde05fa059e151a0063233daa8b96e51 [^]

Fixed ISSUE-52891: Remove obsolete testcase with outdated waitFixOf

mobile-test code has feature to disable a test-case until after the
mantis issue is fixed by adding a waitFixOf annotation.

After triaging those issues delete many as obsolete.
As all those test-cases where disabled (via waitFixOf) no change in
test cases really being executed.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/initialchecks/InitialChecksSuite.java
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/RetailOrderLoaderTest.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/autoserviceprice/AutoServicePriceMultipleLine.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/autoserviceprice/AutoServicePriceRangeDiscount.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/complementaryproducts/I32743_HideComplementaryButtonInReceiptDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/contactinfoforproduct/CompleteReceiptwithContactInfo.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/deliverymodesissue/DMI_04_AdvancedFiltersInIssueSalesOrder.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/CheckComboDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I34809_WrongCalculationOfComboDependingSequence.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I35583_VerifyComboFixPriceII.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I38074_VerifyComboFixedPriceDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I40831_VerifyDiscountWhenTwoCombosAreApplied.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/I39673_VerifyMessageWhenUsingExpiredCoupon.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/CheckTwoFamiliesDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/I32421_TwoFamiliesWithSameProduct.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/I32526_TwoFamiliesWithSameTwoProducts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/externalbp/ExternalBPMultipleTickets.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/orderpreparationawo/OP_Test24_PickingsWithUngroupedProductWithGroupedServiceRelatedPerProduct.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/orderpreparationawo/OP_Test25_PickingsWithUngroupedProductWithGroupedServiceRelatedUniqueQuantity.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/selfcheckout/BuyOneProduct.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/selfcheckout/SCOCashup.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I31827_Error401WhenCashup.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34252_VerifyCashUpWithoutCache.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/TryToOpenStoreWithSeller.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoTwoFamilyCombos.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I32447_FilterByCharacteristicAndStockCriteria.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I32551_FilterByStockAndPriceCriteria.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I34531_FilterWithCombinationAndPatternContain.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpGroupingWithDifferentsBP.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpNoGroupingWithDifferentsBP.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I27754_ActiveInactivePaymentType.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28120_SameProductInTwoPacks.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I40197_ApplyDiscountByHours.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I27631_DocumentnoResetAfterChangingPrefix.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I28690_DocumentnoPrefixChangeAndSale.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifyWebPOSAPIs.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I27615_PartiallyPaidLayaway.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/CreateBPandBPLocationAndAssignTicketOffline.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/CreateLayawayOffline.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/quotations/I27631_QuotationnoResetAfterChangingPrefix.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/quotations/I28690_QuotationnoPrefixChangeAndSale.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/HideActionButtons.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30794_NewCustomerAddProductNoAccessRights.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30997_NewCustomerForReceipt.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32962_ReceiptCreateAssortmentAndLoaded.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I25623_VerifiedReturnsAvoidMoreThanOrdered.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMChangePricelistInLayaway.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMModifyPricelistSharedPayments.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/SplitLineWithManualPromoDiscretionaryFixAmt.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/SplitLineWithManualPromoUserDefAmt.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I29106_ConversionRateChange.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35040_RequestDuringChangeRoleAction.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/performance/ScanningPerformance.java
---
(0160447)
hgbot   
2024-02-08 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 7d4e155a6593ac42280ccc68dcf3f98438233e3e
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 08-02-2024 13:35:41
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/7d4e155a6593ac42280ccc68dcf3f98438233e3e [^]

Fixed ISSUE-52891: Remove commented out waitFixOf

Remove already commented out waitFixOf annotation.
To avoid it coming up when searching for leftover waitFixOf

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31172_WrongPaymentScheduleDetailsOnLayaways.java
---
(0160448)
hgbot   
2024-02-08 14:41   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/362 [^]
(0160486)
hgbot   
2024-02-08 14:51   
Merge request closed: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/340 [^]
(0160999)
shuehner   
2024-02-20 13:34   
re-close (was just reopened to schedule backports)
(0161000)
shuehner   
2024-02-20 13:34   
re-close (was just reopened to schedule backports)