Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052137POS2POSpublic2023-04-11 10:122023-04-18 15:48
Reporterjayala 
Assigned Tojayala 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1.2Fixed in Version23Q1.2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052137: Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker
DescriptionThe logic developed for this issue checks whether the color stored in the browser's database belongs to an active color palette, in addition to checking if the color itself is active. Prior to the change, it simply returned all colors without performing this check.
Also addapted component's tests to new logic to pass.
Steps To Reproduce1. Deactivate a color palette from color palettes in BO.
2. Go to POS2, in the Key map editor > View version > Set layout, right click in any available item.
3. The palette will show all colors, also from the deactivated palette.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0052089 closed jayala Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-17 16:30javierRodriguezTypedefect => backport
2023-04-17 16:30javierRodriguezTarget Version => 23Q1.2
2023-04-17 17:24hgbotNote Added: 0148505
2023-04-18 15:48hgbotResolutionopen => fixed
2023-04-18 15:48hgbotStatusscheduled => closed
2023-04-18 15:48hgbotNote Added: 0148552
2023-04-18 15:48hgbotFixed in Version => 23Q1.2
2023-04-18 15:48hgbotNote Added: 0148553

Notes
(0148505)
hgbot   
2023-04-17 17:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1695 [^]
(0148552)
hgbot   
2023-04-18 15:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1695 [^]
(0148553)
hgbot   
2023-04-18 15:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9c36ef77ca64e9c793d423fe6b18125c55b430f3
Author: Javier Ayala <javier.ayala@openbravo.com>
Date: 18-04-2023 13:48:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9c36ef77ca64e9c793d423fe6b18125c55b430f3 [^]

Fixed ISSUE-52137: Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker

---
A web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/getColorPalettesFromMasterData.js
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorProductPopover/KeymapEditorColorPicker/KeymapEditorColorPicker.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorProductPopover/KeymapEditorColorPicker/__test__/KeymapEditorColorPicker.test.jsx
---