Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052089POS2POSpublic2023-04-11 10:122023-04-17 16:30
Reporterjayala 
Assigned Tojayala 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052089: Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker
DescriptionThe logic developed for this issue checks whether the color stored in the browser's database belongs to an active color palette, in addition to checking if the color itself is active. Prior to the change, it simply returned all colors without performing this check.
Also addapted component's tests to new logic to pass.
Steps To Reproduce1. Deactivate a color palette from color palettes in BO.
2. Go to POS2, in the Key map editor > View version > Set layout, right click in any available item.
3. The palette will show all colors, also from the deactivated palette.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005213623Q2 closed jayala Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker 
depends on backport 005213723Q1.2 closed jayala Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-11 10:12jayalaNew Issue
2023-04-11 10:12jayalaAssigned To => jayala
2023-04-11 10:12jayalaTriggers an Emergency Pack => No
2023-04-11 10:14jayalaStatusnew => acknowledged
2023-04-11 10:14jayalaStatusacknowledged => scheduled
2023-04-11 10:19hgbotNote Added: 0148350
2023-04-14 10:23hgbotResolutionopen => fixed
2023-04-14 10:23hgbotStatusscheduled => closed
2023-04-14 10:23hgbotFixed in Version => 23Q3
2023-04-14 10:23hgbotNote Added: 0148448
2023-04-14 10:23hgbotNote Added: 0148449
2023-04-17 16:29javierRodriguezStatusclosed => new
2023-04-17 16:29javierRodriguezResolutionfixed => open
2023-04-17 16:29javierRodriguezFixed in Version23Q3 =>
2023-04-17 16:30javierRodriguezStatusnew => scheduled
2023-04-17 16:30javierRodriguezStatusscheduled => resolved
2023-04-17 16:30javierRodriguezResolutionopen => fixed
2023-04-17 16:30javierRodriguezStatusresolved => closed

Notes
(0148350)
hgbot   
2023-04-11 10:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1680 [^]
(0148448)
hgbot   
2023-04-14 10:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7b8673e1cd77d33c964a4cd718d78c2631bfed1f
Author: Javier Ayala <javier.ayala@openbravo.com>
Date: 14-04-2023 08:23:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7b8673e1cd77d33c964a4cd718d78c2631bfed1f [^]

Fixed ISSUE-52089: Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker

---
A web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/getColorPalettesFromMasterData.js
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorProductPopover/KeymapEditorColorPicker/KeymapEditorColorPicker.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorProductPopover/KeymapEditorColorPicker/__test__/KeymapEditorColorPicker.test.jsx
---
(0148449)
hgbot   
2023-04-14 10:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1680 [^]