Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049518Retail ModulesDiscounts and Promotionspublic2022-06-09 10:102022-07-19 06:46
Reporterrfacon 
Assigned Toradhakrishnan 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049518: API call - A promotion with an availability set on the last hours of a day is also applied on the last hours of the day before
DescriptionDue to issue 0049517 : a promotion configured using hour filters of the availability subtab in the Back Office sees its availabilty set on two days when a call is done on API Discount

An other issue appears :
A promotion with an availability set on the last hours of a day is also applied on the last hours of the day before when calling the API Discount
Steps To Reproduce1. Configure a discount in the Backend, for example:
- Discount/Promotion Type: Price adjustment
- Active = Y
- Define the discount for a product, for example Baby carrier and select "Included Products" = Only those defined.

2. In the subtab 'Availability' add a row: define 'Monday' from '20:00:00' to '23:59:59'

3. Call the API Discount https://{{OPENBRAVO_URL}}/openbravo/ws/org.openbravo.discounts.discount [^] with the product put at step 1 and an order date set on a Monday, "orderDate": "2022-06-06T20:59:00" for example

You will see the discount applied as configured.

4. Change the hour of the 'orderDate" doing several calls :
- "orderDate": "2022-06-06T23:00:00" (Monday)
- "orderDate": "2022-06-05T23:00:00" (Sunday)

In the summer time for France ("orderDate": "2022-06-06") you will see the discount applied from 'Monday 20:00:00 to Monday 21:59:59' but also from 'Sunday 22:00:00 to Sunday 23:59:59' (UTC+2)

In the winter time for France ("orderDate": "2022-03-07") you will see the discount applied from 'Monday 20:00:00 to Monday 22:59:59' but also from 'Sunday 23:00:00 to Sunday 23:59:59' (UTC+1)

An example of API Discount call is set in attachements
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0049517 closed radhakrishnan API call - Availability of a promotion is calculated on universal time by the API 
related to feature request 0048383pi closed jetxarri Allow to activate promotions on 2 distinct time slots within the same day 
related to defect 0049204 closed ranjith_qualiantech_com Modifying the Availibility subtab doesn't update the discount audit section 
related to defect 0049195 closed radhakrishnan Availability subtab records can be deleted 
related to defect 0049194 closed radhakrishnan Discount availability should be validated with POS time instead of server time 
Attached Filestxt Exemple of call API Discount.txt (440) 2022-06-09 10:10
https://issues.openbravo.com/file_download.php?file_id=17139&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-06-09 10:10rfaconNew Issue
2022-06-09 10:10rfaconAssigned To => Retail
2022-06-09 10:10rfaconFile Added: Exemple of call API Discount.txt
2022-06-09 10:10rfaconTriggers an Emergency Pack => No
2022-06-09 23:40rafarodaTag Attached: NOR
2022-06-09 23:40rafarodaRelationship addedrelated to 0049517
2022-06-09 23:41rafarodaRelationship addedrelated to 0048383
2022-06-09 23:43rafarodaOBNetwork customer => Gold
2022-06-09 23:43rafarodaRelationship addedrelated to 0049204
2022-06-09 23:44rafarodaRelationship addedrelated to 0049195
2022-06-09 23:45rafarodaRelationship addedrelated to 0049194
2022-06-21 13:39radhakrishnanAssigned ToRetail => radhakrishnan
2022-06-21 13:39radhakrishnanStatusnew => scheduled
2022-07-19 06:46marvintmNote Added: 0139400
2022-07-19 06:46marvintmStatusscheduled => resolved
2022-07-19 06:46marvintmFixed in Version => RR22Q4
2022-07-19 06:46marvintmResolutionopen => fixed
2022-07-19 06:46marvintmReview Assigned To => marvintm
2022-07-19 06:46marvintmStatusresolved => closed

Notes
(0139400)
marvintm   
2022-07-19 06:46   
Will also be solved hopefully by the fix for issue:

https://issues.openbravo.com/view.php?id=49517 [^]