Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046421Retail ModulesWeb POSpublic2021-04-29 13:542021-12-01 08:01
Reportermaite 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046421: Error While Importing: while a ticket is being deleted is possible to add an item (addProduct) using RFID (in 19q3 version)
DescriptionRoot cause of problem is similar to issue https://issues.openbravo.com/view.php?id=46257 [^]

It is necessary to reject the "addProduct" execution during the deletion of a ticket
Steps To ReproduceAccording to the terminal log (attached), the "addProduct" process is executed while the "deleteCurrentOrder" process is being executed


This is causing that a corrupted line is added to the deleted ticket. This corrupted line is as follows:
qty=1
lineGrossAmount=0
obposIsDeleted=true
taxlines array missed
tax property missed

So the ticket is stuck in Errors While Importing window
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0046257 closed ranjith_qualiantech_com Error While Importing: while a ticket is being deleted is possible to add an item using RFID (in 19q3 version) 
related to defect 0047499 closed ranjith_qualiantech_com The "addProduct" function is executd while a ticket is being deleted in SCO mode, generating an inconsistent order 
Attached Filespng issue (2).png (334,779) 2021-04-29 13:54
https://issues.openbravo.com/file_download.php?file_id=15602&type=bug
diff 46421_19Q3_posterminal.diff (1,287) 2021-05-05 14:19
https://issues.openbravo.com/file_download.php?file_id=15649&type=bug
diff 46421_PreventDeleteWhileAddingProduct_19Q3_posterminal.diff (1,875) 2021-05-25 14:01
https://issues.openbravo.com/file_download.php?file_id=15827&type=bug
diff 46421_21Q2_posterminal.diff (2,048) 2021-11-19 07:20
https://issues.openbravo.com/file_download.php?file_id=16375&type=bug
diff 46421_20Q2_posterminal.diff (2,348) 2021-12-01 08:01
https://issues.openbravo.com/file_download.php?file_id=16413&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-04-29 13:54maiteNew Issue
2021-04-29 13:54maiteAssigned To => Retail
2021-04-29 13:54maiteFile Added: issue (2).png
2021-04-29 13:54maiteResolution time => 1620856800
2021-04-29 13:54maiteTriggers an Emergency Pack => No
2021-04-29 13:54maiteIssue Monitored: maite
2021-04-29 13:56maiteRelationship addedrelated to 0046257
2021-05-05 13:19ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-05-05 14:18ranjith_qualiantech_comStatusnew => scheduled
2021-05-05 14:19ranjith_qualiantech_comFile Added: 46421_19Q3_posterminal.diff
2021-05-07 07:57marvintmNote Added: 0127879
2021-05-07 07:57marvintmStatusscheduled => resolved
2021-05-07 07:57marvintmResolutionopen => fixed
2021-05-07 07:58marvintmReview Assigned To => marvintm
2021-05-07 07:58marvintmStatusresolved => closed
2021-05-20 13:14marvintmNote Added: 0128448
2021-05-20 13:14marvintmStatusclosed => new
2021-05-20 13:14marvintmResolutionfixed => open
2021-05-20 13:14marvintmResolution time1620856800 => 1622412000
2021-05-21 09:58ranjith_qualiantech_comFile Added: 46421_19Q3_posterminal_v2.diff
2021-05-25 12:55marvintmStatusnew => scheduled
2021-05-25 12:56marvintmStatusscheduled => resolved
2021-05-25 12:56marvintmResolutionopen => fixed
2021-05-25 12:56marvintmStatusresolved => closed
2021-05-25 13:56ranjith_qualiantech_comFile Deleted: 46421_19Q3_posterminal_v2.diff
2021-05-25 14:01ranjith_qualiantech_comFile Added: 46421_PreventDeleteWhileAddingProduct_19Q3_posterminal.diff
2021-08-04 09:52maiteRelationship addedrelated to 0047499
2021-11-19 07:20ranjith_qualiantech_comFile Added: 46421_21Q2_posterminal.diff
2021-12-01 08:01ranjith_qualiantech_comFile Added: 46421_20Q2_posterminal.diff

Notes
(0127879)
marvintm   
2021-05-07 07:57   
The issue does not affect current releases due to the IndexedDB refactor, but we attached a patch for 19Q3.
(0128448)
marvintm   
2021-05-20 13:14   
The provided patch reduced dramatically the number of cases, however, there has been a new case that suggests we need to implement an additional fix:

- We need to follow the same approach when adding a product ,so that we set a flag, and deleteOrder action is rejected if the flag is set
- After the product has been added, the flag should be removed, so that deleting the ticket is again possible