Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045681Openbravo ERPA. Platformpublic2021-01-05 15:152021-03-04 11:55
Reporteraaroncalero 
Assigned Tocberner 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045681: Values not updated after saving fails in a P&E grid that allows additions
DescriptionIn P&E processes that contain editable grid parameters (i.e. [Payment In] > Add Details) if a new record is added to the grid, but not all mandatory parameters are populated before clicking on Done, the new record in the grid remains in an inconsistent state until it is removed.
Even if the missing mandatory field(s) are populated after that, the P&E process will continue to fail until the (originally failing) record in the grid is replaced by a new one.
Steps To Reproduce1) Go to the [Payment In] window
2) Create a new record in the header with an amount of 20
3) Click in the "Add Details" button
4) In the "GL Items" grid parameter, click in "Add New" to add a new record and type a 20 in the 'Received in' field.
5) Click on Done and verify that the process fails as expected.
6) Edit the GL Item record and select a value in the G/L Item combo
7) Click on Done again.
The P&E process keeps failing stating that some mandatory fields have not been filled.
8) Remove the 'broken' G/L item, add a new one and populate all mandatory fields ('G/L Item' combo and 'Received in')
Click again on Done and verify that the process works.
Proposed SolutionThe issue might be related to 0040969. The function hasNewRecordWithEmptyMandatoryFields added while fixing that issue keeps returning true even when all fields have been populated
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040969 closed caristu Maximum call stack size exceeded can be thrown in P&E grids that allow record addition 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-01-05 15:15aaroncaleroNew Issue
2021-01-05 15:15aaroncaleroAssigned To => platform
2021-01-05 15:15aaroncaleroModules => Core
2021-01-05 15:15aaroncaleroTriggers an Emergency Pack => No
2021-02-11 10:38aaroncaleroResolution time => 1614207600
2021-02-11 10:38aaroncaleroNote Added: 0126078
2021-02-11 10:38aaroncaleroPrioritynormal => high
2021-02-11 10:38aaroncaleroSeverityminor => major
2021-02-11 12:55aaroncaleroResolution time1614207600 => 1614812400
2021-02-25 13:56cbernerAssigned Toplatform => cberner
2021-03-01 09:50cbernerRelationship addedrelated to 0040969
2021-03-01 09:57hgbotNote Added: 0126418
2021-03-04 11:55hgbotResolutionopen => fixed
2021-03-04 11:55hgbotStatusnew => closed
2021-03-04 11:55hgbotFixed in Version => PR21Q2
2021-03-04 11:55hgbotNote Added: 0126497
2021-03-04 11:55hgbotNote Added: 0126498

Notes
(0126078)
aaroncalero   
2021-02-11 10:38   
Updated OBNetwork Customer / Resolution time as the client (BUT) is requesting this fix with some urgency
(0126418)
hgbot   
2021-03-01 09:57   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/323 [^]
(0126497)
hgbot   
2021-03-04 11:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 45ba2504ad865252057dd36e3f47de88d3d9d531
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-03-04T09:33:11+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/45ba2504ad865252057dd36e3f47de88d3d9d531 [^]

Fixes ISSUE-45681: Values not updated after saving fails in a P&E grid that allows additions

This issue is due to showInlineEditor method in pick and execute
returning early and not executing completely when a mandatory field has
not been completed in the currently edited line.
To avoid it, the inline editor will open if the current line in a pne
grid still has some mandatory fields empty.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0126498)
hgbot   
2021-03-04 11:55   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/323 [^]