Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045581Retail ModulesWeb POSpublic2020-12-15 15:212021-01-12 11:47
ReporterLeyre 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045581: Preference "Web POS action Print invoices automatically" is not correctly taken into account when finalizing a receipt
DescriptionPreference "Web POS action Print invoices automatically" is not correctly taken into account when finalizing a receipt
Steps To ReproduceBackend:
1. Channel Touchpoint Type: "Generate Simplified Invoices" = Y
2. Channel Toychpoint: fill "Full Invoice Sequence Prefix" and "Simplified Invoice Sequence Prefix"
3. Preference "Web POS action Print invoices automatically" = N

Web POS:
1. Log in Web POS
2. Create a new ticket and add a product.
3. Finish the ticket.

Result: Verify that 2 documents are printed: the ticket, and the invoice for the receipt.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0044252 closed prakashmurugesan88 Issue Sales Order process does not print the invoice including the products delivered to the customer 
related to defect 0047200 closed rqueralta Web POS action Print Receipts Automatically" preference is not working 
related to defect 0047465 closed rqueralta Send Email module: "Web POS action Print Receipts Automatically" preference is not working 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-12-15 15:21LeyreNew Issue
2020-12-15 15:21LeyreAssigned To => Retail
2020-12-15 15:21LeyreResolution time => 1609801200
2020-12-15 15:21LeyreTriggers an Emergency Pack => No
2020-12-15 15:21LeyreNote Added: 0124832
2020-12-15 15:28PracticsIssue Monitored: Practics
2020-12-21 11:02psanjuanNote Added: 0125017
2020-12-21 11:58psanjuanNote Edited: 0125017bug_revision_view_page.php?bugnote_id=0125017#r21963
2020-12-21 11:59psanjuanNote Edited: 0125017bug_revision_view_page.php?bugnote_id=0125017#r21964
2020-12-21 11:59psanjuanRelationship addedrelated to 0044252
2020-12-23 05:55prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-12-23 05:56prakashmurugesan88Statusnew => scheduled
2020-12-30 05:32hgbotNote Added: 0125154
2021-01-12 11:47hgbotResolutionopen => fixed
2021-01-12 11:47hgbotStatusscheduled => closed
2021-01-12 11:47hgbotNote Added: 0125367
2021-01-12 11:47hgbotFixed in Version => RR21Q2
2021-01-12 11:47hgbotNote Added: 0125368
2021-01-12 11:47hgbotNote Added: 0125369
2021-06-22 11:09psanjuanRelationship addedrelated to 0047200
2021-07-27 23:17rafarodaRelationship addedrelated to 0047465

Notes
(0124832)
Leyre   
2020-12-15 15:21   
The same problem was fixed for older versions:
https://issues.openbravo.com/view.php?id=41451 [^]
(0125017)
psanjuan   
2020-12-21 11:00   
(edited on: 2020-12-21 11:59)
If an invoice is created it has to be always print.
If the setup of the channel touchpoint type is Generate Simplified Invoice=Yes, that implies that the POS will generate a simplified invoice for each sale booked.
That simplified invoice must be printed always. The Receipt associated could be printed or could not be printe, that can be optional.
My proposal is to rename this preference as:

"Web POS action Print Receipts Automatically".
If its value is set to Y then a receipt will be printed (together with the corresponding simplified invoice).
If its value is set to N then a receipt will not be printed (but just a simplified invoice)

Same applies in the case of an Invoice or Full Invoice while using the menu option Issue Invoice.
In such cases the invoice must always be printed. This preference can also be used to print or not the corresponding receipt.

Same applies in the case of an Invoice or Full Invoice that will be issued at the time of goods delivery (Invoice Terms=After Delivery). In such cases, at the time of the sale the receipt can (and should be printed, most cases) or not by properly configuring this preference "Web POS action Print Receipts Automatically". In any case, the full invoice issued at the time goods are delivered will have to be printed at the POS in any case (that is not happening now, but it should, see issue 44252 ).
(0125154)
hgbot   
2020-12-30 05:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/235 [^]
(0125367)
hgbot   
2021-01-12 11:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/235 [^]
(0125368)
hgbot   
2021-01-12 11:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a735d0e891a8c8cbd36a98ea9c28729d4b0d5ca2
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-01-12T10:47:11+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a735d0e891a8c8cbd36a98ea9c28729d4b0d5ca2 [^]

Fixed BUG-45581: Changed preference name Print invoices automatically to Print Receipts automatically
* Also validated the preference before printing receipts
* Added preference in payload of corresponding test

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M web-test/model/business-object/ticket/actions/CompleteCreditTicket.test.js
M web-test/model/business-object/ticket/actions/CompleteMultiCreditTicket.test.js
M web-test/model/business-object/ticket/actions/CompleteMultiTicket.test.js
M web-test/model/business-object/ticket/actions/CompleteTicket.test.js
M web-test/model/business-object/ticket/actions/ReplaceTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteCreditTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteMultiCreditTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteMultiTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/ReplaceTicket.js
M web/org.openbravo.retail.posterminal/js/utils/ticketUtils.js
---
(0125369)
hgbot   
2021-01-12 11:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: f7fef683b8156a094d1a7251036a0b245c6fbebb
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-01-12T10:47:11+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f7fef683b8156a094d1a7251036a0b245c6fbebb [^]

Related to BUG-45581: Validated preference autoPrintReceipts only when simplified invoice is generated

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteCreditTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteMultiCreditTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteMultiTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/ReplaceTicket.js
---