Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039564Openbravo ERPA. Platformpublic2018-10-30 10:262019-12-12 23:01
Reporteralostale 
Assigned Toplatform 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039564: weird scheduled Process Request defaults
DescriptionWhen a new Process Request is created it defaults to:
  * Frequency -> Daily
  * Daily Options -> Every n days
  * Daily Interval -> 1

As explained in 0028003, this becomes in an hourly trigger of 24*n hours, which causes to be executed in a different hour after DST changes in server.

Defaulting it to:
  * Frequency -> Daily
  * Daily Options -> <empty>

would create same scheduling (to be executed everyday) but it would preserve same hour after DST server changes.
Steps To Reproduce1. Open Process Request window
2. Create a new record
3. Set Timing to Schedule and check values
   * Frequency -> Daily
   * Daily Options -> Every n days
   * Daily Interval -> 1
Proposed Solution1. Change defaults to
  * Frequency -> Daily
  * Daily Options -> <empty>

2. TBD. Should we do an exception for Every n days being n=1 to be scheduled without DST changes? Note this would affect existent scheduled processes.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00280033.0PR15Q1 closed inigosanchez The daily background process is executed incorrectly when changing from summer time to winter time 
related to feature request 0041483 closed caristu update quartz 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-10-30 10:26alostaleNew Issue
2018-10-30 10:26alostaleAssigned To => platform
2018-10-30 10:26alostaleModules => Core
2018-10-30 10:26alostaleTriggers an Emergency Pack => No
2018-10-30 10:27alostaleRelationship addedrelated to 0028003
2018-10-30 10:27alostaleStatusnew => acknowledged
2018-10-30 10:28alostaleProposed Solution updated
2019-10-09 18:02caristuRelationship addedrelated to 0041483
2019-10-22 16:23hgbotCheckin
2019-10-22 16:23hgbotNote Added: 0115226
2019-10-22 16:31caristuStatusacknowledged => scheduled
2019-10-22 16:33caristuReview Assigned To => caristu
2019-10-22 16:33caristuNote Added: 0115231
2019-10-22 16:33caristuStatusscheduled => closed
2019-10-22 16:33caristuResolutionopen => fixed
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116259

Notes
(0115226)
hgbot   
2019-10-22 16:23   
Repository: erp/devel/pi
Changeset: e86132cc225f140aace1d481e21263d263453d3d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Oct 21 09:23:43 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e86132cc225f140aace1d481e21263d263453d3d [^]

[quartz-upgrade] Tests to cover issue 39564

---
M src-test/src/org/openbravo/scheduling/trigger/TriggerProviderTest.java
---
(0115231)
caristu   
2019-10-22 16:33   
After upgrading quartz to version 2.3.1 (0041483) the process request defaults (daily schedule of every n days with 1 day of interval) are not weird anymore. This is because the new implementation of that schedule[1] is no longer executed in a different hour after DST changes in server.

[1] https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/scheduling/trigger/DailyTriggerGenerator.java#l50 [^]
(0116259)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test