Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037684Openbravo ERPA. Platformpublic2018-01-11 18:122018-01-23 10:46
ReporterJONHM 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q1Fixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-04-12
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c17655a6fb3ffb29cdd5d73073615ba9d60cd941 [^]
Triggers an Emergency PackNo
Summary0037684: Filter on quick launch menu is not accent sensitive
DescriptionFilter on quick launch menu is not accent sensitive since 17Q3.
Steps To Reproduce1) As System administrator, open 'Menu' window and modify 'ABC Activity' > 'ÁBC Activity' (set an accent)
2) Switch to 'F&B International Group Admin' role and seek for "ABC Activity" on menu's quick launch.
> No items to show
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037624 closed inigosanchez Filter on quick launch menu is not accent sensitive 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-19 10:42inigosanchezTypedefect => backport
2018-01-19 10:42inigosanchezTarget Version => 3.0PR18Q1
2018-01-19 14:35inigosanchezReview Assigned To => caristu
2018-01-19 14:36hgbotCheckin
2018-01-19 14:36hgbotNote Added: 0101798
2018-01-19 14:36hgbotStatusscheduled => resolved
2018-01-19 14:36hgbotResolutionopen => fixed
2018-01-19 14:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/a292c142693509cad6cfa9ffcc49f6d4603ec7e0 [^]
2018-01-22 11:02caristuNote Added: 0101820
2018-01-22 11:02caristuStatusresolved => new
2018-01-22 11:02caristuResolutionfixed => open
2018-01-22 16:52hgbotCheckin
2018-01-22 16:52hgbotNote Added: 0101856
2018-01-22 16:52caristuStatusnew => acknowledged
2018-01-22 16:52caristuStatusacknowledged => scheduled
2018-01-22 16:52caristuStatusscheduled => resolved
2018-01-22 16:52caristuResolutionopen => fixed
2018-01-22 16:52caristuReview Assigned Tocaristu => AugustoMauch
2018-01-23 10:46AugustoMauchNote Added: 0101892
2018-01-23 10:46AugustoMauchStatusresolved => closed
2018-01-23 10:46AugustoMauchFixed in Version => 3.0PR18Q1

Notes
(0101798)
hgbot   
2018-01-19 14:36   
Repository: erp/backports/3.0PR18Q1
Changeset: a292c142693509cad6cfa9ffcc49f6d4603ec7e0
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Jan 19 14:36:06 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/a292c142693509cad6cfa9ffcc49f6d4603ec7e0 [^]

Fixed issue 37684: Filter on quick launch menu is not accent sensitive

After the changes introduced in the "Improve scalability of the login process" project on issue 0035553, the quick launch menu no longer used the specific datasource. The datasource has a fieldMatchesFilter method that allow searchs not distinguish between accent or non-accent words. Since the changes were introduced, the data is filter in the client instead of in the datasource and for this reason the fieldMatchesFilter method is not executed.

To fix the problem two main actions have been done:
- Small clean code moving the functionality of fieldMatchesFilter method to ob-utilities in order to avoid duplicated code.
- The getQuickMenuItems method must be save the identifiers without accents using the method previosuly created in ob-utilities. It has been done the same with the value returned in the getPickListFilterCriteria method.

Removing the accents in the items of the filter in ob-quick-launch.js the problem has been resolved. The accents are now ignored in Quick launch Menu' suggestion combobox.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0101820)
caristu   
2018-01-22 11:02   
See: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^] [^]
(0101856)
hgbot   
2018-01-22 16:52   
Repository: erp/backports/3.0PR18Q1
Changeset: 5b166011ace4bc0968cbbe4da2918224eead7785
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 22 12:49:53 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/5b166011ace4bc0968cbbe4da2918224eead7785 [^]

related to bug 37684: use title field as the display value for the menu entries

  As now the _identifier contains the title text but without accents, it can not be used as the display field because in that case it would not be possible to show menu entries with accents. For this reason we now use the title field as the display field.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
---
(0101892)
AugustoMauch   
2018-01-23 10:46   
Code reviewed and verified