Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037624Openbravo ERPA. Platformpublic2018-01-11 18:122018-02-22 18:18
ReporterJONHM 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-04-12
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c17655a6fb3ffb29cdd5d73073615ba9d60cd941 [^]
Triggers an Emergency PackNo
Summary0037624: Filter on quick launch menu is not accent sensitive
DescriptionFilter on quick launch menu is not accent sensitive since 17Q3.
Steps To Reproduce1) As System administrator, open 'Menu' window and modify 'ABC Activity' > 'ÁBC Activity' (set an accent)
2) Switch to 'F&B International Group Admin' role and seek for "ABC Activity" on menu's quick launch.
> No items to show
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0018283 closed dbaz 0016891: "Quick Launch" and "Create New" sensitivity Description: accents 
related to defect 0037704 closed platform Ignore accents in filters and selectors 
depends on backport 00376843.0PR18Q1 closed inigosanchez Filter on quick launch menu is not accent sensitive 
depends on backport 00376853.0PR17Q4.1 closed inigosanchez Filter on quick launch menu is not accent sensitive 
depends on backport 00376863.0PR17Q3.3 closed inigosanchez Filter on quick launch menu is not accent sensitive 
caused by feature request 0035553 closed caristu Improve scalability of the login process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-11 18:12JONHMNew Issue
2018-01-11 18:12JONHMAssigned To => platform
2018-01-11 18:12JONHMModules => Core
2018-01-11 18:12JONHMTriggers an Emergency Pack => No
2018-01-11 18:20PracticsIssue Monitored: Practics
2018-01-15 14:19inigosanchezAssigned Toplatform => inigosanchez
2018-01-15 14:19inigosanchezStatusnew => acknowledged
2018-01-16 10:58inigosanchezRelationship addedrelated to 0018283
2018-01-16 11:17inigosanchezRelationship addedcaused by 0035553
2018-01-16 11:20inigosanchezRegression level => Production - Confirmed Stable
2018-01-16 11:20inigosanchezRegression date => 2017-04-12
2018-01-16 11:20inigosanchezRegression introduced in release => 3.0PR17Q3
2018-01-16 11:20inigosanchezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/c17655a6fb3ffb29cdd5d73073615ba9d60cd941 [^]
2018-01-19 10:42inigosanchezStatusacknowledged => scheduled
2018-01-19 14:41inigosanchezReview Assigned To => caristu
2018-01-19 14:42hgbotCheckin
2018-01-19 14:42hgbotNote Added: 0101800
2018-01-19 14:42hgbotStatusscheduled => resolved
2018-01-19 14:42hgbotResolutionopen => fixed
2018-01-19 14:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2c78dc4d9f1b5fcda9b10408f4fba394888cbd01 [^]
2018-01-22 10:54caristuNote Added: 0101819
2018-01-22 10:54caristuStatusresolved => new
2018-01-22 10:54caristuResolutionfixed => open
2018-01-22 10:57caristuNote Edited: 0101819bug_revision_view_page.php?bugnote_id=0101819#r16568
2018-01-22 12:50hgbotCheckin
2018-01-22 12:50hgbotNote Added: 0101835
2018-01-22 12:51caristuStatusnew => acknowledged
2018-01-22 12:51caristuStatusacknowledged => scheduled
2018-01-22 12:51caristuStatusscheduled => resolved
2018-01-22 12:51caristuResolutionopen => fixed
2018-01-22 12:51caristuReview Assigned Tocaristu => AugustoMauch
2018-01-23 10:23AugustoMauchRelationship addedrelated to 0037704
2018-01-23 10:53AugustoMauchNote Added: 0101893
2018-01-23 10:53AugustoMauchStatusresolved => closed
2018-01-23 10:53AugustoMauchFixed in Version => 3.0PR18Q2
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102668
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102675

Notes
(0101800)
hgbot   
2018-01-19 14:42   
Repository: erp/devel/pi
Changeset: 2c78dc4d9f1b5fcda9b10408f4fba394888cbd01
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Jan 19 14:41:38 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c78dc4d9f1b5fcda9b10408f4fba394888cbd01 [^]

Fixed issue 37624: Filter on quick launch menu is not accent sensitive

After the changes introduced in the "Improve scalability of the login process" project on issue 0035553, the quick launch menu no longer used the specific datasource. The datasource has a fieldMatchesFilter method that allow searchs not distinguish between accent or non-accent words. Since the changes were introduced, the data is filter in the client instead of in the datasource and for this reason the fieldMatchesFilter method is not executed.

To fix the problem two main actions have been done:
- Small clean code moving the functionality of fieldMatchesFilter method to ob-utilities in order to avoid duplicated code.
- The getQuickMenuItems method must be save the identifiers without accents using the method previosuly created in ob-utilities. It has been done the same with the value returned in the getPickListFilterCriteria method.

Removing the accents in the items of the filter in ob-quick-launch.js the problem has been resolved. The accents are now ignored in Quick launch Menu' suggestion combobox.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0101819)
caristu   
2018-01-22 10:54   
(edited on: 2018-01-22 10:57)
Accents are being removed also in the displayed name of the menu entries.

We are now setting the identifier without accents in order to return the expected results when filtering. Therefore we now can't use it as the displayed field.

To fix this problem we can make use of the 'title' field instead.

See: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0101835)
hgbot   
2018-01-22 12:50   
Repository: erp/devel/pi
Changeset: b9693156c2c734b53032858826fdffd352a82a0d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 22 12:49:53 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b9693156c2c734b53032858826fdffd352a82a0d [^]

related to bug 37624: use title field as the display value for the menu entries

  As now the _identifier contains the title text but without accents, it can not be used as the display field because in that case it would not be possible to show menu entries with accents. For this reason we now use the title field as the display field.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
---
(0101893)
AugustoMauch   
2018-01-23 10:53   
Code reviewed and verified
(0102668)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102675)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test