0037570: Tests LayawayProductsNotInAssortment and QuotationProductsNotInAssortment are failing in Q4 after fix for issue 37558

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0037570

Retail Modules

Web POS

public

2017-12-29 14:53

2018-01-03 10:32

Reporter

guilleaer

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR17Q4.1

Fixed in Version

RR17Q4.1

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

https://code.openbravo.com/retail/backports/3.0RR17Q4/org.openbravo.retail.posterminal/rev/73da959ee44d [^]

Triggers an Emergency Pack

Summary

0037570: Tests LayawayProductsNotInAssortment and QuotationProductsNotInAssortment are failing in Q4 after fix for issue 37558

Description

Below test are failing:

LayawayProductsNotInAssortment
QuotationProductsNotInAssortment

They are failling because of this line

    adjustPrices: function () {
      // Apply calculated discounts and promotions to price and gross prices
      // so ERP saves them in the proper place
      this.get('lines').each(function (line) {
        var price = line.get('price'),
            gross = line.get('gross'),
            totalDiscount = 0,
            grossListPrice = line.get('priceList'),
            grossUnitPrice, discountPercentage, base;

        // Calculate inline discount: discount applied before promotions
        if ((line.get('product').get('standardPrice') && line.get('product').get('standardPrice') !== price) || (_.isNumber(line.get('discountedLinePrice')) && line.get('discountedLinePrice') !== line.get('product').get('standardPrice'))) {
          grossUnitPrice = new BigDecimal(price.toString());
---->>>>> if (OB.DEC.compare(grossListPrice) === 0)

at this point grossListPrice is undefined

Steps To Reproduce

execute test in 17Q4 release.

They can be also reproducible manually executing the same steps done by mentioned tests.

Proposed Solution

Additional Information