Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037425Retail ModulesStoreServerpublic2017-11-30 11:272018-03-28 11:36
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037425: Repair formatting error and typos in submitted code
DescriptionFrom code review: changes in MobileServerUtils,

https://issues.openbravo.com/view.php?id=37380 [^]

Are the changes in MobileServerUtils related with this issue? I see a few format changes and then the definition of getBooleanPreference, that is not referenced in any other changeset related with this issue.
There is a typo [1] and [2]: it should be Checking if transition to online can start.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/54883ed296c8fc6b984af3f81166896ebd346643#l1.105 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/54883ed296c8fc6b984af3f81166896ebd346643#l1.9S [^]
Steps To ReproduceSee diff of related issue and description above
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0037380 closed mtaal Only do transition to online when it is possible 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-30 11:27mtaalNew Issue
2017-11-30 11:27mtaalAssigned To => mtaal
2017-11-30 11:27mtaalOBNetwork customer => No
2017-11-30 11:27mtaalTriggers an Emergency Pack => No
2017-11-30 11:27mtaalRelationship addedcaused by 0037380
2018-03-13 16:55mtaalReview Assigned To => AugustoMauch
2018-03-13 16:57hgbotCheckin
2018-03-13 16:57hgbotNote Added: 0103205
2018-03-13 16:57hgbotStatusnew => resolved
2018-03-13 16:57hgbotResolutionopen => fixed
2018-03-13 16:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3c1bc36f021e4a0436867c76644045438e0cdf0a [^]
2018-03-28 11:36AugustoMauchNote Added: 0103599
2018-03-28 11:36AugustoMauchStatusresolved => closed

Notes
(0103205)
hgbot   
2018-03-13 16:57   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3c1bc36f021e4a0436867c76644045438e0cdf0a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 13 16:57:03 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3c1bc36f021e4a0436867c76644045438e0cdf0a [^]

Fixes issue 37425: Repair formatting error and typos in submitted code
Formatting change and fixed one typo in log message

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0103599)
AugustoMauch   
2018-03-28 11:36   
Code reviewed and verified