Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037399Openbravo ERPA. Platformpublic2017-11-27 18:232018-01-03 12:39
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2017-03-30
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/1f63d7f9e0618c52fa8f9b4fae7d1350782d22d9 [^]
Triggers an Emergency PackNo
Summary0037399: Duplicated DS Request to the tree datasource having the tree view displayed in a sub-tab
DescriptionDuplicated DS Request to the tree datasource having the tree view displayed in a sub-tab
Steps To Reproduce1) Go to the [Account Tree] window
2) Select a record in the header and move to the "Element Value" sub-tab
3) Switch to the tree view mode
4) Go back to the header and select another record -> Notice that a double call is done for the tree DS (see attached image)
Proposed Solution
Additional Information
TagsPerformance
Relationships
depends on backport 00374003.0PR17Q3.2 closed caristu Duplicated DS Request to the tree datasource having the tree view displayed in a sub-tab 
depends on backport 00374293.0PR17Q4 closed caristu Duplicated DS Request to the tree datasource having the tree view displayed in a sub-tab 
caused by defect 0035545 closed inigosanchez There is no tree view in a subtab under some circumstancies 
Attached Filespng doubleTreeDSRequest.png (143,293) 2017-11-27 18:23
https://issues.openbravo.com/file_download.php?file_id=11331&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-11-27 18:23caristuNew Issue
2017-11-27 18:23caristuAssigned To => platform
2017-11-27 18:23caristuFile Added: doubleTreeDSRequest.png
2017-11-27 18:23caristuOBNetwork customer => No
2017-11-27 18:23caristuModules => Core
2017-11-27 18:23caristuTriggers an Emergency Pack => No
2017-11-27 18:25caristuRegression level => Production - QA Approved
2017-11-27 18:25caristuRegression date => 2017-03-30
2017-11-27 18:25caristuRegression introduced in release => 3.0PR17Q3
2017-11-27 18:25caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/1f63d7f9e0618c52fa8f9b4fae7d1350782d22d9 [^]
2017-11-27 18:25caristuRelationship addedcaused by 0035545
2017-11-27 18:27caristuTag Attached: Performance
2017-11-27 18:27caristuAssigned Toplatform => caristu
2017-11-27 18:27caristuStatusnew => acknowledged
2017-11-27 18:28caristuStatusacknowledged => scheduled
2017-11-27 19:20hgbotCheckin
2017-11-27 19:20hgbotNote Added: 0100746
2017-11-27 19:20hgbotStatusscheduled => resolved
2017-11-27 19:20hgbotResolutionopen => fixed
2017-11-27 19:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/639a31dffd9c7735ec06c156c836639408282931 [^]
2017-11-27 19:21caristuReview Assigned To => alostale
2017-12-01 09:27alostaleNote Added: 0100852
2017-12-01 09:27alostaleStatusresolved => closed
2017-12-01 09:27alostaleFixed in Version => 3.0PR18Q1
2017-12-01 09:44alostaleStatusclosed => new
2017-12-01 09:44alostaleResolutionfixed => open
2017-12-01 09:44alostaleFixed in Version3.0PR18Q1 =>
2017-12-01 09:44alostaleStatusnew => scheduled
2017-12-01 09:44alostaleStatusscheduled => resolved
2017-12-01 09:44alostaleFixed in Version => 3.0PR18Q1
2017-12-01 09:44alostaleResolutionopen => fixed
2017-12-01 10:08alostaleNote Added: 0100880
2017-12-01 10:08alostaleStatusresolved => closed
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101463

Notes
(0100746)
hgbot   
2017-11-27 19:20   
Repository: erp/devel/pi
Changeset: 639a31dffd9c7735ec06c156c836639408282931
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Nov 27 19:16:22 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/639a31dffd9c7735ec06c156c836639408282931 [^]

fixes bug 37399: Duplicated DS calls having the tree view shown in a sub-tab

  Fix for issue 0035545 was intended to force a datasource call when the fetchData does not perform it. This function has a mechanism that avoids DS calls when the grid criteria i not being changed.

  But when the criteria indeed changes two DS request was being fired: the one that we are forcing and the other one fired by the fetchData function. To avoid this problem we are forcing the DS call just when the grid criteria has not changed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0100852)
alostale   
2017-12-01 09:27   
reviewed 6 tested
(0100880)
alostale   
2017-12-01 10:08   
reviewed + tested
(0101463)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test