Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0036877 | Openbravo ERP | 09. Financial management | public | 2017-09-18 13:43 | 2017-09-25 14:30 |
|
Reporter | caristu | |
Assigned To | aferraz | |
Priority | high | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 3.0PR17Q4 | |
Merge Request Status | |
Review Assigned To | aferraz |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0036877: Organization selector in Purchase Order Report should restrict the organizations that can be displayed |
Description | After the fix for issue 0036151 the organization selector in a process definition displays by default the readable organizations of the role in the current context.
In the case of the "Purchase Order Report" it makes sense to display just the organizations which are direct accessible by the role in the current context,i.e., those organizations whose access has been explicitly set in the "Role Organization" subtab of the role ([Role] window) |
Steps To Reproduce | 1) Login as "F&B España Procurement Role"
2) Open the "Purchase Order Report"
3) Note that all the readable organizations of the role are displayed. In this case the organizations that should be displayed are: F&B España, F&B España Region Norte and F&B España Region Sur |
Proposed Solution | Create a new reference to be used for the organization parameter in the "Purchase Order Report".
This can be done using different approaches, attached two proposed solutions that must be reviewed:
1) By using a filter expression which restricts the organizations to be displayed by taking into account the organizations direct accessible by the role.
2) By using a filter expression based on a FilterExpression class which also takes into account the user level of the process definition to discard or include the '*' organization. |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | defect | 0036151 | | closed | caristu | organization selector in process definition don't filter by role's org access | related to | defect | 0036931 | | closed | caristu | Process definition with data access level = System only can be launched as normal client |
|
Attached Files | newOrgReference1.diff (5,015) 2017-09-18 13:43 https://issues.openbravo.com/file_download.php?file_id=11069&type=bug newOrgReference2.diff (8,235) 2017-09-18 13:44 https://issues.openbravo.com/file_download.php?file_id=11070&type=bug |
|
Issue History |
Date Modified | Username | Field | Change |
2017-09-18 13:43 | caristu | New Issue | |
2017-09-18 13:43 | caristu | Assigned To | => Triage Finance |
2017-09-18 13:43 | caristu | Modules | => Core |
2017-09-18 13:43 | caristu | Triggers an Emergency Pack | => No |
2017-09-18 13:43 | caristu | File Added: newOrgReference1.diff | |
2017-09-18 13:44 | caristu | File Added: newOrgReference2.diff | |
2017-09-18 13:44 | caristu | Relationship added | related to 0036151 |
2017-09-18 14:13 | caristu | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=15925#r15925 |
2017-09-22 15:42 | hgbot | Checkin | |
2017-09-22 15:42 | hgbot | Note Added: 0099497 | |
2017-09-22 15:42 | hgbot | Status | new => resolved |
2017-09-22 15:42 | hgbot | Resolution | open => fixed |
2017-09-22 15:42 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/def13514e4af4da7689a48b3277e940a4c213bde [^] |
2017-09-22 15:42 | hgbot | Checkin | |
2017-09-22 15:42 | hgbot | Note Added: 0099498 | |
2017-09-22 15:43 | aferraz | Assigned To | Triage Finance => aferraz |
2017-09-22 15:43 | aferraz | Review Assigned To | => aferraz |
2017-09-22 15:43 | aferraz | Note Added: 0099499 | |
2017-09-22 15:43 | aferraz | Status | resolved => closed |
2017-09-22 15:43 | aferraz | Fixed in Version | => 3.0PR17Q4 |
2017-09-22 15:47 | aferraz | Relationship added | related to 0036931 |
2017-09-25 14:30 | hudsonbot | Checkin | |
2017-09-25 14:30 | hudsonbot | Note Added: 0099556 | |
2017-09-25 14:30 | hudsonbot | Checkin | |
2017-09-25 14:30 | hudsonbot | Note Added: 0099557 | |
Notes |
|
(0099497)
|
hgbot
|
2017-09-22 15:42
|
|
Repository: erp/devel/pi
Changeset: def13514e4af4da7689a48b3277e940a4c213bde
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 22 09:55:57 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/def13514e4af4da7689a48b3277e940a4c213bde [^]
Fixes issue 36877: New Organization selector for Purchase Order Report
---
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
A src/org/openbravo/erpCommon/info/ContextRoleDirectAccessibleOrganizations.java
---
|
|
|
(0099498)
|
hgbot
|
2017-09-22 15:42
|
|
Repository: erp/devel/pi
Changeset: 2955207cac37aba0f003c0226e7b42d7216f854e
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 22 15:20:34 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2955207cac37aba0f003c0226e7b42d7216f854e [^]
Related to issue 36877: Code review improvements
Avoid in clause which can have problems in Oracle, and use exists clause instead.
Check data access level from both process definition and report and process.
Depending on data access level, selector will retrieve following organizations:
- Organization: Role org access organizations.
- All or Client/Organization: Role org access organizations + * organization.
- System/Client: * organization.
---
M src/org/openbravo/erpCommon/info/ContextRoleDirectAccessibleOrganizations.java
---
|
|
|
|
Code review + Testing of attached newOrgReference2.diff fix OK |
|
|
|
|
|
|
|