Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036876Openbravo ERPY. DBSourceManagerpublic2017-09-18 13:232017-09-22 10:10
Reporterinigosanchez 
Assigned Toinigosanchez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036876: Some methods in DBSMOBUtil class are not used anymore.
DescriptionThis issue is related with code clean up task of the DBSM sources. In this case, DBSMOBUtil has 2 methods that should be removed if it is possible. It should be checked. The methods are:
- public void generateIndustryTemplateTree() {
- private void recursiveTemplateLoader(String idDepTemplate) {
* It should be checked other potential candidates related with the issue.

These methods were used before this issue was fixed (0030489), since the fix was introduced into the distribution, this methods seems that are not used anymore.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030489 closed inigosanchez configScript(retail.pack) seems not applied when doing install.source 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-18 13:23inigosanchezNew Issue
2017-09-18 13:23inigosanchezAssigned To => platform
2017-09-18 13:23inigosanchezModules => Core
2017-09-18 13:23inigosanchezTriggers an Emergency Pack => No
2017-09-18 13:24inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=15921#r15921
2017-09-18 13:25inigosanchezRelationship addedrelated to 0030489
2017-09-21 16:08inigosanchezReview Assigned To => alostale
2017-09-21 16:08inigosanchezAssigned Toplatform => inigosanchez
2017-09-21 16:08inigosanchezStatusnew => scheduled
2017-09-21 16:31hgbotCheckin
2017-09-21 16:31hgbotNote Added: 0099222
2017-09-21 16:31hgbotStatusscheduled => resolved
2017-09-21 16:31hgbotResolutionopen => fixed
2017-09-21 16:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/abe3e5949c243ecdead3b1aa3ecb887ae7222399 [^]
2017-09-21 16:35hgbotCheckin
2017-09-21 16:35hgbotNote Added: 0099223
2017-09-21 16:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/abe3e5949c243ecdead3b1aa3ecb887ae7222399 [^] => http://code.openbravo.com/erp/devel/pi/rev/978ab9933a04d8bbd995578e20cc61aa579e1aaf [^]
2017-09-22 03:19hudsonbotCheckin
2017-09-22 03:19hudsonbotNote Added: 0099452
2017-09-22 10:10alostaleNote Added: 0099463
2017-09-22 10:10alostaleStatusresolved => closed
2017-09-22 10:10alostaleFixed in Version => 3.0PR17Q4

Notes
(0099222)
hgbot   
2017-09-21 16:31   
Repository: erp/devel/dbsm-main
Changeset: abe3e5949c243ecdead3b1aa3ecb887ae7222399
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Sep 21 16:11:25 2017 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/abe3e5949c243ecdead3b1aa3ecb887ae7222399 [^]

Fixed issue 36876: Some methods in DBSMOBUtil class are not used anymore.

It is removed two methods from DBSMOBUtil class:
- The recursiveTemplateLoader method is private and it is not used in the class, so no problem to remove it.
- This fix introduced also an API change because a public method is removed: generateIndustryTemplateTree. This method is not used in our code (Neither pi+all_modules nor dbsm) since this fix was introduced 0030489. Removed it.

---
M src/org/openbravo/ddlutils/util/DBSMOBUtil.java
---
(0099223)
hgbot   
2017-09-21 16:35   
Repository: erp/devel/pi
Changeset: 978ab9933a04d8bbd995578e20cc61aa579e1aaf
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Sep 21 16:13:58 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/978ab9933a04d8bbd995578e20cc61aa579e1aaf [^]

Fixed issue 36876: Some methods in DBSMOBUtil class are not used anymore.

It is removed two methods from DBSMOBUtil class:
- The recursiveTemplateLoader method is private and it is not used in the class, so no problem to remove it.
- This fix introduced also an API change because a public method is removed: generateIndustryTemplateTree. This
method is not used in our code (Neither pi+all_modules nor dbsm) since this fix was introduced 0030489. Removed it.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0099452)
hudsonbot   
2017-09-22 03:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/79f756868bba [^]
Maturity status: Test
(0099463)
alostale   
2017-09-22 10:10   
reviewed