Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036362Openbravo ERPZ. Otherspublic2017-06-27 14:122018-05-11 14:07
Reportervmromanos 
Assigned ToAtulOpenbravo 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036362: API Change request
DescriptionRelated to 0036280

Several callouts and other stuff related to these callouts (XSQL files and AD records) will be removed as they are not used by any internal or external (3rd party modules) process.

The risk is very low because we have checked they are not referenced by any other class (Core and modules published into the forge). In fact most of them were not even declared in the AD.
Steps To Reproducehttps://ci.openbravo.com//job/try-api/5066/ [^]


 [checkAPI] 10776 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 10780 ERROR - Errors in API data validation
 [checkAPI] 10784 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 10788 ERROR - Removed row from table AD_CALLOUT - ID: 6C7A1DC738044D2880CF60856508FC81
 [checkAPI] 10792 ERROR - Removed row from table AD_CALLOUT - ID: 8D5A298D3BEF4E14BB9B9C2A7D0CFA18


org.openbravo.erpCommon.ad_callouts:
Missing
class org.openbravo.erpCommon.ad_callouts.SE_Calendar_For_Org: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SE_Years_For_Calendar: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SL_InOutLine_Locator: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SL_Invoice_Tax: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SL_MovementAll_Locator: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SL_Payment_Amounts: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SL_Payment_DocType: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SL_Payment_No_Verify: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
class org.openbravo.erpCommon.ad_callouts.SL_WorkRequirement_Sequence: missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0036280 closed AtulOpenbravo Several unused + probably unusable callouts exists and are candidates to be deleted 
Attached Filesgz java.japi.gz (933,031) 2017-06-28 08:28
https://issues.openbravo.com/file_download.php?file_id=10875&type=bug
diff 36362.diff (2,927) 2017-06-28 08:32
https://issues.openbravo.com/file_download.php?file_id=10876&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-06-27 14:12vmromanosNew Issue
2017-06-27 14:12vmromanosAssigned To => dmitry_mezentsev
2017-06-27 14:12vmromanosModules => Core
2017-06-27 14:12vmromanosTriggers an Emergency Pack => No
2017-06-27 14:12vmromanosRelationship addedblocks 0036280
2017-06-27 15:59dmitry_mezentsevTag Attached: Approved
2017-06-27 15:59dmitry_mezentsevAssigned Todmitry_mezentsev => vmromanos
2017-06-28 08:28vmromanosFile Added: java.japi.gz
2017-06-28 08:32vmromanosFile Added: 36362.diff
2017-06-28 08:33vmromanosStatusnew => scheduled
2017-11-24 13:55vmromanosIssue cloned0037383
2018-04-25 10:06dmiguelezAssigned Tovmromanos => AtulOpenbravo
2018-05-11 13:58hgbotCheckin
2018-05-11 13:58hgbotNote Added: 0104474
2018-05-11 13:58hgbotStatusscheduled => resolved
2018-05-11 13:58hgbotResolutionopen => fixed
2018-05-11 13:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/3aec9468515a8265dce7b7d5e03ac5ddbab136ed [^]
2018-05-11 13:59aferrazReview Assigned To => aferraz
2018-05-11 13:59aferrazNote Added: 0104479
2018-05-11 13:59aferrazStatusresolved => closed
2018-05-11 13:59aferrazFixed in Version => 3.0PR18Q3
2018-05-11 14:07aferrazNote Added: 0104481

Notes
(0104474)
hgbot   
2018-05-11 13:58   
Repository: erp/devel/api-checks
Changeset: 3aec9468515a8265dce7b7d5e03ac5ddbab136ed
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 11 13:57:15 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3aec9468515a8265dce7b7d5e03ac5ddbab136ed [^]

Fixes issue 36362: API change for issue 36280

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_CALLOUT.xml
---
(0104479)
aferraz   
2018-05-11 13:59   
Reviewed
(0104481)
aferraz   
2018-05-11 14:07   
Removed:

Row from table AD_CALLOUT - ID: 6C7A1DC738044D2880CF60856508FC81
Row from table AD_CALLOUT - ID: 8D5A298D3BEF4E14BB9B9C2A7D0CFA18
src/org/openbravo/erpCommon/ad_callouts/SE_Calendar_For_Org.java
src/org/openbravo/erpCommon/ad_callouts/SE_Years_For_Calendar.java
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Locator.java
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Locator_data.xsql
src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Tax.java
src/org/openbravo/erpCommon/ad_callouts/SL_MovementAll_Locator.java
src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts.java
src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts_data.xsql
src/org/openbravo/erpCommon/ad_callouts/SL_Payment_DocType.java
src/org/openbravo/erpCommon/ad_callouts/SL_Payment_DocType_data.xsql
src/org/openbravo/erpCommon/ad_callouts/SL_Payment_No_Verify.java
src/org/openbravo/erpCommon/ad_callouts/SL_WorkRequirement_Sequence.java
src/org/openbravo/erpCommon/ad_callouts/SL_WorkRequirement_Sequence.xsql