Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035877Openbravo ERPA. Platformpublic2017-04-28 10:202017-04-28 13:35
Reportercaristu 
Assigned Toinigosanchez 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q4.4Fixed in Version3.0PR16Q4.4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2017-04-21
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^]
Triggers an Emergency PackNo
Summary0035877: On change functions not executed for numeric parameters
DescriptionDue to the following changeset[1], on change functions are not being executed for numeric parameters. In this case the view is not retrieved properly, causing an exception because in that case we are trying to read a property from an undefined value.

Detected due to the failure of the following jobs in CI[2],[3],[4]

[1] https://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^]
[2] http://ci.openbravo.com/view/qa/job/qa-pi-addpayment-pgsql/743/ [^]
[3] http://ci.openbravo.com/view/qa/job/qa-pi-aprinreg-pgsql/719/ [^]
[4] http://ci.openbravo.com/view/qa/job/qa-pi-salproreg-pgsql/725/ [^]
Steps To Reproduce1) Go to the [Payment In] window
2) Create a new record
3) Click in Add Details
4) Enter a value in the "Actual Payment" parameter and move outside to launch the execution of its on change function. It should update the value of the "There is a difference field" --> ERROR: not being updated because the on change function is not fired.
Proposed SolutionThe fix for issue 0035658 does not take into account numeric fields in P&E windows which are out of a parameter grid.

See attached path with the proposed solution.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035873 closed inigosanchez On change functions not executed for numeric parameters 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-28 11:36inigosanchezTypedefect => backport
2017-04-28 11:36inigosanchezTarget Version => 3.0PR16Q4.4
2017-04-28 11:43inigosanchezReview Assigned To => alostale
2017-04-28 12:49inigosanchezReview Assigned Toalostale => caristu
2017-04-28 12:59hgbotCheckin
2017-04-28 12:59hgbotNote Added: 0096259
2017-04-28 12:59hgbotStatusscheduled => resolved
2017-04-28 12:59hgbotResolutionopen => fixed
2017-04-28 12:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q4.4/rev/0d164fa6e14f71b0938a418c18de6c3b28849557 [^]
2017-04-28 13:35caristuNote Added: 0096266
2017-04-28 13:35caristuStatusresolved => closed
2017-04-28 13:35caristuFixed in Version => 3.0PR16Q4.4

Notes
(0096259)
hgbot   
2017-04-28 12:59   
Repository: erp/backports/3.0PR16Q4.4
Changeset: 0d164fa6e14f71b0938a418c18de6c3b28849557
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Apr 28 12:58:40 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4.4/rev/0d164fa6e14f71b0938a418c18de6c3b28849557 [^]

Fixed issue 35877: On change functions not executed for numeric parameters

The problem was that on change functions was not executed for numeric parameters.
This problem was caused by the partial fix of 0035658 regression.

The fix of 0035658 was partial because the added condition did not taken into account
numeric fields in P&E windows which are out of a parameter grid. This problem has
been resolved by take into account this case.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0096266)
caristu   
2017-04-28 13:35   
Code review + testing OK.