Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034558Openbravo ERPA. Platformpublic2016-11-14 12:062016-11-25 09:32
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q4Fixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-03-18
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/a160b826335735b762cb0a8cbfb81c40a71383fe [^]
Triggers an Emergency PackNo
Summary0034558: Record marked as changed after clicking on the print button in grid view
DescriptionRecord marked as changed after clicking on the print button in grid view.

With the fix for issue 0032491, it was prevented to refresh the whole grid by refreshing just the current printed record.

This way of refreshing causes that the form is detecting changes on its values.
Steps To Reproduce1) Go to the [Sales Invoice] window.
2) In grid view, select an existing record.
2) Click on the print button
3) Open the record in form view, notice that the form is opened as if there were changes present.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034485 closed caristu Record marked as changed after clicking on the print button in grid view 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-17 13:29caristuTypedefect => backport
2016-11-17 13:29caristuTarget Version => 3.0PR16Q4
2016-11-18 08:28hgbotCheckin
2016-11-18 08:28hgbotNote Added: 0091643
2016-11-18 08:28hgbotStatusscheduled => resolved
2016-11-18 08:28hgbotResolutionopen => fixed
2016-11-18 08:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/d97ce501ff25ef9805333b0cf04cf025071e91e7 [^]
2016-11-18 08:30caristuReview Assigned To => alostale
2016-11-18 08:54caristuDescription Updatedbug_revision_view_page.php?rev_id=13800#r13800
2016-11-25 09:32alostaleNote Added: 0091810
2016-11-25 09:32alostaleStatusresolved => closed
2016-11-25 09:32alostaleFixed in Version => 3.0PR16Q4

Notes
(0091643)
hgbot   
2016-11-18 08:28   
Repository: erp/backports/3.0PR16Q4
Changeset: d97ce501ff25ef9805333b0cf04cf025071e91e7
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Nov 18 08:27:14 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/d97ce501ff25ef9805333b0cf04cf025071e91e7 [^]

fixes issue 34558: Record marked as changed after printing in grid view

After printing, just the selected record is refreshed with the refreshCurrentRecord function. The problem was caused because that function was retrieving all the properties instead of just the required grid properties. Eventually, this was causing that some extra fields where being compared when opening the form (in recordHasActualChanges function) causing a wrong detection of changes.

To solve the problem, now when refreshCurrentRecord function is executed in grid view, it retrieves just the grid selected properties. Note that this is the behavior when refreshing the whole grid.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0091810)
alostale   
2016-11-25 09:32   
code reviewed + tested