Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034485Openbravo ERPA. Platformpublic2016-11-14 12:062016-12-16 18:38
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-03-18
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/a160b826335735b762cb0a8cbfb81c40a71383fe [^]
Triggers an Emergency PackNo
Summary0034485: Record marked as changed after clicking on the print button in grid view
DescriptionRecord marked as changed after clicking on the print button in grid view.

With the fix for issue 0032491, it was prevented to refresh the whole grid by refreshing just the current printed record.

This way of refreshing causes that the form is detecting changes on its values.
Steps To Reproduce1) Go to the [Sales Invoice] window.
2) In grid view, select an existing record.
2) Click on the print button
3) Open the record in form view, notice that the form is opened as if there were changes present.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00345583.0PR16Q4 closed caristu Record marked as changed after clicking on the print button in grid view 
depends on backport 00345593.0PR16Q3.4 closed caristu Record marked as changed after clicking on the print button in grid view 
depends on backport 00345603.0PR16Q2.5 closed caristu Record marked as changed after clicking on the print button in grid view 
caused by defect 00324913.0PR16Q2 closed alostale Lines information lost after printing record in Sales Order with filter applied 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-14 12:06caristuNew Issue
2016-11-14 12:06caristuAssigned To => platform
2016-11-14 12:06caristuModules => Core
2016-11-14 12:06caristuTriggers an Emergency Pack => No
2016-11-14 12:06caristuPriorityhigh => immediate
2016-11-14 12:06caristuRelationship addedcaused by 0032491
2016-11-14 12:08caristuRegression level => Production - Confirmed Stable
2016-11-14 12:08caristuRegression date => 2016-03-18
2016-11-14 12:08caristuRegression introduced in release => 3.0PR16Q2
2016-11-14 12:08caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/a160b826335735b762cb0a8cbfb81c40a71383fe [^]
2016-11-15 18:28caristuAssigned Toplatform => caristu
2016-11-17 09:27hgbotCheckin
2016-11-17 09:27hgbotNote Added: 0091618
2016-11-17 13:29caristuStatusnew => scheduled
2016-11-18 08:24hgbotCheckin
2016-11-18 08:24hgbotNote Added: 0091642
2016-11-18 08:24hgbotStatusscheduled => resolved
2016-11-18 08:24hgbotResolutionopen => fixed
2016-11-18 08:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b728814d55b8d7883d0f28b6281b3920449e31a5 [^]
2016-11-18 08:30caristuReview Assigned To => alostale
2016-11-18 08:54caristuDescription Updatedbug_revision_view_page.php?rev_id=13802#r13802
2016-11-25 09:25alostaleNote Added: 0091807
2016-11-25 09:25alostaleStatusresolved => closed
2016-11-25 09:25alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092638
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092642

Notes
(0091618)
hgbot   
2016-11-17 09:27   
Repository: erp/devel/pi
Changeset: dcce34325eae2e9956ad97f6dd8eedce0bdf574e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Nov 17 09:26:43 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dcce34325eae2e9956ad97f6dd8eedce0bdf574e [^]

related to issue 34485: clean up unused variable

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0091642)
hgbot   
2016-11-18 08:24   
Repository: erp/devel/pi
Changeset: b728814d55b8d7883d0f28b6281b3920449e31a5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Nov 18 08:22:42 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b728814d55b8d7883d0f28b6281b3920449e31a5 [^]

fixes issue 34485: Record marked as changed after printing in grid view

After printing, just the selected record is refreshed with the refreshCurrentRecord function. The problem was caused because that function was retrieving all the properties instead of just the required grid properties. Eventually, this was causing that some extra fields where being compared when opening the form (in recordHasActualChanges function) causing a wrong detection of changes.

To solve the problem now, when refreshCurrentRecord function is executed in grid view, it retrieves just the grid selected properties. Note that this is the behavior when refreshing the whole grid.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0091807)
alostale   
2016-11-25 09:25   
code reviewed + tested
(0092638)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092642)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test