Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033622Openbravo ERPA. Platformpublic2016-08-04 10:232016-08-31 15:12
ReporterJONHM 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q2.1 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033622: Wrong behavior in Select Payment Pick/Execute Window when having >100 records selected
DescriptionWhen having selected >100 payments from "Select Payment" button of [Remmitance] window, if you press that button again and select some others and click "Done", it loses some of the records previously selected
Steps To Reproduce*** Install Remittances infrastructure module and apply dataset
1) Create a new remmitance (http://wiki.openbravo.com/wiki/Projects/Remittances [^])
   1.1) Select "Remittance" from the "Document Type" dropdown.
2) Create a Payment In and select a Bussiness Partner (Make sure to create a linked Financial Account and modify its "Payment Method Tab" as "Deferred", see the video attached")
3) Create a new line of this Payment In (pressing "Add Details" button) -> Select GL Items a create a new one
4) Replicate this record, and its linked line, up to 100 more (with the attached PL script).
5) Create another Payment In from a different Bussiness Partner.
6) Open [Remittance] window and select the line previously created, click into "Select Payments" button and select every record except one. Click Done
7) Then press again into "Select Payments" button and clear the filters. Select the last record and click "Done" again.
8) When pressing one last time into "Select Payments" button and clear the filters. Some records are not selected.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00319893.0PR16Q2 closed caristu Wrong behavior in order/invoices grid in Add Payment process definition when having >100 records selected 
related to defect 0036193 closed alostale DefaultJsonDataService logs an exception if property *obSelected* is not found in the Entity when fetching data for PickAndEdit 
related to defect 0039644 closed alostale Add product p&e is not sorting the selected records when clearing filters 
related to defect 0039821 closed alostale StackOverflowError in P&E having 100+ records selected 
Attached Files? lostLinesRemittance.mp4 (3,653,686) 2016-08-04 10:23
https://issues.openbravo.com/file_download.php?file_id=9675&type=bug
? duplica_function.sql (1,500) 2016-08-18 13:40
https://issues.openbravo.com/file_download.php?file_id=9732&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-08-04 10:23JONHMNew Issue
2016-08-04 10:23JONHMAssigned To => platform
2016-08-04 10:23JONHMFile Added: lostLinesRemittance.mp4
2016-08-04 10:23JONHMModules => Core
2016-08-04 10:23JONHMResolution time => 1470693600
2016-08-04 10:23JONHMTriggers an Emergency Pack => No
2016-08-04 10:23JONHMNote Added: 0088810
2016-08-08 10:53maiteResolution time1470693600 => 1471471200
2016-08-12 15:20caristuRelationship addedrelated to 0031989
2016-08-16 14:39NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-08-16 14:39NaroaIriarteStatusnew => acknowledged
2016-08-18 12:06NaroaIriarteNote Deleted: 0088810
2016-08-18 13:40NaroaIriarteFile Added: duplica_function.sql
2016-08-18 13:41NaroaIriarteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12858#r12858
2016-08-18 14:48NaroaIriarteNote Added: 0089215
2016-08-18 14:53NaroaIriarteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12865#r12865
2016-08-18 15:02NaroaIriarteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12866#r12866
2016-08-18 15:03NaroaIriarteAssigned ToNaroaIriarte => caristu
2016-08-24 08:21caristuStatusacknowledged => scheduled
2016-08-24 10:13hgbotCheckin
2016-08-24 10:13hgbotNote Added: 0089331
2016-08-24 15:00hudsonbotCheckin
2016-08-24 15:00hudsonbotNote Added: 0089347
2016-08-25 10:24hgbotCheckin
2016-08-25 10:24hgbotNote Added: 0089377
2016-08-25 10:24hgbotStatusscheduled => resolved
2016-08-25 10:24hgbotResolutionopen => fixed
2016-08-25 10:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/70c67cc6cf8b69ca2e6cc6b062cad5f9cd97476b [^]
2016-08-25 10:31caristuReview Assigned To => alostale
2016-08-25 10:31caristuIssue Monitored: alostale
2016-08-25 15:08hudsonbotCheckin
2016-08-25 15:08hudsonbotNote Added: 0089399
2016-08-30 12:26alostaleNote Added: 0089548
2016-08-30 12:26alostaleStatusresolved => closed
2016-08-30 12:26alostaleFixed in Version => 3.0PR16Q4
2016-08-31 08:39hgbotCheckin
2016-08-31 08:39hgbotNote Added: 0089575
2016-08-31 15:12hudsonbotCheckin
2016-08-31 15:12hudsonbotNote Added: 0089620
2017-06-07 17:53adrianromeroRelationship addedrelated to 0036193
2018-12-03 16:35alostaleRelationship addedrelated to 0039644
2018-12-17 14:17alostaleRelationship addedrelated to 0039821

Notes
(0089215)
NaroaIriarte   
2016-08-18 14:48   
This issue is failing although the issue https://issues.openbravo.com/view.php?id=31989 [^] fixes the cases of the datasources which extend from the "ReadOnlyDatasourceService".
This is because the datasource of the Select Payments process is a view based datasource and these cases are not handled by the ReadOnlyDatasourceService, these are handled by the DefaultDataSourceService.
One approach to fix this problem could be to apply the fix on the "DefaultJsonDataService" class.
(0089331)
hgbot   
2016-08-24 10:13   
Repository: erp/devel/pi
Changeset: a064f77cbfb91a154149ee935a4ee83e2984b829
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Aug 24 10:12:12 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a064f77cbfb91a154149ee935a4ee83e2984b829 [^]

related to issue 33622: apply correct format

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0089347)
hudsonbot   
2016-08-24 15:00   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3713f446b3f8 [^]
Maturity status: Test
(0089377)
hgbot   
2016-08-25 10:24   
Repository: erp/devel/pi
Changeset: 70c67cc6cf8b69ca2e6cc6b062cad5f9cd97476b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Aug 25 10:23:29 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/70c67cc6cf8b69ca2e6cc6b062cad5f9cd97476b [^]

fixes issue 33622: Selection lost on table/view based P&E having >100 records

Selection could be lost on P&E windows based on a table or a view, having more than 100 records selected. This problem was solved on issue 31989 for those P&E windows based on HQL query tables (this kind of P&E windows make use of a ReadOnlyDataSourceService).

P&E windows based on a table or a view make use of the DefaultDataSourceService which uses DefaultJsonDataService to retrieve data. So, in order to solve the problem, a similar mechanism to the existing one on ReadOnlyDataSourceService has been implemented within DefaultJsonDataService.

Thus, those P&E which use DefaultDataSourceService to retrieve data, now increase the page size dynamically in order to get all selected records in the same request.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceUtils.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
---
(0089399)
hudsonbot   
2016-08-25 15:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e502a641a2e5 [^]
Maturity status: Test
(0089548)
alostale   
2016-08-30 12:26   
code reviewed + tested
(0089575)
hgbot   
2016-08-31 08:39   
Repository: erp/devel/pi
Changeset: 71d43f621ba58afff3f91b3a4b9b49ef9b4dbaa6
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Aug 31 08:37:02 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/71d43f621ba58afff3f91b3a4b9b49ef9b4dbaa6 [^]

related to issue 33622: added javadoc to explain how the new methods work

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0089620)
hudsonbot   
2016-08-31 15:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5d428c349064 [^]
Maturity status: Test