Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032432Openbravo ERPA. Platformpublic2016-03-08 08:282016-03-17 10:56
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032432: incorrect dates issue detection on install.source
DescriptionPrevious PostrgreSQL jdbc had an issue with dates when not using Tomcat pool which was fixed by issue 0031959.

The fix included a module script to detect instances in this situation. This script is executed on install.source incorrectly flagging the instance as being affected by this issue.

This problem affects instances that:
* Do no use Tomcat connection pool
* Are in a pi version between 15Q4 and 16Q1

Note instances in this situation will be flagged as potentially problematic also after this is fixed when they are updated to some version previous to 16Q1 because the script uses core's version number which is pi revision number at the time the issue was fixed +1, as 16Q1 has not been published yet, and version number has not been increased there is no way to properly detect this case.
Steps To Reproduce1. Clone a current pi (between 15Q4 and 16Q1), ie. hg clone https://code.openbravo.com/erp/devel/pi/ [^] -r 45b4ba10bd5d
2. Configure Openbravo.properties to use PG removing db.externalPoolClassName property
3. run ant install.source
  -> Check in log:
       Executing moduleScript: org.openbravo.modulescript.PgJdbcDatesIssue
       Updating from 15PRQ4 potential problems with dates - Some dates can be corrupted. Check http://wiki.openbravo.com/wiki/Release_Notes/Issue31959 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031959 closed caristu Incorrect posting data when not defining an external connection pool on the Openbravo.properties 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-08 08:28alostaleNew Issue
2016-03-08 08:28alostaleAssigned To => platform
2016-03-08 08:28alostaleModules => Core
2016-03-08 08:28alostaleTriggers an Emergency Pack => No
2016-03-08 08:28alostaleRelationship addedrelated to 0031959
2016-03-08 08:30alostaleNote Added: 0084799
2016-03-08 08:30alostaleAssigned Toplatform => alostale
2016-03-08 08:37alostaleReview Assigned To => caristu
2016-03-08 08:52alostaleDescription Updatedbug_revision_view_page.php?rev_id=11385#r11385
2016-03-08 08:54hgbotCheckin
2016-03-08 08:54hgbotNote Added: 0084802
2016-03-08 08:54hgbotStatusnew => resolved
2016-03-08 08:54hgbotResolutionopen => fixed
2016-03-08 08:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/88d23d650314b4f8925a5325d2e1fd29964faef7 [^]
2016-03-11 16:06caristuNote Added: 0084920
2016-03-11 16:06caristuStatusresolved => closed
2016-03-11 16:06caristuFixed in Version => 3.0PR16Q2
2016-03-11 16:33caristuNote Edited: 0084920bug_revision_view_page.php?bugnote_id=0084920#r11420
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085189

Notes
(0084799)
alostale   
2016-03-08 08:30   
Note fix for this issue does not require to be backported as it only affects intermediate versions (and not released) between 15Q4 and 16Q1.
(0084802)
hgbot   
2016-03-08 08:54   
Repository: erp/devel/pi
Changeset: 88d23d650314b4f8925a5325d2e1fd29964faef7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 08 08:54:17 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/88d23d650314b4f8925a5325d2e1fd29964faef7 [^]

fixed issue 32432: incorrect dates issue detection on install.source

  Do not execute PgJdbcDatesIssue module script on install.source.

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/PgJdbcDatesIssue.class
M src-util/modulescript/src/org/openbravo/modulescript/PgJdbcDatesIssue.java
---
(0084920)
caristu   
2016-03-11 16:06   
(edited on: 2016-03-11 16:33)
Verified: PgJdbcDatesIssue modulescript having executeOnInstall() method returning false is not executed on install.source being in a version between 15Q4 and 16Q1.
(0085189)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test