Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031973Openbravo ERPA. Platformpublic2016-01-21 11:052016-03-17 10:54
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031973: detect situation created by issue 31959
DescriptionIssue 0031959 creates a situation where data can be corrupted by setting incorrect dates.

This situation should be detected in order to notify users about possible problems.
Steps To Reproducesee 0031959
Proposed SolutionCreate a module script that generates an alert in case of all of the following conditions are satisfied:
1. PG instance
2. updating from PR14Q4
3. using old pool (note this condition does not cover the case of having used old pool for a while, and later moving to new one)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031959 closed caristu Incorrect posting data when not defining an external connection pool on the Openbravo.properties 
depends on backport 00319743.0PR16Q1 closed alostale detect situation created by issue 31959 
depends on backport 00319753.0PR15Q4.2 closed alostale detect situation created by issue 31959 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-21 11:05alostaleNew Issue
2016-01-21 11:05alostaleAssigned To => alostale
2016-01-21 11:05alostaleModules => Core
2016-01-21 11:05alostaleTriggers an Emergency Pack => No
2016-01-21 11:05alostaleSummarydetect situation created by issue 0031959 => detect situation created by issue 31959
2016-01-21 11:05alostaleRelationship addedrelated to 0031959
2016-01-21 11:06alostaleStatusnew => acknowledged
2016-01-21 11:06alostaleStatusacknowledged => scheduled
2016-01-21 14:05hgbotCheckin
2016-01-21 14:05hgbotNote Added: 0083498
2016-01-21 14:05hgbotStatusscheduled => resolved
2016-01-21 14:05hgbotResolutionopen => fixed
2016-01-21 14:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f8de3bcd78f39e8591a0c0f268a206c4cfdb3298 [^]
2016-01-21 15:19alostaleReview Assigned To => caristu
2016-01-21 16:52caristuNote Added: 0083506
2016-01-21 16:52caristuStatusresolved => closed
2016-01-21 16:52caristuFixed in Version => pi
2016-01-21 16:52caristuFixed in Versionpi => 3.0PR16Q2
2016-01-21 16:54caristuNote Edited: 0083506bug_revision_view_page.php?bugnote_id=0083506#r10742
2016-01-21 16:55caristuNote Edited: 0083506bug_revision_view_page.php?bugnote_id=0083506#r10745
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085062

Notes
(0083498)
hgbot   
2016-01-21 14:05   
Repository: erp/devel/pi
Changeset: f8de3bcd78f39e8591a0c0f268a206c4cfdb3298
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jan 21 12:44:16 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f8de3bcd78f39e8591a0c0f268a206c4cfdb3298 [^]

fixed issue 31973: detect situation created by issue 31959

  Added module script that creates alert when in this situation

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/PgJdbcDatesIssue.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/PgJdbcDatesIssueData.class
A src-util/modulescript/src/org/openbravo/modulescript/PgJdbcDatesIssue.java
A src-util/modulescript/src/org/openbravo/modulescript/PgJdbcDatesIssue_data.xsql
---
(0083506)
caristu   
2016-01-21 16:52   
(edited on: 2016-01-21 16:55)
Code review + tested OK.

 - Modulescript is executed when updating from a version between PR15Q4 and 3.0.28174 (pi version which contains the fix)

 - Modulescript is not executed when updating before and/or after that version range.

 - Alert rule is just created once.
(0085062)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test