Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031212Retail ModulesWeb POSpublic2015-10-22 08:382015-11-08 09:13
Reportermtaal 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031212: Add a preference to control how many products/bp/address/tickets are loaded when searching
DescriptionCurrently as a default we load 300 records to show in the search results.

This feature request is to make this configurable through a preference. As a default the preference does not need to be there, so use 300 in that case.
Steps To ReproduceLogin to webpos
search for products, bps, bp-addresses, tickets
see how many are shown
Proposed SolutionAdd a preference to control the number of data loaded in the search.

One preference can be used for all cases.

Add an automated test for this.

The feature needs to be documented somewhere here:
http://wiki.openbravo.com/wiki/Retail:Configuration_Guide [^]
(maybe add a new subsection, or add it to the remote data preferences only for now).
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031398RR16Q1 closed migueldejuana remote data queries for product and business partner show one more than the data limit 
has duplicate feature request 0030669RR16Q1 closed mtaal Set default pagesize back to 300 and override where needed in hgvol read cases 
causes defect 0034669RR17Q1 closed migueldejuana ProcessHQLQuery returns duplicates causing errors when inserting data and really slow login with many products 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-22 08:38mtaalNew Issue
2015-10-22 08:38mtaalAssigned To => migueldejuana
2015-10-22 08:38mtaalTriggers an Emergency Pack => No
2015-10-26 15:38hgbotCheckin
2015-10-26 15:38hgbotNote Added: 0081316
2015-10-26 15:38hgbotStatusnew => resolved
2015-10-26 15:38hgbotResolutionopen => fixed
2015-10-26 15:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7503f769b934d2052e5aaad4a20191e8dc98e608 [^]
2015-10-26 15:39hgbotCheckin
2015-10-26 15:39hgbotNote Added: 0081318
2015-10-26 15:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7503f769b934d2052e5aaad4a20191e8dc98e608 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5e7cd40ca87de1a48510bafe959f254c1b23b0f8 [^]
2015-10-27 09:42mtaalRelationship addedhas duplicate 0030669
2015-10-30 08:28hgbotCheckin
2015-10-30 08:28hgbotNote Added: 0081391
2015-10-30 08:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5e7cd40ca87de1a48510bafe959f254c1b23b0f8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f56ee2e32ec157889b48c1e1bf025d6abb6ce3e [^]
2015-10-30 08:29hgbotCheckin
2015-10-30 08:29hgbotNote Added: 0081392
2015-10-30 08:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f56ee2e32ec157889b48c1e1bf025d6abb6ce3e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef1d3cc98d32a9f5c4a49bae1d2f1a437d52941c [^]
2015-10-30 08:33hgbotCheckin
2015-10-30 08:33hgbotNote Added: 0081394
2015-11-08 08:46mtaalNote Added: 0081577
2015-11-08 08:46mtaalStatusresolved => new
2015-11-08 08:46mtaalResolutionfixed => open
2015-11-08 08:52mtaalRelationship addedrelated to 0031398
2015-11-08 08:52mtaalStatusnew => scheduled
2015-11-08 08:52mtaalNote Added: 0081578
2015-11-08 08:52mtaalNote Added: 0081579
2015-11-08 08:52mtaalStatusscheduled => resolved
2015-11-08 08:52mtaalFixed in Version => RR16Q1
2015-11-08 08:52mtaalResolutionopen => fixed
2015-11-08 08:52mtaalReview Assigned To => mtaal
2015-11-08 08:52mtaalNote Added: 0081580
2015-11-08 08:52mtaalStatusresolved => closed
2015-11-08 09:13hgbotCheckin
2015-11-08 09:13hgbotNote Added: 0081584
2016-12-01 16:38mtaalRelationship addedcauses 0034669

Notes
(0081316)
hgbot   
2015-10-26 15:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7503f769b934d2052e5aaad4a20191e8dc98e608
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Oct 26 13:29:46 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7503f769b934d2052e5aaad4a20191e8dc98e608 [^]

Fixed issue 0031212: Add a preference to control how many products/bp/address/tickets are loaded when searching

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0081318)
hgbot   
2015-10-26 15:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5e7cd40ca87de1a48510bafe959f254c1b23b0f8
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Oct 26 13:30:34 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5e7cd40ca87de1a48510bafe959f254c1b23b0f8 [^]

Fixed issue 0031212: Add a preference to control how many products/bp/address/tickets are loaded when searching

---
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0081391)
hgbot   
2015-10-30 08:28   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7f56ee2e32ec157889b48c1e1bf025d6abb6ce3e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 28 17:42:29 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f56ee2e32ec157889b48c1e1bf025d6abb6ce3e [^]

Fixed issue 0031212: Add a preference to control how many products/bp/address/tickets are loaded when searching

- Backout previous change
- Share the limit between all queries in ProcessHQLQuery
- Add limit in remote queries and in queries to show UI info in scrollable tables

---
M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-product-browser.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0081392)
hgbot   
2015-10-30 08:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ef1d3cc98d32a9f5c4a49bae1d2f1a437d52941c
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 28 17:44:57 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef1d3cc98d32a9f5c4a49bae1d2f1a437d52941c [^]

Fixed issue 0031212: Add a preference to control how many products/bp/address/tickets are loaded when searching

- Backout previous change
- Share the limit between all queries in ProcessHQLQuery
- Add limit in remote queries and in queries to show UI info in scrollable tables
- Add 3 preference (Order, Customer and Product)

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/components/businesspartner.js
M web/org.openbravo.retail.posterminal/js/components/modalmultiorders.js
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customersadvancedsearch.js
---
(0081394)
hgbot   
2015-10-30 08:33   
Repository: tools/automation/pi-mobile
Changeset: 01f58d3d411552abf09653f926ae9a663a114da6
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 30 08:32:45 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/01f58d3d411552abf09653f926ae9a663a114da6 [^]

Related to issue 0031212: Add a preference to control how many products/bp/address/tickets are loaded when searching

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/EnyoNode.java
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/HighVolSuite.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31212_SearchWithLimitPref.java
---
(0081577)
mtaal   
2015-11-08 08:46   
Hi,
I am reviewing and testing this but I noticed that in case of remote, if I set the preference to 2 that the customer and product search show 3 as a result.

For non-remote it works fine. Can you correct this?
(for the rest the code changes look fine)

gr. Martin
(0081578)
mtaal   
2015-11-08 08:52   
My previous remark has been entered as a separate issue to resolve.

https://issues.openbravo.com/view.php?id=31398 [^]
(0081579)
mtaal   
2015-11-08 08:52   
resolved
(0081580)
mtaal   
2015-11-08 08:52   
Reviewed and tested
(0081584)
hgbot   
2015-11-08 09:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7389c8c6a1181f26d2ed3483b33cc7598f699180
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 08 09:12:45 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7389c8c6a1181f26d2ed3483b33cc7598f699180 [^]

Related to issue 31212: Add a preference to control how many products/bp/address/tickets are loaded when searching
Corrected a tiny spelling mistake in the property name

---
M src-db/database/sourcedata/AD_REF_LIST.xml
---