Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0031021Openbravo ERP09. Financial managementpublic2015-10-01 18:282015-10-05 16:43
egoitz 
vmromanos 
immediatemajoralways
closedfixed 
5
 
3.0PR15Q4 
dmiguelez
Core
Production - QA Approved
2015-05-07
3.0PR15Q3
https://code.openbravo.com/erp/devel/pi/rev/72e2b8bfe6fcf24641d900e00cdb6c38a0731483 [^]
No
0031021: ON the sales order window when selecting a organization that has not got document types some fields are hidden
When creating a new sales order, if the org selected on the combo has not got applicable document types, the organization and partner fields are not shown and the window is not usable until you close it and open again.
-Deactivate all the document types that applies to sales order window
-go to sales order window
-click on new
*See that the organization and partner fields are not shown
Approved
blocks defect 0031015 closed vmromanos ON the sales order window when selecting a organization that has not got document types some fields are hidden 
Issue History
2015-10-02 11:41vmromanosTypedefect => backport
2015-10-02 11:41vmromanosTarget Version => 3.0PR15Q4
2015-10-02 11:42vmromanosTag Attached: Approved
2015-10-05 16:42hgbotCheckin
2015-10-05 16:42hgbotNote Added: 0080826
2015-10-05 16:42hgbotStatusscheduled => resolved
2015-10-05 16:42hgbotResolutionopen => fixed
2015-10-05 16:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/92fed16469f541062e43c3f38a6638e885094858 [^]
2015-10-05 16:43dmiguelezReview Assigned To => dmiguelez
2015-10-05 16:43dmiguelezNote Added: 0080828
2015-10-05 16:43dmiguelezStatusresolved => closed

Notes
(0080826)
hgbot   
2015-10-05 16:42   
Repository: erp/backports/3.0PR15Q4
Changeset: 92fed16469f541062e43c3f38a6638e885094858
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Oct 02 12:39:49 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/92fed16469f541062e43c3f38a6638e885094858 [^]

Fixed bug 31021: hidden fields in several windows related to acct. dimensions

The display logic of some fields driven by the accounting dimension display logic utility was not working fine when the auxiliary input "DOCBASETYPE" (used by to calculate the acct. dimension display logic) was null.
This auxiliary input has a hardcoded value in some windows, however in other windows it is gotten from the DB using the selected document type. In the latter scenario, when the document type field is blank, the "DOCBASETYPE" auxiliary input was null, so the system was unable to detect the right configuration, thus hiding the fields.

The regression is caused by issue 0029767. The business partner and organization fields were configured to use the accounting dimension display logic utility in the following windows:
* Sales Order
* Purchase Order
* Sales Invoice
* Purchase Invoice
* Payment In (not affected as it has a hardcoded "DOCBASETYPE")
* Payment Out (not affected as it has a hardcoded "DOCBASETYPE")

The fix improves the SQL for getting the "DOCBASETYPE" auxiliary input in the affected windows, so in case the document type is null, a generic value (the most commonly used) is returned depending on the window:
* Sales Order: SOO
* Purchase Order: POO
* Sales Invoice: ARI
* Purchase Invoice: API

---
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
---
(0080828)
dmiguelez   
2015-10-05 16:43   
Code Review + Testing Ok