Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029854Openbravo ERPA. Platformpublic2015-05-12 16:272015-08-28 11:45
Reportershuehner 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version3.0PR15Q4 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029854: Weld,integration.google & json modules does not pass 'ant validate.modules'
DescriptionRunning this command in pi shows errors in that module:


ant validate.modules -Dmodule=org.openbravo.service.json

[validateModules] Errors for Validation type: MODULE_ERROR
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Module JSON REST Webservice has UI Artifacts, translation required should be set to 'Y', it is now 'N'.

similar for weld & integration.google modules
Steps To Reproduceant validate.modules -Dmodule=org.openbravo.service.json
ant validate.modules -Dmodule=org.openbravo.base.weld
ant validate.modules -Dmodule=org.openbravo.service.integration.google
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029855 closed shuehner ant validate modules reads excludeFilter.xml from wrong folder 
related to defect 00306803.0PR16Q3 closed alostale Weld module does not pass 'ant validate.modules' 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-12 16:27shuehnerNew Issue
2015-05-12 16:27shuehnerAssigned To => platform
2015-05-12 16:27shuehnerModules => Core
2015-05-12 16:27shuehnerTriggers an Emergency Pack => No
2015-05-12 16:29shuehnerRelationship addedrelated to 0029855
2015-05-12 16:30shuehnerNote Added: 0077343
2015-05-12 16:44shuehnerSummaryWeld module does not pass 'ant validate.modules' => Weld,integration.google & json modules does not pass 'ant validate.modules'
2015-05-12 16:44shuehnerDescription Updatedbug_revision_view_page.php?rev_id=8524#r8524
2015-05-12 16:44shuehnerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8526#r8526
2015-05-13 08:23alostaleStatusnew => acknowledged
2015-08-26 08:47caristuAssigned Toplatform => caristu
2015-08-26 08:47caristuStatusacknowledged => scheduled
2015-08-26 14:30caristuRelationship addedrelated to 0030680
2015-08-26 14:31caristuNote Added: 0079758
2015-08-26 14:32caristuReview Assigned To => AugustoMauch
2015-08-26 14:32caristuFixed in Version => 3.0PR15Q4
2015-08-26 14:32caristuTarget Version => 3.0PR15Q4
2015-08-26 14:33hgbotCheckin
2015-08-26 14:33hgbotNote Added: 0079759
2015-08-26 14:33hgbotStatusscheduled => resolved
2015-08-26 14:33hgbotResolutionopen => fixed
2015-08-26 14:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eae81cf322cbcf0b89c80795de585512d8ce8465 [^]
2015-08-26 14:33caristuIssue Monitored: AugustoMauch
2015-08-26 21:54hudsonbotCheckin
2015-08-26 21:54hudsonbotNote Added: 0079763
2015-08-28 11:45AugustoMauchNote Added: 0079791
2015-08-28 11:45AugustoMauchStatusresolved => closed

Notes
(0077343)
shuehner   
2015-05-12 16:30   
Again but unnoticed meaning -> test not run in normal junit run.

Looks like that part is only running when modules are marked as in development

So that should be reviewed as well.
(0079758)
caristu   
2015-08-26 14:31   
Fixed for integration.google & json modules. A new issue (0030680) has been raised for the weld module, as it requires a more complex solution to be discussed.
(0079759)
hgbot   
2015-08-26 14:33   
Repository: erp/devel/pi
Changeset: eae81cf322cbcf0b89c80795de585512d8ce8465
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Aug 26 14:25:52 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eae81cf322cbcf0b89c80795de585512d8ce8465 [^]

fixes issue 29854: google & json modules does not pass 'ant validate.modules'

---
M modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
---
(0079763)
hudsonbot   
2015-08-26 21:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d7da276db20c [^]
Maturity status: Test
(0079791)
AugustoMauch   
2015-08-28 11:45   
Code reviewed and verified in pi@c86e5f2b1bef