Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0029854 | Openbravo ERP | A. Platform | public | 2015-05-12 16:27 | 2015-08-28 11:45 |
|
| Reporter | shuehner | |
| Assigned To | caristu | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR15Q4 | Fixed in Version | 3.0PR15Q4 | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0029854: Weld,integration.google & json modules does not pass 'ant validate.modules' |
| Description | Running this command in pi shows errors in that module:
ant validate.modules -Dmodule=org.openbravo.service.json
[validateModules] Errors for Validation type: MODULE_ERROR
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Module JSON REST Webservice has UI Artifacts, translation required should be set to 'Y', it is now 'N'.
similar for weld & integration.google modules |
| Steps To Reproduce | ant validate.modules -Dmodule=org.openbravo.service.json
ant validate.modules -Dmodule=org.openbravo.base.weld
ant validate.modules -Dmodule=org.openbravo.service.integration.google
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0029855 | | closed | shuehner | ant validate modules reads excludeFilter.xml from wrong folder | | related to | defect | 0030680 | 3.0PR16Q3 | closed | alostale | Weld module does not pass 'ant validate.modules' |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-05-12 16:27 | shuehner | New Issue | |
| 2015-05-12 16:27 | shuehner | Assigned To | => platform |
| 2015-05-12 16:27 | shuehner | OBNetwork customer | => No |
| 2015-05-12 16:27 | shuehner | Modules | => Core |
| 2015-05-12 16:27 | shuehner | Triggers an Emergency Pack | => No |
| 2015-05-12 16:29 | shuehner | Relationship added | related to 0029855 |
| 2015-05-12 16:30 | shuehner | Note Added: 0077343 | |
| 2015-05-12 16:44 | shuehner | Summary | Weld module does not pass 'ant validate.modules' => Weld,integration.google & json modules does not pass 'ant validate.modules' |
| 2015-05-12 16:44 | shuehner | Description Updated | bug_revision_view_page.php?rev_id=8524#r8524 |
| 2015-05-12 16:44 | shuehner | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=8526#r8526 |
| 2015-05-13 08:23 | alostale | Status | new => acknowledged |
| 2015-08-26 08:47 | caristu | Assigned To | platform => caristu |
| 2015-08-26 08:47 | caristu | Status | acknowledged => scheduled |
| 2015-08-26 14:30 | caristu | Relationship added | related to 0030680 |
| 2015-08-26 14:31 | caristu | Note Added: 0079758 | |
| 2015-08-26 14:32 | caristu | Review Assigned To | => AugustoMauch |
| 2015-08-26 14:32 | caristu | Fixed in Version | => 3.0PR15Q4 |
| 2015-08-26 14:32 | caristu | Target Version | => 3.0PR15Q4 |
| 2015-08-26 14:33 | hgbot | Checkin | |
| 2015-08-26 14:33 | hgbot | Note Added: 0079759 | |
| 2015-08-26 14:33 | hgbot | Status | scheduled => resolved |
| 2015-08-26 14:33 | hgbot | Resolution | open => fixed |
| 2015-08-26 14:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/eae81cf322cbcf0b89c80795de585512d8ce8465 [^] |
| 2015-08-26 14:33 | caristu | Issue Monitored: AugustoMauch | |
| 2015-08-26 21:54 | hudsonbot | Checkin | |
| 2015-08-26 21:54 | hudsonbot | Note Added: 0079763 | |
| 2015-08-28 11:45 | AugustoMauch | Note Added: 0079791 | |
| 2015-08-28 11:45 | AugustoMauch | Status | resolved => closed |
|
Notes |
|
|
|
Again but unnoticed meaning -> test not run in normal junit run.
Looks like that part is only running when modules are marked as in development
So that should be reviewed as well. |
|
|
|
|
|
Fixed for integration.google & json modules. A new issue (0030680) has been raised for the weld module, as it requires a more complex solution to be discussed. |
|
|
|
(0079759)
|
|
hgbot
|
|
2015-08-26 14:33
|
|
Repository: erp/devel/pi
Changeset: eae81cf322cbcf0b89c80795de585512d8ce8465
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Aug 26 14:25:52 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eae81cf322cbcf0b89c80795de585512d8ce8465 [^]
fixes issue 29854: google & json modules does not pass 'ant validate.modules'
---
M modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
---
|
|
|
|
|
|
|
|
|
|
Code reviewed and verified in pi@c86e5f2b1bef |
|