Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030680
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2015-08-26 14:282016-06-17 19:37
ReportercaristuView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revisiondd83dab87b9a
ProjectionnoneETAnoneTarget Version3.0PR16Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030680: Weld module does not pass 'ant validate.modules'

DescriptionRunning this command in pi shows errors in that module:

ant validate.modules -Dmodule=org.openbravo.base.weld

[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Errors for Validation type: MODULE_ERROR
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] The source directory of the Module JBoss Weld is invalid, it contains directories/files (META-INF) which are not part of the javaPackage of the module: org.openbravo.base.weld
Steps To Reproduceant validate.modules -Dmodule=org.openbravo.base.weld
Proposed SolutionAdd a new validation rule to accept files inside META-INF directory of a module
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00298543.0PR15Q4 closedcaristu Weld,integration.google & json modules does not pass 'ant validate.modules' 
related to defect 0029855 closedshuehner ant validate modules reads excludeFilter.xml from wrong folder 
related to defect 0033032 closedalostale SystemValidatorTest is executed only for modules in developement 

-  Notes
(0086696)
hgbot (developer)
2016-05-24 10:07

 Repository: erp/devel/pi
Changeset: dd83dab87b9ad9fbea7671b2c16ed2af8296e395
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 24 10:04:46 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dd83dab87b9ad9fbea7671b2c16ed2af8296e395 [^]

fixed issue 30680: Weld module does not pass 'ant validate.modules'

  Created blacklist that allows to define a META-INF directory inside src.

---
M src/org/openbravo/service/system/ModuleValidator.java
---
(0086697)
hgbot (developer)
2016-05-24 10:12

 Repository: erp/devel/pi
Changeset: 22873b1a8ca5e08d835004172bcd3484153dd30c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 24 10:12:04 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/22873b1a8ca5e08d835004172bcd3484153dd30c [^]

related to issue 30680: clean up SystemValidatorTest

  Removed unused (ignored) test cases

---
M src-test/src/org/openbravo/test/system/SystemValidatorTest.java
---
(0086769)
caristu (viewer)
2016-05-26 18:08

 Code review + testing OK: validation is now successful for Weld module.

Tested on pi@6b69927ae231
(0087560)
hudsonbot (viewer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087561)
hudsonbot (viewer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-08-26 14:28 caristu New Issue
2015-08-26 14:28 caristu Assigned To => platform
2015-08-26 14:28 caristu OBNetwork customer => No
2015-08-26 14:28 caristu Modules => Core
2015-08-26 14:28 caristu Triggers an Emergency Pack => No
2015-08-26 14:29 caristu Description Updated View Revisions
2015-08-26 14:29 caristu Steps to Reproduce Updated View Revisions
2015-08-26 14:30 caristu Relationship added related to 0029854
2015-08-26 14:34 caristu Relationship added related to 0029855
2015-11-10 14:59 alostale Status new => acknowledged
2015-11-11 11:37 alostale Priority high => normal
2016-04-19 10:00 alostale Target Version => 3.0PR16Q3
2016-05-24 10:05 alostale Status acknowledged => scheduled
2016-05-24 10:05 alostale Assigned To platform => alostale
2016-05-24 10:05 alostale Review Assigned To => caristu
2016-05-24 10:07 hgbot Checkin
2016-05-24 10:07 hgbot Note Added: 0086696
2016-05-24 10:07 hgbot Status scheduled => resolved
2016-05-24 10:07 hgbot Resolution open => fixed
2016-05-24 10:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dd83dab87b9ad9fbea7671b2c16ed2af8296e395 [^]
2016-05-24 10:12 hgbot Checkin
2016-05-24 10:12 hgbot Note Added: 0086697
2016-05-24 11:26 alostale Relationship added related to 0033032
2016-05-26 18:08 caristu Note Added: 0086769
2016-05-26 18:08 caristu Status resolved => closed
2016-05-26 18:08 caristu Fixed in Version => pi
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087560
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087561

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker