Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028893Openbravo ERPA. Platformpublic2015-02-09 12:402015-02-10 19:35
Reporteregoitz 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q2Fixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket33980
Regression levelProduction - Confirmed Stable
Regression date2014-12-19
Regression introduced in release3.0PR14Q3.5
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/5d1b178472d15ec2181ae4a6a41be5ad5ddc4591 [^]
Triggers an Emergency PackNo
Summary0028893: Not possible to nullify fields in grid view using window personalization
DescriptionNot possible to nullify a dropdown using window personalization.
It happens when accessing by default to a custom grid view and when the first action peformed after open the window is to open a record on form view.
Steps To Reproduce-Access to the sales order window
-Add on the grid the payment method column.
-Save the view and set as default.
-Close the window
-Open again the sales order window from the menu
-Open a record on form view
-close the form view and go back to the grid
-Edit on grid view a record and try to nullify the payment method combo.
*After save the previous value is restored.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0024705 closed dbaz The windows takes long to be loaed when there are a lot of tabs and a lot of columns on the grid. 
caused by defect 0028454 closed alostale can't nullify fields when 1st edition is in grid 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-09 12:40egoitzNew Issue
2015-02-09 12:40egoitzAssigned To => AugustoMauch
2015-02-09 12:40egoitzOBNetwork customer => Yes
2015-02-09 12:40egoitzModules => Core
2015-02-09 12:40egoitzSupport ticket => 33980
2015-02-09 12:40egoitzTriggers an Emergency Pack => No
2015-02-09 12:43alostaleRelationship addedrelated to 0028454
2015-02-09 12:45egoitzResolution time => 1423954800
2015-02-09 12:45egoitzRegression level => Production - Confirmed Stable
2015-02-09 12:48alostaleAssigned ToAugustoMauch => alostale
2015-02-09 13:02eugeniIssue Monitored: eugeni
2015-02-10 09:11alostaleNote Added: 0074312
2015-02-10 09:25egoitzNote Added: 0074313
2015-02-10 09:29eugeniNote Added: 0074314
2015-02-10 09:33eugeniNote Edited: 0074314bug_revision_view_page.php?bugnote_id=0074314#r7649
2015-02-10 10:22alostaleNote Edited: 0074312bug_revision_view_page.php?bugnote_id=0074312#r7651
2015-02-10 10:23alostaleSummaryNot possible to nullify a dropdown using window personalization => Not possible to nullify fields in grid view using window personalization
2015-02-10 10:41alostaleRelationship addedrelated to 0024705
2015-02-10 10:41alostaleRelationship replacedcaused by 0028454
2015-02-10 10:44alostaleReview Assigned To => AugustoMauch
2015-02-10 10:44alostaleRegression date => 2014-12-19
2015-02-10 10:44alostaleRegression introduced in release => 3.0PR14Q3.5
2015-02-10 10:44alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/5d1b178472d15ec2181ae4a6a41be5ad5ddc4591 [^]
2015-02-10 10:54hgbotCheckin
2015-02-10 10:54hgbotNote Added: 0074316
2015-02-10 10:54hgbotStatusnew => resolved
2015-02-10 10:54hgbotResolutionopen => fixed
2015-02-10 10:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/05b7936848de9683408839560623a291d08e6448 [^]
2015-02-10 11:03alostaleNote Added: 0074317
2015-02-10 13:19AugustoMauchNote Added: 0074323
2015-02-10 13:19AugustoMauchStatusresolved => closed
2015-02-10 13:19AugustoMauchFixed in Version => 3.0PR15Q2
2015-02-10 19:35hudsonbotCheckin
2015-02-10 19:35hudsonbotNote Added: 0074341

Notes
(0074312)
alostale   
2015-02-10 09:11   
(edited on: 2015-02-10 10:22)
Note it only occurs having a saved view if before saving any edition form view is opened and first saved edition is saved in grid view.
(0074313)
egoitz   
2015-02-10 09:25   
Also happens with text fields
(0074314)
eugeni   
2015-02-10 09:29   
(edited on: 2015-02-10 09:33)
In general, it happens when:
- You use a custom view +
- First saved edition is saved in FORM view (it works if first saved edition is saved in grid view)
(0074316)
hgbot   
2015-02-10 10:54   
Repository: erp/devel/pi
Changeset: 05b7936848de9683408839560623a291d08e6448
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 10 10:52:58 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/05b7936848de9683408839560623a291d08e6448 [^]

fixed bug 28893: can't nullify fields in grid view using window personalization

  Using a saved view, if before any edition tab was opened in form view, and
  record edited in grid view, it was not possible to nullify fields.

  The problem was caused by changeset to fix 0028454 which assumed view.formFields
  was always set in order to compute the null fields that should be kept and the
  ones that should be removed when sending data to data source. This assumption was
  not correct in the case of having a saved view: when applying saved view, SmartClient
  removes items in view.formFields.

  The fix includes 2 modifications:
   1. Restore view.formFields after applying saved view
   2. When calculating columns don't assume view.formFields is always set, this part
      wouldn't be necessary for flow 1, but it prevents any other unforeseen possible
      flow

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalization.js
---
(0074317)
alostale   
2015-02-10 11:03   
Added test case in TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8032 [^]
(0074323)
AugustoMauch   
2015-02-10 13:19   
Code reviewed and verified in pi@05b7936848de
(0074341)
hudsonbot   
2015-02-10 19:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/24bb109056f1 [^]
Maturity status: Test