Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0028720 | Openbravo ERP | A. Platform | public | 2015-01-22 09:19 | 2015-02-04 20:34 |
|
| Reporter | jonalegriaesarte | |
| Assigned To | alostale | |
| Priority | immediate | Severity | critical | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR15Q2 | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | Production - Confirmed Stable |
| Regression date | 2015-01-09 |
| Regression introduced in release | 3.0PR14Q3.5 |
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/e5465c5925cf54475d090258a3832ec8cc9d14ca [^] |
| Triggers an Emergency Pack | Yes |
|
| Summary | 0028720: System is not saving big numbers properly |
| Description | System is not saving big numbers properly |
| Steps To Reproduce | - GL Journal window
- Create a new header
- Create a new line
- Add a credit: 10200500.45
- Save it. System stores 1020050045.00 |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0026132 | 3.0PR14Q3 | closed | guillermogil | wrong visualization value of quantity fields with very small numbers | | caused by | defect | 0028552 | 3.0PR15Q2 | closed | alostale | Purchase Invoice amount gets truncated upon saving, when the amount is big | | related to | defect | 0028427 | 3.0PR15Q2 | closed | AugustoMauch | Price is not rounded to calculate the line net amount in Create Lines process of Purchase Order | | related to | defect | 0029709 | | closed | NaroaIriarte | Cannot save a physical inventory line with a negative small number in the Book Quantity field | | related to | defect | 0030014 | | closed | NaroaIriarte | The function OB.Utilities.Number.OBMaskedToOBPlain is not working properly with negative big numbers |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-01-22 09:19 | jonalegriaesarte | New Issue | |
| 2015-01-22 09:19 | jonalegriaesarte | Assigned To | => AugustoMauch |
| 2015-01-22 09:19 | jonalegriaesarte | Modules | => Core |
| 2015-01-22 09:19 | jonalegriaesarte | Resolution time | => 1421881200 |
| 2015-01-22 09:19 | jonalegriaesarte | Triggers an Emergency Pack | => No |
| 2015-01-22 09:25 | alostale | Assigned To | AugustoMauch => alostale |
| 2015-01-22 09:27 | alostale | Relationship added | related to 0028552 |
| 2015-01-22 10:39 | alostale | Relationship replaced | caused by 0028552 |
| 2015-01-22 10:39 | alostale | Relationship added | related to 0026132 |
| 2015-01-22 10:41 | alostale | Regression level | => Production - Confirmed Stable |
| 2015-01-22 10:41 | alostale | Regression date | => 2015-01-09 |
| 2015-01-22 10:41 | alostale | Regression introduced in release | => 3.0PR14Q3.5 |
| 2015-01-22 10:41 | alostale | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/e5465c5925cf54475d090258a3832ec8cc9d14ca [^] |
| 2015-01-22 10:42 | alostale | Note Added: 0073712 | |
| 2015-01-22 10:44 | alostale | Note Added: 0073713 | |
| 2015-01-22 11:16 | hgbot | Checkin | |
| 2015-01-22 11:16 | hgbot | Note Added: 0073714 | |
| 2015-01-22 11:16 | hgbot | Status | new => resolved |
| 2015-01-22 11:16 | hgbot | Resolution | open => fixed |
| 2015-01-22 11:16 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3e5c7b3e8a8f29ba98c312b092eadef36f03aa81 [^] |
| 2015-01-22 11:18 | alostale | Note Added: 0073715 | |
| 2015-01-22 11:18 | alostale | Review Assigned To | => AugustoMauch |
| 2015-01-22 11:21 | alostale | Triggers an Emergency Pack | No => Yes |
| 2015-01-22 13:09 | AugustoMauch | Note Added: 0073721 | |
| 2015-01-22 13:09 | AugustoMauch | Status | resolved => closed |
| 2015-01-22 13:09 | AugustoMauch | Fixed in Version | => 3.0PR15Q2 |
| 2015-01-22 13:11 | AugustoMauch | Note Added: 0073722 | |
| 2015-01-26 08:36 | alostale | Relationship added | related to 0028427 |
| 2015-02-04 20:34 | hudsonbot | Checkin | |
| 2015-02-04 20:34 | hudsonbot | Note Added: 0074172 | |
| 2015-05-26 09:30 | NaroaIriarte | Relationship added | related to 0029709 |
| 2015-05-26 13:20 | NaroaIriarte | Relationship added | related to 0030014 |
|
Notes |
|
|
|
|
It is reproducible in 3.0PR14Q3.5 but not in 3.0PR14Q4 |
|
|
|
|
The problem is caused by fix for issue 0026132 which does not handle properly scientific notation for numbers which are not integer, this problem was hidden until fix for 0028552.
It is only reproducible in case a callout (re)sets numeric values with this case. |
|
|
|
(0073714)
|
|
hgbot
|
|
2015-01-22 11:16
|
|
Repository: erp/devel/pi
Changeset: 3e5c7b3e8a8f29ba98c312b092eadef36f03aa81
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jan 22 11:14:24 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3e5c7b3e8a8f29ba98c312b092eadef36f03aa81 [^]
fixed bug 28720: callouts incorrectly set big non integer numbers
When a big non integer number was set by a callout, decimal separator was removed
resulting in a different number, ie. 10200500.45 resulted in 1020050045.00.
The problem was in the OB.Utilities.Number.ScientificToDecimal JavaScript function
which wrongly assumed scientific exponent always added zeroes to coefficient, which
is not true in this case where exponent determines where the decimal separator is
inserted in the coefficient.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-number.js
---
|
|
|
|
|
|
|
|
|
|
Code reviewed and verified in pi@3e5c7b3e8a8f |
|
|
|
|
|
|
|
|
|