Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027957Openbravo ERPB. User interfacepublic2014-10-23 10:472015-02-04 20:34
Reporterlorenzofidalgo 
Assigned ToAugustoMauch 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2014-05-28
Regression introduced in release3.0PR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/dfda65fa925f89a21eee64f35d7aadb252c90dab [^]
Triggers an Emergency PackNo
Summary0027957: Changing tab can cause that grid records get stuck
DescriptionThis has been reproduced in PR14Q4 & PR14Q3.1. Creating records in grid view in a specific way and changing tab after that triggers that these records does work properly. Some icons can not be clicked.

In PR14Q2.6 these icons can be clicked.
Steps To ReproduceLogin as Openbravo/openbravo.
Using F&B admin role go to Role window.
Create a new record with the following:
-
Name: Test
User Level: Organization
Manual: Checked
-
Save this record.
Go to "Form access" Tab and click in "Create One" link.
Write in "Special Form" field "Audit Trail" and press Enter to select this record .
Click in "Special Form" field and press Enter. A new record will be created.
Go to "Org Access" tab and go again to "Form Access" tab.
You will see that a new record is there and one of those records will have Cancel and Save non-clickable icons in that grid view.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0026702 closed guillermogil On create a record while a filter is applied the focus get lost 
related to defect 0027975 acknowledged Triage Platform Base Under certain conditions the grid buttons disappear after saving a record in grid view. 
related to defect 0028646 closed alostale Grid view creation of prices in the Price tab of the product window is not correct 
Attached Filespng UI error.png (116,747) 2014-10-23 10:49
https://issues.openbravo.com/file_download.php?file_id=7421&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-10-23 10:47lorenzofidalgoNew Issue
2014-10-23 10:47lorenzofidalgoAssigned To => dbaz
2014-10-23 10:47lorenzofidalgoFile Added: UI error.png
2014-10-23 10:47lorenzofidalgoWeb browser => Google Chrome
2014-10-23 10:47lorenzofidalgoModules => Core
2014-10-23 10:47lorenzofidalgoRegression level => Production - QA Approved
2014-10-23 10:47lorenzofidalgoRegression introduced in release => 3.0PR14Q3.1
2014-10-23 10:47lorenzofidalgoTriggers an Emergency Pack => No
2014-10-23 10:48lorenzofidalgoFile Deleted: UI error.png
2014-10-23 10:49lorenzofidalgoFile Added: UI error.png
2014-10-23 11:32AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-10-23 11:32AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6885#r6885
2014-10-23 11:32AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-10-23 11:32AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6886#r6886
2014-10-23 17:16AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-10-23 17:16AugustoMauchRegression date => 2014-05-28
2014-10-23 17:16AugustoMauchRegression introduced in release3.0PR14Q3.1 => 3.0PR14Q3
2014-10-23 17:16AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/dfda65fa925f89a21eee64f35d7aadb252c90dab [^]
2014-10-24 07:26alostaleAssigned Todbaz => AugustoMauch
2014-10-24 07:26alostaleWeb browserGoogle Chrome => Google Chrome
2014-10-24 07:26alostalePrioritynormal => immediate
2014-10-24 07:28alostaleRelationship addedcaused by 0026702
2014-10-24 08:47AugustoMauchNote Added: 0071148
2014-10-24 09:10AugustoMauchNote Added: 0071149
2014-10-24 09:24AugustoMauchIssue Monitored: alostale
2014-10-24 09:24AugustoMauchReview Assigned To => alostale
2014-10-24 09:24AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-10-24 09:42hgbotCheckin
2014-10-24 09:42hgbotNote Added: 0071151
2014-10-24 09:42hgbotStatusnew => resolved
2014-10-24 09:42hgbotResolutionopen => fixed
2014-10-24 09:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5bce36f9c0471513873659882de2e46f539eaf47 [^]
2014-10-24 09:47AugustoMauchNote Added: 0071152
2014-10-24 10:41AugustoMauchRelationship addedrelated to 0027975
2014-10-24 11:06alostaleNote Added: 0071164
2014-10-24 11:06alostaleStatusresolved => new
2014-10-24 11:06alostaleResolutionfixed => open
2014-10-24 11:12alostaleNote Deleted: 0071164
2014-10-24 11:47alostaleStatusnew => scheduled
2014-10-24 11:47alostalefix_in_branch => pi
2014-10-24 11:47alostaleStatusscheduled => resolved
2014-10-24 11:47alostaleFixed in Version => 3.0PR15Q1
2014-10-24 11:47alostaleResolutionopen => fixed
2014-10-24 11:48alostaleNote Added: 0071165
2014-10-24 11:48alostaleStatusresolved => closed
2014-12-30 23:23hudsonbotCheckin
2014-12-30 23:23hudsonbotNote Added: 0072981
2015-01-19 12:17alostaleRelationship addedrelated to 0028646
2015-01-19 12:40hgbotCheckin
2015-01-19 12:40hgbotNote Added: 0073595
2015-01-19 12:40hgbotStatusclosed => resolved
2015-01-19 12:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/5bce36f9c0471513873659882de2e46f539eaf47 [^] => http://code.openbravo.com/erp/devel/pi/rev/b4f4fca525d71f872eca351abd3a3c170facbd73 [^]
2015-01-19 12:41alostaleNote Added: 0073596
2015-01-19 12:41alostaleStatusresolved => closed
2015-02-04 20:34hudsonbotCheckin
2015-02-04 20:34hudsonbotNote Added: 0074156

Notes
(0071148)
AugustoMauch   
2014-10-24 08:47   
Also because of the changeset that caused this regression [1], the following problem is reproducible:
- Open Sales Order
- Clear the filters
- Add any filter
- Add a record in grid view, and save
- Add another record in grid view. The button on the left part of the row you created in the previous step disappear

[1] https://code.openbravo.com/erp/devel/pi/rev/dfda65fa925f89a21eee64f35d7aadb252c90dab [^]
(0071149)
AugustoMauch   
2014-10-24 09:10   
Correction: The bug reported in this note [1] was not caused by the changeset [2] that caused 27957. It will be reported in a separate issue and fixed there.

[1] https://issues.openbravo.com/view.php?id=27957#c71148 [^]
[2] https://code.openbravo.com/erp/devel/pi/rev/dfda65fa925f89a21eee64f35d7aadb252c90dab [^]
(0071151)
hgbot   
2014-10-24 09:42   
Repository: erp/devel/pi
Changeset: 5bce36f9c0471513873659882de2e46f539eaf47
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Oct 24 09:38:26 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5bce36f9c0471513873659882de2e46f539eaf47 [^]

Fixes issue 27957: Grid button don't get stuck after autosaving new record

In the fix [1] of this issue [2], a change was made to force reselecting a new record even if it was already selected, because otherwise when a record was created in grid mode while a filter was applied, when the record was saved the selection was lost.

The problem is that that change should only be applied when the editCompletionEvent is 'programmatic'. In the other cases (i.e. 'tab', 'enter', etc), the focus goes to another record, so it did not apply to [2]. In fact when the editCompletion event is not 'programmatic' not only reselecting the record was not needed, but also it caused the grid buttons to get stuck.

[1] https://code.openbravo.com/erp/devel/pi/rev/dfda65fa925f89a21eee64f35d7aadb252c90dab [^]
[2] https://issues.openbravo.com/view.php?id=26702 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0071152)
AugustoMauch   
2014-10-24 09:47   
Test plan:
- Test that https://issues.openbravo.com/view.php?id=26702 [^] is still not reproducible. There are several ways to save the record while keeping it selected:
  * By pressing the Save toolbar button
  * By pressing the Save grid button
  * By pressing Ctrl+S
- Test that https://issues.openbravo.com/view.php?id=27957 [^] is no longer reproducible. There are several ways to save a record and create new one at the same time:
  * With the focus on a field, press Enter
  * Press Tab when the focus is in the last editable field
(0071165)
alostale   
2014-10-24 11:48   
code reviewed

tested both current issue and the one causing it
(0072981)
hudsonbot   
2014-12-30 23:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073595)
hgbot   
2015-01-19 12:40   
Repository: erp/devel/pi
Changeset: b4f4fca525d71f872eca351abd3a3c170facbd73
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jan 19 12:35:25 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b4f4fca525d71f872eca351abd3a3c170facbd73 [^]

fixed bug 27957: new child grid record fails after parent new grid record

  When a new record was created in child grid view for a child tab just after
  creating its parent in grid view, it failed creating the second record for
  that child tab.

  The problem was caused by an extra request to child tab due to incorrect sync
  between lastSelectedRecord and getSelectedRecord for parent tab, lastSelectedRecord
  kept the temporary id for new records.

  The solution updates the selection once the parent one has been saved.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0073596)
alostale   
2015-01-19 12:41   
reclosing, incorrect changeset commit msg
(0074156)
hudsonbot   
2015-02-04 20:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test