Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027860Openbravo ERPB. User interfacepublic2014-10-14 11:062014-10-14 17:26
Reporterlorenzofidalgo 
Assigned Toalostale 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2014-04-14
Regression introduced in release3.0PR14Q3
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/c41ba68ffe3860bf996b34e3858c9d05ab6fa99b [^]
Triggers an Emergency PackNo
Summary0027860: "Go to previous/next record" malfunctioning when used with auto-save
DescriptionUsing auto-save when clicking "Go to previous record" or "Go to next record" button triggers that the interface does not work properly.

This happends when you do some change in your form and instead of clicking save, you click "go to previous/next record" allowing auto-save to record the changes. What actually happends is that the "go to previous/next record" buttons get disabled and there are some other malfunctioning.

Steps To ReproduceLogIn as Openbravo/openbravo.
Using default F&B admin user, go to sales order (for example).
Remove filters (clicking funnel).
Enter into the first record. (Form view).
Change "Invoice Terms" field to Immediate. (Some different value than the one you have).
After that, click "Go to next record". You will see that the "Go to next/previous record" are disabled. Moreover, the "Save changes" button is enabled, but, actually the previous changes are already saved.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0025125 closed guillermogil Creating a new Sales Order in Form view puts the Organization field as disabled 
Attached Filespng Auto-Save Regresion.png (187,622) 2014-10-14 11:06
https://issues.openbravo.com/file_download.php?file_id=7357&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-10-14 11:06lorenzofidalgoNew Issue
2014-10-14 11:06lorenzofidalgoAssigned To => dbaz
2014-10-14 11:06lorenzofidalgoFile Added: Auto-Save Regresion.png
2014-10-14 11:06lorenzofidalgoOBNetwork customer => No
2014-10-14 11:06lorenzofidalgoWeb browser => Google Chrome
2014-10-14 11:06lorenzofidalgoModules => Core
2014-10-14 11:06lorenzofidalgoRegression level => Production - QA Approved
2014-10-14 11:06lorenzofidalgoRegression introduced in release => 3.0PR14Q3
2014-10-14 11:06lorenzofidalgoTriggers an Emergency Pack => No
2014-10-14 14:58alostaleWeb browserGoogle Chrome => Google Chrome
2014-10-14 14:58alostaleAssigned Todbaz => alostale
2014-10-14 14:58alostalePriorityhigh => immediate
2014-10-14 14:58alostaleRelationship addedcaused by 0025125
2014-10-14 14:59alostaleWeb browserGoogle Chrome => Google Chrome
2014-10-14 14:59alostaleRegression date => 2014-04-14
2014-10-14 14:59alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/c41ba68ffe3860bf996b34e3858c9d05ab6fa99b [^]
2014-10-14 15:22alostaleReview Assigned To => AugustoMauch
2014-10-14 15:22alostaleWeb browserGoogle Chrome => Google Chrome
2014-10-14 15:39alostaleNote Added: 0070930
2014-10-14 15:40hgbotCheckin
2014-10-14 15:40hgbotNote Added: 0070931
2014-10-14 15:40hgbotStatusnew => resolved
2014-10-14 15:40hgbotResolutionopen => fixed
2014-10-14 15:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/62f6dc70bced48249a5c3fa8620f6fac97104f65 [^]
2014-10-14 17:26AugustoMauchNote Added: 0070935
2014-10-14 17:26AugustoMauchStatusresolved => closed
2014-10-14 17:26AugustoMauchFixed in Version => pi

Notes
(0070930)
alostale   
2014-10-14 15:39   
Executed test cases:

-Next/previous buttons trigger autosave and the loaded record is not in new mode (next/previous are enabled, * in tab title is not present and save is disabled)
-Same using keyboard shortcuts

Issue 0025125 can't be reproduced after the new fix.
(0070931)
hgbot   
2014-10-14 15:40   
Repository: erp/devel/pi
Changeset: 62f6dc70bced48249a5c3fa8620f6fac97104f65
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Oct 14 15:35:37 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/62f6dc70bced48249a5c3fa8620f6fac97104f65 [^]

fixed 27860: "Go to previous/next record" with autosave set new state

  When previous/next record button is used on a non saved record and autosave is
  executed. The loaded record is set with new UI.

  The problem was the way used to determine after save if current record is new or
  not: it checked if ID changed, which is correct in case of triggering autosave
  with new button but not if it is triggered with next/back.

  Using now for.isNewRecord to determine the same.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0070935)
AugustoMauch   
2014-10-14 17:26   
Code reviewed and verified in pi@62f6dc70bced