Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0027730Openbravo ERPB. User interfacepublic2014-10-01 19:292014-12-30 23:22
jonalegriaesarte 
AugustoMauch 
immediateminorhave not tried
closedfixed 
5
 
3.0PR15Q13.0PR15Q1 
alostale
Core
Production - Confirmed Stable
2014-06-11
3.0PR14Q2.2
https://code.openbravo.com/erp/devel/pi/rev/b4ba48792e4850c804c42001d8f818f1e0575f81 [^]
No
0027730: Enter key at the end of the line does not work as expected in grid view
Enter key at the end of the line does not work as expected. In MP31.X, the enter key at the end of the line in grid view created a new line in the grid. After PR14Q2.X series, it is not working anymore.
- Sales invoice window. Create a new header
- In grid view, create a new record in the Lines tab, and in the last field of the grid (Tax), press enter. Nothing happens (tab key is working fine, it creates a new record saving the actual one).

This only happens if the last field (Tax) is not modified by the user, or if the user clicks on the field unselecting all the text before pressing enter
No tags attached.
caused by defect 00268173.0PR14Q3 closed shankarb In Financial Account window, autosave is wrongly triggered while navigating with keyboard 
related to defect 0028646 closed alostale Grid view creation of prices in the Price tab of the product window is not correct 
Issue History
2014-10-01 19:29jonalegriaesarteNew Issue
2014-10-01 19:29jonalegriaesarteAssigned To => AugustoMauch
2014-10-01 19:29jonalegriaesarteModules => Core
2014-10-01 19:29jonalegriaesarteTriggers an Emergency Pack => No
2014-10-01 19:31jonalegriaesarteSeveritymajor => minor
2014-10-02 12:41AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6716#r6716
2014-10-02 14:35AugustoMauchRegression level => Production - Confirmed Stable
2014-10-02 14:35AugustoMauchRegression date => 2014-06-11
2014-10-02 14:35AugustoMauchRegression introduced in release => 3.0PR14Q2.2
2014-10-02 14:35AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b4ba48792e4850c804c42001d8f818f1e0575f81 [^]
2014-10-03 13:15AugustoMauchRelationship addedcaused by 0026817
2014-10-03 13:46AugustoMauchIssue Monitored: alostale
2014-10-03 13:47AugustoMauchReview Assigned To => alostale
2014-10-03 13:47hgbotCheckin
2014-10-03 13:47hgbotNote Added: 0070692
2014-10-03 13:47hgbotCheckin
2014-10-03 13:47hgbotNote Added: 0070693
2014-10-03 13:47hgbotStatusnew => resolved
2014-10-03 13:47hgbotResolutionopen => fixed
2014-10-03 13:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ff95c8c768e799db4f7d8ea1d43edd1edf793beb [^]
2014-10-06 08:58alostaleNote Added: 0070723
2014-10-06 08:58alostaleStatusresolved => closed
2014-10-06 08:58alostaleFixed in Version => 3.0PR15Q1
2014-12-30 23:22hudsonbotCheckin
2014-12-30 23:22hudsonbotNote Added: 0072886
2014-12-30 23:22hudsonbotCheckin
2014-12-30 23:22hudsonbotNote Added: 0072887
2015-01-19 12:17alostaleRelationship addedrelated to 0028646

Notes
(0070692)
hgbot   
2014-10-03 13:47   
Repository: erp/devel/pi
Changeset: 7d7b36e1e61e8c2f2749f4ff3c6107fd7215bb36
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Oct 03 13:12:58 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7d7b36e1e61e8c2f2749f4ff3c6107fd7215bb36 [^]

Related with issue 27730: Adds missing js formatting

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0070693)
hgbot   
2014-10-03 13:47   
Repository: erp/devel/pi
Changeset: ff95c8c768e799db4f7d8ea1d43edd1edf793beb
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Oct 03 13:46:05 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff95c8c768e799db4f7d8ea1d43edd1edf793beb [^]

Fixes issue 27730: Pressing enter in the last editable grid line creates record

The fix [1] of this issue [2] added a check to prevent creating a new line when, in an editable grid, a value was selected from a picklist by pressing the Enter key. The fix consisted in overwriting the ha
ndleKeyPress function of TextItem. The problem was that because of the way the fix was implemented, the new function was invoked but the original implementation of TextItem.handleKeyPress was never execute
d. This missing code was causing a strange behaviour in how the EventHandler set the items that are object of the events, and as a result of this the current issue was being reproducible.

To fix this, the issue [2] has been implemented differently. The root cause of that issue is that the keyDown event was done in a formitem (the selector) and the keyPress on another item (in this case the
description column). When this was detected, the call the handleKeyPress was intercepted to prevent adding a new line. Now, the interception is done in the cellEditEnd. This has two benefits:
- handleKeyPress is not overwritten, so the problems caused by the missing TextItem.handleKeyPress invocation disappear
- the interception is done in a more specific point. handleKeyPress is called constantly, but the cellEditEnd is only called when the focus leaves a grid cell.

[1] https://code.openbravo.com/erp/devel/pi/rev/b4ba48792e4850c804c42001d8f818f1e0575f81 [^]
[2] https://issues.openbravo.com/view.php?id=26817 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0070723)
alostale   
2014-10-06 08:58   
Code reviewed.

Tested:
-Defined steps to reproduce in issue
-Issue 0026817 is still not reproducible. Tested: http://tools.openbravo.com:8891/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-7695 [^]
(0072886)
hudsonbot   
2014-12-30 23:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0072887)
hudsonbot   
2014-12-30 23:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test