Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0023553Openbravo ERPA. Platformpublic2013-04-15 23:502013-06-26 17:00
jonalegriaesarte 
alostale 
normalminorhave not tried
closedfixed 
5
 
3.0MP253.0MP25 
AugustoMauch
Core
No
0023553: Problems with build being terminated for an ondemand instance when same user logs in
With an ondemand instance there each named user is only allowed to have a single session at a time. This means that when same user tries to log in for second time, the first session for this user is
kicked out. When doing a build at that time, in theory the build should continue and terminate normally, but in reality the build is cut off and this is
causing issues.
- Activate an instance using a training activation key
- Install a module an rebuild the system
- Access to the system using the same user (from other browser)
No tags attached.
related to design defect 0024136 new AugustoMauch New sessions when system is being rebuilt 
Issue History
2013-04-15 23:50jonalegriaesarteNew Issue
2013-04-15 23:50jonalegriaesarteAssigned To => AugustoMauch
2013-04-15 23:50jonalegriaesarteModules => Core
2013-04-15 23:50jonalegriaesarteTriggers an Emergency Pack => No
2013-04-25 12:01AugustoMauchAssigned ToAugustoMauch => alostale
2013-05-14 11:16alostaleSummaryProblems with build being terminated for an ondemand instance when another user logs in => Problems with build being terminated for an ondemand instance when same user logs in
2013-05-14 11:19alostaleDescription Updatedbug_revision_view_page.php?rev_id=4715#r4715
2013-05-14 11:59alostaleNote Added: 0058634
2013-05-14 13:47shuehnerNote Added: 0058640
2013-05-14 13:47shuehnerIssue Monitored: shuehner
2013-05-14 21:24dmitry_mezentsevNote Added: 0058649
2013-06-19 11:33alostaleRelationship addedrelated to 0024136
2013-06-19 11:38alostaleNote Added: 0059523
2013-06-19 11:46alostaleNote Added: 0059524
2013-06-19 12:30alostaleReview Assigned To => AugustoMauch
2013-06-19 12:30hgbotCheckin
2013-06-19 12:30hgbotNote Added: 0059525
2013-06-19 12:30hgbotStatusnew => resolved
2013-06-19 12:30hgbotResolutionopen => fixed
2013-06-19 12:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b66b4699be6320e0831e3423ecb9529787435c63 [^]
2013-06-20 02:08hudsonbotCheckin
2013-06-20 02:08hudsonbotNote Added: 0059595
2013-06-26 17:00AugustoMauchNote Added: 0059684
2013-06-26 17:00AugustoMauchStatusresolved => closed
2013-06-26 17:00AugustoMauchFixed in Version => 3.0MP25

Notes
(0058634)
alostale   
2013-05-14 11:59   
Proposed fix:

While the system is being rebuilt, allow concurrently access to the same named user with System Admin role.

This prevents the session launching the build process to be killed and allows to solve potential problems during the rebuild.
(0058640)
shuehner   
2013-05-14 13:47   
Or maybe prevent concurrent access giving message to 2nd user trying to do the login.
Problem is also that any concurrent session may make all the rebuild stuck. So allowing any other session may not be a good idea.
(0058649)
dmitry_mezentsev   
2013-05-14 21:24   
I like Stefan´s approach more.
From scratch I cannot easily see a use case when during rebuild another system admin access (or any other user access, which I think is already restricted) is needed.
It is also not On Demand specific and can make rebuild more robust.

Go?
(0059523)
alostale   
2013-06-19 11:38   
After discussing with Antonio Stefan's and Dimitry's proposal we agreed not to implement it as this would require a deeper analysis to understand in which cases new sessions should be allowed and in which not. A design defect (0024136) has been reported for it.

For this issue the solution will be the initially proposed one.
(0059524)
alostale   
2013-06-19 11:46   
I'm unable to reproduce this issue.

Even 2nd session kills 1st one, which launched the rebuild process. Rebuild continues till the end.

In any case the problem is as 1st session is killed, no feedback about progress is given.
(0059525)
hgbot   
2013-06-19 12:30   
Repository: erp/devel/pi
Changeset: b66b4699be6320e0831e3423ecb9529787435c63
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jun 19 12:29:08 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b66b4699be6320e0831e3423ecb9529787435c63 [^]

fixed bug 23553: Killed on-demand out of platform session when in build process

---
M src/org/openbravo/base/secureApp/LoginHandler.java
---
(0059595)
hudsonbot   
2013-06-20 02:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5caf871044ad [^]

Maturity status: Test
(0059684)
AugustoMauch   
2013-06-26 17:00   
Code reviewed and verified in pi@6232afbf1b0d