Openbravo Issue Tracking System - Openbravo ERP
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0023344||Openbravo ERP||A. Platform||public||2013-03-19 17:45||2013-03-21 17:52|
|Priority||immediate||Severity||major||Reproducibility||have not tried|
|Target Version||Fixed in Version||3.0MP22|
|Review Assigned To||AugustoMauch|
|Regression introduced in release|
|Regression introduced by commit|
|Triggers an Emergency Pack||No|
|Summary||0023344: API Change - Remove Smart Sprites functionality|
|Description||The Smart Sprites functionality improves the performance when lots of images have to be loaded in a window by aggregating them into a sprite, so that instead of using one connection for each image only one connection per sprite is needeed.|
This issue  raised an inconsistency with the Google Collect library. There are two different versions of it in Openbravo, one in lib/build and another one in modules/org.openbravo.base.weld/lib/runtime/.
The one located is lib/build is very old and is only used by the Smart Sprites functionality. The one located in modules/org.openbravo.base.weld/lib/runtime/ is used by Weld and by some new coworking functionality. Smart Sprites is not compatible with the new version of the library because it depends on some deprecated code, and Weld and the coworking development do not work with the old version.
The only viable choice that we can think to fix this inconsistency is to delete the old library and to get rid of the Smart Sprites functionality.
These are some reasons why we should removing this feature is not risky:
- It has almost no value in Openbravo 3.0. If activated, this feature would only be used in the Login window and in the 2.50 windows. Even in those cases the performance is virtually the same.
- It is disabled by default which means that we were unclear about its value from the beginning, and that all users who have not change this property will not even notice this API change.
To remove this functionality the public method applySpriteTags of the RTLSkin class would have to be removed. This will be an API change, but only because the signature of the method is wrong in the first place, because it should have been a private method, because it only makes sense using it inside that class.
 https://issues.openbravo.com/view.php?id=23082 [^]
|Steps To Reproduce||-|
|Tags||No tags attached.|
|2013-03-19 17:45||AugustoMauch||New Issue|
|2013-03-19 17:45||AugustoMauch||Assigned To||=> iciordia|
|2013-03-19 17:45||AugustoMauch||Modules||=> Core|
|2013-03-19 17:45||AugustoMauch||Triggers an Emergency Pack||=> No|
|2013-03-19 17:46||AugustoMauch||Relationship added||related to 0023082|
|2013-03-19 17:51||AugustoMauch||Description Updated||bug_revision_view_page.php?rev_id=4520#r4520|
|2013-03-19 18:15||iciordia||Note Added: 0057315|
|2013-03-19 18:15||iciordia||Assigned To||iciordia => AugustoMauch|
|2013-03-21 17:50||AugustoMauch||Status||new => scheduled|
|2013-03-21 17:50||AugustoMauch||fix_in_branch||=> pi|
|2013-03-21 17:50||AugustoMauch||Status||scheduled => resolved|
|2013-03-21 17:50||AugustoMauch||Fixed in Version||=> 3.0MP22|
|2013-03-21 17:50||AugustoMauch||Fixed in SCM revision||=> https://code.openbravo.com/erp/devel/pi/rev/47d740ad4b2c3d628f71608b61abb3277a5db740 [^]|
|2013-03-21 17:50||AugustoMauch||Resolution||open => fixed|
|2013-03-21 17:52||AugustoMauch||Review Assigned To||=> AugustoMauch|
|2013-03-21 17:52||AugustoMauch||Note Added: 0057375|
|2013-03-21 17:52||AugustoMauch||Status||resolved => closed|