Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022903Openbravo ERPB. User interfacepublic2013-01-28 10:152016-10-24 10:13
Reportercaristu 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP21Fixed in Version3.0MP21 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022903: Focus is lost when changing the images in Client window
DescriptionAfter upload a new image on the Client window, the focus is lost on the Information tab and it is gained by the header.

This causes that the user must return to the Information tab in order to save the record.

Also, if the autosave preference is set to "N", this problem causes that is not possible to change the image logos.
Steps To Reproduce1) As group admin role, go to the Information tab in General Setup > Client > Client Window
2) Upload a new image for the "Your Company Big Image" tab
3) After upload the image the focus is on the header instead of in the Information tab.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034057 closed NaroaIriarte Wrong Tabulation Order in form fields in Organization window 
Attached Filesdiff issue22903.diff (930) 2013-02-04 11:41
https://issues.openbravo.com/file_download.php?file_id=5921&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-01-28 10:15caristuNew Issue
2013-01-28 10:15caristuAssigned To => dbaz
2013-01-28 10:15caristuModules => Core
2013-01-28 10:15caristuResolution time => 1334181600
2013-01-28 10:15caristuTriggers an Emergency Pack => No
2013-01-28 10:15caristuIssue Monitored: networkb
2013-01-28 10:51dbazAssigned Todbaz => AugustoMauch
2013-01-28 16:05caristuResolution time1334181600 => 1365717600
2013-02-01 13:53caristuDescription Updatedbug_revision_view_page.php?rev_id=4343#r4343
2013-02-04 11:41AugustoMauchFile Added: issue22903.diff
2013-02-04 11:41AugustoMauchNote Added: 0056124
2013-02-04 11:41AugustoMauchStatusnew => scheduled
2013-02-04 11:41AugustoMauchfix_in_branch => pi
2013-02-12 13:03AugustoMauchIssue Monitored: shankarb
2013-02-12 13:03AugustoMauchReview Assigned To => shankarb
2013-02-12 13:03AugustoMauchfix_in_branchpi =>
2013-02-12 13:03hgbotCheckin
2013-02-12 13:03hgbotNote Added: 0056375
2013-02-12 13:03hgbotStatusscheduled => resolved
2013-02-12 13:03hgbotResolutionopen => fixed
2013-02-12 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4c3694e1e6a9a290f357295dfd4d442792ffaf10 [^]
2013-02-14 17:59hgbotCheckin
2013-02-14 17:59hgbotNote Added: 0056453
2013-02-14 18:01AugustoMauchNote Added: 0056455
2013-02-14 18:01AugustoMauchStatusresolved => new
2013-02-14 18:01AugustoMauchResolutionfixed => open
2013-02-18 15:33hgbotCheckin
2013-02-18 15:33hgbotNote Added: 0056523
2013-02-18 15:33hgbotStatusnew => resolved
2013-02-18 15:33hgbotResolutionopen => fixed
2013-02-18 15:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4c3694e1e6a9a290f357295dfd4d442792ffaf10 [^] => http://code.openbravo.com/erp/devel/pi/rev/bbea27a4c28604f2614e581b5c13281b62b1ea70 [^]
2013-02-20 04:50hudsonbotCheckin
2013-02-20 04:50hudsonbotNote Added: 0056581
2013-02-20 04:50hudsonbotCheckin
2013-02-20 04:50hudsonbotNote Added: 0056605
2013-02-20 04:50hudsonbotCheckin
2013-02-20 04:50hudsonbotNote Added: 0056620
2013-02-26 12:45shankarbNote Added: 0056769
2013-02-26 12:45shankarbStatusresolved => closed
2013-02-26 12:45shankarbFixed in Version => 3.0MP21
2016-10-24 10:13NaroaIriarteRelationship addedrelated to 0034057

Notes
(0056124)
AugustoMauch   
2013-02-04 11:41   
A fix for this issue has been attached. It will be pushed to pi once pi is unfrozen.
(0056375)
hgbot   
2013-02-12 13:03   
Repository: erp/devel/pi
Changeset: 4c3694e1e6a9a290f357295dfd4d442792ffaf10
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 12 13:02:37 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4c3694e1e6a9a290f357295dfd4d442792ffaf10 [^]

Fixes issue 22903: Focus is not lost when changing images in Client window

When the Upload button of the popup was clicked the processEvent function of ob-eventthandler was executed. This function, among other things, tries to set as active view the view that owns the button. The problem was that the view being set as active was not the pop up, but the header tab of the window. This has been fixed by preventing this from happening where the window where the event originates is a popup.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-eventhandler.js
---
(0056453)
hgbot   
2013-02-14 17:59   
Repository: erp/devel/pi
Changeset: d63da0e5792ab64b3409c64fb873b48c87a7bcaf
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 14 17:59:09 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d63da0e5792ab64b3409c64fb873b48c87a7bcaf [^]

Related to issue 22903, 23081. Backout fix of 22903, it might be causing 23081

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-eventhandler.js
---
(0056455)
AugustoMauch   
2013-02-14 18:01   
This issue has been backed out because it might be breaking the automated tests: https://issues.openbravo.com/view.php?id=23081 [^]
(0056523)
hgbot   
2013-02-18 15:33   
Repository: erp/devel/pi
Changeset: bbea27a4c28604f2614e581b5c13281b62b1ea70
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 18 15:32:30 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bbea27a4c28604f2614e581b5c13281b62b1ea70 [^]

Fixes issue 22903: Reapplies fix of issue 22903, it did not cause a regression

The changeset that caused the regression [1] was not the fix of [2], but the fix of [3]. The fix of [2] is being reapplied, the fix of [3] has been backed out already.

[1] https://issues.openbravo.com/view.php?id=23081 [^]
[2] https://issues.openbravo.com/view.php?id=22903 [^]
[3] https://issues.openbravo.com/view.php?id=22821 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-eventhandler.js
---
(0056581)
hudsonbot   
2013-02-20 04:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056605)
hudsonbot   
2013-02-20 04:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056620)
hudsonbot   
2013-02-20 04:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056769)
shankarb   
2013-02-26 12:45   
Code reviewed and tested in pi changeset 059d60b862a4