Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0020133Openbravo ERPA. Platformpublic2012-03-28 12:392012-04-02 12:19
psarobe 
alostale 
normalmajoralways
closedfixed 
5
pi 
3.0MP9 
Core
No
0020133: Some fields have changed from text area to text field
At list happens in widgets define as HTML url and in every windows (section note)
Go to Sales order window in form view
Open Notes section

The field is a text field instead of a text area
Regression QA
related to defect 00194033.0MP9 closed guilleaer Wrong performance of Rowspan value. 
has duplicate defect 00201343.0MP9 closed alostale Small Notes text field 
Issue History
2012-03-28 12:39psarobeNew Issue
2012-03-28 12:39psarobeAssigned To => alostale
2012-03-28 12:39psarobeModules => Core
2012-03-28 12:39psarobeStatusnew => scheduled
2012-03-28 12:39psarobefix_in_branch => pi
2012-03-28 12:39psarobeTag Attached: Regression QA
2012-03-28 12:45psarobeRelationship addedhas duplicate 0020134
2012-03-28 13:05alostaleNote Added: 0046824
2012-03-28 13:21alostaleRelationship addedrelated to 0019403
2012-03-28 13:26alostaleNote Added: 0046827
2012-03-28 13:27hgbotCheckin
2012-03-28 13:27hgbotNote Added: 0046828
2012-03-28 13:27hgbotStatusscheduled => resolved
2012-03-28 13:27hgbotResolutionopen => fixed
2012-03-28 13:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f022f458e555e4c3b9965b425f454a031d02ba0f [^]
2012-03-28 15:04guilleaerNote Added: 0046835
2012-03-28 15:04guilleaerStatusresolved => closed
2012-03-28 15:04guilleaerFixed in Version => 3.0MP10
2012-04-01 20:35hgbotCheckin
2012-04-01 20:35hgbotNote Added: 0047023
2012-04-01 20:35hgbotStatusclosed => resolved
2012-04-01 20:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f022f458e555e4c3b9965b425f454a031d02ba0f [^] => http://code.openbravo.com/erp/devel/pi/rev/41f372e573206e1fb728289e5ee8a1f4527a48e1 [^]
2012-04-02 06:12hudsonbotCheckin
2012-04-02 06:12hudsonbotNote Added: 0047258
2012-04-02 12:18gorka_gilNote Added: 0047302
2012-04-02 12:18gorka_gilStatusresolved => closed
2012-04-02 12:19gorka_gilFixed in Version3.0MP10 => 3.0MP9
2012-04-02 12:19gorka_gilfix_in_branchpi =>

Notes
(0046824)
alostale   
2012-03-28 13:05   
Issue introduced in fix for 0019403
(0046827)
alostale   
2012-03-28 13:26   
Not risky fix.

Test plan:

-See steps to reproduce defined in 0020134
-Ensure rowSpan stills working: 0019403
(0046828)
hgbot   
2012-03-28 13:27   
Repository: erp/devel/pi
Changeset: f022f458e555e4c3b9965b425f454a031d02ba0f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 28 13:25:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f022f458e555e4c3b9965b425f454a031d02ba0f [^]

fixed bug 20133: Small Notes text field

  Prior to fix for 0019403 text area items where heigh fixed, not taking into account rowSpan
  looking like rowSpan=2. Now, rowSpan is taken into account to display text area height. In case
  it is not set it takes a value of 1, making text area without row span to look smaller that before.

  This fix defaults row span to 2 in case it is not set, so it looks like it did before 0019403.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-textarea.js
---
(0046835)
guilleaer   
2012-03-28 15:04   
Code reviewed and tested in pi@14aebcd32052
(0047023)
hgbot   
2012-04-01 20:35   
Repository: erp/devel/pi
Changeset: 41f372e573206e1fb728289e5ee8a1f4527a48e1
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 28 13:25:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/41f372e573206e1fb728289e5ee8a1f4527a48e1 [^]

fixed bug 20133: Small Notes text field

  Prior to fix for 0019403 text area items where heigh fixed, not taking into account rowSpan
  looking like rowSpan=2. Now, rowSpan is taken into account to display text area height. In case
  it is not set it takes a value of 1, making text area without row span to look smaller that before.

  This fix defaults row span to 2 in case it is not set, so it looks like it did before 0019403.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-textarea.js
---
(0047258)
hudsonbot   
2012-04-02 06:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047302)
gorka_gil   
2012-04-02 12:18   
Reopened by merge.