Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0019984 | Openbravo ERP | A. Platform | public | 2012-03-08 14:12 | 2012-04-02 10:24 |
|
| Reporter | AugustoMauch | |
| Assigned To | AugustoMauch | |
| Priority | immediate | Severity | critical | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0MP9 | Fixed in Version | 3.0MP9 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | Google Chrome |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0019984: Values of string and textarea grid items are being truncated. |
| Description | When a field is focused in edit mode in the grid, if the length of the string if longer than the displayedlength property of its field, the string will be truncated.
This is caused because the fix in issue 19805 (https://issues.openbravo.com/view.php?id=19805 [^]) changed the grid length property of strings. It used to be assigned the column length property of the field, and after that fix it uses the displaylength property. |
| Steps To Reproduce | - Open Windows, Tabs and Fields.
- Select Windows, Tabs and Fields in the header tab.
- Select Tab in the tab tab.
- Select Name in the field tab.
- Click Edit in grid button, and click on the Help/Comment column.
The value is shown truncated. |
| Proposed Solution | Never truncate string and textarea items. |
| Additional Information | |
| Tags | Regression QA |
| Relationships | | related to | defect | 0019805 | | closed | AugustoMauch | Inconsistent column-width in grid comparing chromium to FF10 | | related to | defect | 0020018 | 3.0MP9 | closed | AugustoMauch | Error in the initialization of the foreign key selectors when creating a new row in grid view |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-03-08 14:12 | AugustoMauch | New Issue | |
| 2012-03-08 14:12 | AugustoMauch | Assigned To | => AugustoMauch |
| 2012-03-08 14:12 | AugustoMauch | Web browser | => Google Chrome |
| 2012-03-08 14:12 | AugustoMauch | Modules | => Core |
| 2012-03-08 16:18 | shuehner | Issue Monitored: shuehner | |
| 2012-03-08 16:44 | AugustoMauch | Tag Attached: Regression | |
| 2012-03-08 16:44 | AugustoMauch | Tag Detached: Regression | |
| 2012-03-08 16:44 | AugustoMauch | Tag Attached: Regression QA | |
| 2012-03-08 16:46 | AugustoMauch | Relationship added | related to 0016665 |
| 2012-03-08 16:46 | AugustoMauch | Relationship deleted | related to 0016665 |
| 2012-03-08 16:46 | AugustoMauch | Relationship added | related to 0019805 |
| 2012-03-13 12:53 | hgbot | Checkin | |
| 2012-03-13 12:53 | hgbot | Note Added: 0046326 | |
| 2012-03-13 12:53 | hgbot | Status | new => resolved |
| 2012-03-13 12:53 | hgbot | Resolution | open => fixed |
| 2012-03-13 12:53 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/b36fb3fb4b6d4c0a2dcf5008f3abadd54621dcff [^] |
| 2012-03-13 12:58 | AugustoMauch | Note Added: 0046328 | |
| 2012-03-13 14:50 | hgbot | Checkin | |
| 2012-03-13 14:50 | hgbot | Note Added: 0046341 | |
| 2012-03-13 15:31 | dbaz | Note Added: 0046347 | |
| 2012-03-13 15:31 | dbaz | Status | resolved => closed |
| 2012-03-13 15:31 | dbaz | Fixed in Version | => 3.0MP9 |
| 2012-03-13 23:43 | hgbot | Checkin | |
| 2012-03-13 23:43 | hgbot | Note Added: 0046373 | |
| 2012-03-14 11:16 | AugustoMauch | Relationship added | related to 0020018 |
| 2012-04-01 20:32 | hgbot | Checkin | |
| 2012-04-01 20:32 | hgbot | Note Added: 0047003 | |
| 2012-04-01 20:32 | hgbot | Status | closed => resolved |
| 2012-04-01 20:32 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/b36fb3fb4b6d4c0a2dcf5008f3abadd54621dcff [^] => http://code.openbravo.com/erp/devel/pi/rev/e68ba1be9eade4440fd86201750099fa038dc1a8 [^] |
| 2012-04-01 20:32 | hgbot | Checkin | |
| 2012-04-01 20:32 | hgbot | Note Added: 0047004 | |
| 2012-04-01 20:33 | hgbot | Checkin | |
| 2012-04-01 20:33 | hgbot | Note Added: 0047007 | |
| 2012-04-02 06:09 | hudsonbot | Checkin | |
| 2012-04-02 06:09 | hudsonbot | Note Added: 0047115 | |
| 2012-04-02 06:09 | hudsonbot | Checkin | |
| 2012-04-02 06:09 | hudsonbot | Note Added: 0047118 | |
| 2012-04-02 06:10 | hudsonbot | Checkin | |
| 2012-04-02 06:10 | hudsonbot | Note Added: 0047126 | |
| 2012-04-02 10:24 | AugustoMauch | Status | resolved => closed |
|
Notes |
|
|
(0046326)
|
|
hgbot
|
|
2012-03-13 12:53
|
|
Repository: erp/devel/pi
Changeset: b36fb3fb4b6d4c0a2dcf5008f3abadd54621dcff
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 12:52:29 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b36fb3fb4b6d4c0a2dcf5008f3abadd54621dcff [^]
Fixes issue 19984: String and textarea items are no longer being truncated
The same field (grid.field) was being used for limiting the size of the input items and for calculating the width of the column. Now two different fields are defined in the UIDefinitions: 'length' to limit the size of the input items and 'displaylength' to set the length of the columns.
The code that was used to define the length of the columns is no longer using the 'length' property, now it uses the 'displaylength' property. It has been changed in two places:
- In the call of the getDefaultColumnWidth function
- In the sort function that is used to select the column to be autoexpanded
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/EnumUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/LinkUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/StringUIDefinition.java
---
|
|
|
|
|
Test plan:
- Check that the example described in steps to reproduce is no longer reproducible (the text area shows the full string, it is not being truncated).
- Check that the width of the columns consistent
- Check that in order to limit the size of the string, the value being used is the length property of ad_column, not the displaylength column of ad_field (e.g. the db_prefix of the modules has an ad_column.length value of 7, and an ad_field.displaylength of 12. It should not be possible to enter more than 7 characters.) |
|
|
|
(0046341)
|
|
hgbot
|
|
2012-03-13 14:50
|
|
Repository: erp/devel/pi
Changeset: 65db26640ba617779ebda1ec58eb4bb2f965e165
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 14:48:33 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/65db26640ba617779ebda1ec58eb4bb2f965e165 [^]
Related to issue 19984: Refactored for clarity.
The initialization of fld.gridProps.width in the prepareGridFields of ob-standard-view.js has been refactored. It was being done in two places of the code depending on whether fld.gridProps.displaylength was defined. Now both initializations are done in the same if statement.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
(0046347)
|
|
dbaz
|
|
2012-03-13 15:31
|
|
|
Reviewed @ changeset 15787 - 65db26640ba6 |
|
|
|
(0046373)
|
|
hgbot
|
|
2012-03-13 23:43
|
|
Repository: erp/devel/pi
Changeset: 757c16d46fa08e9335db75a8cb3aa7f6bdabdc82
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 23:42:12 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/757c16d46fa08e9335db75a8cb3aa7f6bdabdc82 [^]
Related to issue 19984: ForeignKeyUIDefinition uses ad_field.displaylength for length
After the fix of issue 19984 (changeset 15784), all the UIDefinition classes that defined the grid length property, took that value from ad_column.length. It works on most cases, but it does not in the ForeignKeyUIDefinition class. If it is used in the ForeignKeyUIDefinition class, when a new row is entered in the grid, the foreign key fields are not initialized properly.
Now the ForeignKeyUIDefinition class initializes the length grid field with the value of ad_field.displaylength. Changing this does not have any repercusion on determining the maximum number of characters allowed for the field. This class represents foreign keys, so its value can not be entered manually.
---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
---
|
|
|
|
(0047003)
|
|
hgbot
|
|
2012-04-01 20:32
|
|
Repository: erp/devel/pi
Changeset: e68ba1be9eade4440fd86201750099fa038dc1a8
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 12:52:29 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e68ba1be9eade4440fd86201750099fa038dc1a8 [^]
Fixes issue 19984: String and textarea items are no longer being truncated
The same field (grid.field) was being used for limiting the size of the input items and for calculating the width of the column. Now two different fields are defined in the UIDefinitions: 'length' to limit the size of the input items and 'displaylength' to set the length of the columns.
The code that was used to define the length of the columns is no longer using the 'length' property, now it uses the 'displaylength' property. It has been changed in two places:
- In the call of the getDefaultColumnWidth function
- In the sort function that is used to select the column to be autoexpanded
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/EnumUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/LinkUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/StringUIDefinition.java
---
|
|
|
|
(0047004)
|
|
hgbot
|
|
2012-04-01 20:32
|
|
Repository: erp/devel/pi
Changeset: e056a4471deebead46ffa1263d1c786b4a1964f1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 14:48:33 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e056a4471deebead46ffa1263d1c786b4a1964f1 [^]
Related to issue 19984: Refactored for clarity.
The initialization of fld.gridProps.width in the prepareGridFields of ob-standard-view.js has been refactored. It was being done in two places of the code depending on whether fld.gridProps.displaylength was defined. Now both initializations are done in the same if statement.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
(0047007)
|
|
hgbot
|
|
2012-04-01 20:33
|
|
Repository: erp/devel/pi
Changeset: f1b399ebb99e05b6384cd180c2fe4e32a9d3a68f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 23:42:12 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f1b399ebb99e05b6384cd180c2fe4e32a9d3a68f [^]
Related to issue 19984: ForeignKeyUIDefinition uses ad_field.displaylength for length
After the fix of issue 19984 (changeset 15784), all the UIDefinition classes that defined the grid length property, took that value from ad_column.length. It works on most cases, but it does not in the ForeignKeyUIDefinition class. If it is used in the ForeignKeyUIDefinition class, when a new row is entered in the grid, the foreign key fields are not initialized properly.
Now the ForeignKeyUIDefinition class initializes the length grid field with the value of ad_field.displaylength. Changing this does not have any repercusion on determining the maximum number of characters allowed for the field. This class represents foreign keys, so its value can not be entered manually.
---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|