Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017395Openbravo ERPA. Platformpublic2011-05-27 10:302012-02-02 15:20
Reportermbernal 
Assigned Tojecharri 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version3.0RC7 
Target VersionFixed in Version3.0MP8 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017395: Read Only Logic for columns is applied incorrectly
DescriptionCurrently, there are several ways to make some tabs/fields read only:
- A role may have access but not write permission to a window.
- A window can be of type "query"
- A tab can have a UI Pattern of Read Only
- A single field within a Tab can be Read Only
- A column can be non updatable (meaning that it can only be edited when creating a record)
- A column can have a Read Only Logic that will make the field read only dynamically, similar to Display Logics, but at a column level.


Read Only Logic should only be validated / applied if the previous conditions are not met, e.g. the column should be already editable.

Currently, Read Only Logic can make editable some fields which are not designed to be.
Steps To Reproduce1. Give an editable column a read only logic of 'false'. This means it should always be editable.
2. Make read only a field for this column
3. The field is editable even if it has been set to read only in this tab, since it is following the Read Only Logic rule instead of its field AD information.
Proposed SolutionRevise the whole read only functionality
Additional Information
TagsNo tags attached.
Relationships
related to defect 00194633.0MP8 closed jecharri Read Only Logic for columns is applied incorrectly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-05-27 10:30mbernalNew Issue
2011-05-27 10:30mbernalAssigned To => alostale
2011-05-27 10:30mbernalModules => Core
2011-06-22 18:37roklenardicIssue Monitored: roklenardic
2011-06-22 18:39roklenardicNote Added: 0038495
2011-06-22 18:43roklenardicNote Deleted: 0038495
2011-07-22 08:18alostaleStatusnew => scheduled
2011-07-22 08:18alostalefix_in_branch => pi
2011-07-28 17:39alostaleAssigned Toalostale => jecharri
2011-08-11 10:56jecharriNote Added: 0040109
2011-08-11 10:56jecharriStatusscheduled => feedback
2011-08-16 14:05roklenardicNote Added: 0040230
2011-10-07 11:00dmitry_mezentsevNote Added: 0041543
2011-11-24 11:22jvazquezNote Added: 0043145
2011-11-28 18:34RafaelCruzIssue Monitored: RafaelCruz
2011-12-19 09:49roklenardicNote Added: 0043929
2012-01-11 15:49maria_perezIssue Monitored: maria_perez
2012-01-11 16:22jecharriIssue cloned0019463
2012-01-11 16:22jecharriRelationship addedrelated to 0019463
2012-01-16 13:20hgbotCheckin
2012-01-16 13:20hgbotNote Added: 0044396
2012-01-16 13:20hgbotStatusfeedback => resolved
2012-01-16 13:20hgbotResolutionopen => fixed
2012-01-16 13:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1c7cc06530d5faf57bf0aaafa43332d6c8293063 [^]
2012-01-18 14:22hudsonbotCheckin
2012-01-18 14:22hudsonbotNote Added: 0044431
2012-01-30 18:14hgbotCheckin
2012-01-30 18:14hgbotNote Added: 0044715
2012-02-01 08:58hudsonbotCheckin
2012-02-01 08:58hudsonbotNote Added: 0044751
2012-02-02 15:20jecharriNote Added: 0044815
2012-02-02 15:20jecharriStatusresolved => closed
2012-02-02 15:20jecharriFixed in Version => 3.0MP8

Notes
(0040109)
jecharri   
2011-08-11 10:56   
In the first step:
1. Give an editable column a read only logic of 'false'. This means it should always be editable.

In the texfield, you have put only 'false' or anything different, because I have tested, writing "1=2" (always is false) in read only logic and I put the same field like a readonly and the second rule is always more restrictive that the read only logic.
So it is working like we want, if I understand the problem.
(0040230)
roklenardic   
2011-08-16 14:05   
One should not mix the Read Only Logic field and the Read Only checkbox.

Maybe, try to enter a read only logic that depends on the value of another field in that tab...
(0041543)
dmitry_mezentsev   
2011-10-07 11:00   
Hello All,

This issue is in a feedback status for quite a while.
Please confirm if it exists and if not - close it.

Thanks.
(0043145)
jvazquez   
2011-11-24 11:22   
Hello,
while doing the Basic Technical Training, Chapter 7, section Finetuning, I couldn't make the B. Partner field read-only. The application allowed me to mark it as read-only, but the field was still showing as read/write.
After asking some of the colleagues at Openbravo we have discovered that deleting the Read Only Logic value @Processed@='Y' at column level allows to correctly make the field as read-only.
To sum up, the Read Only logic at column level has higher priority than the Read Only checkbox at field level.
Cheers.
(0043929)
roklenardic   
2011-12-19 09:49   
This bug persists in MP5.1. Seems read-only logic has precedence over Read Only flag which is not the correct expected behaviour and could lead into data security violation.
(0044396)
hgbot   
2012-01-16 13:20   
Repository: erp/devel/pi
Changeset: 1c7cc06530d5faf57bf0aaafa43332d6c8293063
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 16 13:10:38 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1c7cc06530d5faf57bf0aaafa43332d6c8293063 [^]

Fixes issue 17395, Fixes issue 19463: Read Only Logic for columns is applied incorrectly.
Now the readonlylogic expression is not going to be applied until the application check if the field is defined as read only

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0044431)
hudsonbot   
2012-01-18 14:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0035a0985219 [^]

Maturity status: Test
(0044715)
hgbot   
2012-01-30 18:14   
Repository: erp/devel/pi
Changeset: a052b9bb86e5a76902755ba6c08da5fc02550923
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 30 18:13:28 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a052b9bb86e5a76902755ba6c08da5fc02550923 [^]

issue 17395, issue 19463: Read Only Logic for columns is applied incorrectly.
Now the read only logic is applied correctly for fields without column related (OBClientClassField)

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0044751)
hudsonbot   
2012-02-01 08:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/933a9b7b9d89 [^]

Maturity status: Test
(0044815)
jecharri   
2012-02-02 15:20   
This bug is a clone of https://issues.openbravo.com/view.php?id=19463 [^] and it is closed and working correctly