Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010979Openbravo ERPA. Platformpublic2009-10-15 11:562012-10-10 16:35
Reportervmromanos 
Assigned Toshankarb 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Versionpi 
Target VersionFixed in Version3.0MP16 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010979: Import translation should show a red message when a trl file is not well formed
DescriptionDue to the bug 0009781, I have changed some Spanish translations into the AD_ELEMENT_TRL_es_ES.xml file (see rev. 340 at https://dev.openbravo.com/websvn/localization/translations/es_ES/trunk/ [^]). Then I have tried to import the new XML file using the Import/Export language window and also through the creation of a new version of the translation module, but with the same result: The modifications are not imported into the database.

The cause is the AD_ELEMENT_TRL_es_ES.xml file is not a well formed XML file, so the import process cannot import this file. In this case, a red error message should appear informing the user about the error while importing the file.
Steps To Reproduce1- Download the rev.340 of the Spanish translation module through the SVN repository https://dev.openbravo.com/websvn/localization/translations/es_ES/trunk/ [^]
2- Import the Spanish language following the normal procedure. Reading the log you will discover the import process has failed, but no message has been shown in the application
Proposed Solution1. Display a red error message if a file has not been imported
2. Be careful because this process is also used when importing a translation module
Additional Information
TagsOB3-Reviewed
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-15 11:56vmromanosNew Issue
2009-10-15 11:56vmromanosAssigned To => rafaroda
2009-10-15 11:57vmromanosRelationship addedblocks 0009781
2009-10-15 15:04shuehnerNote Added: 0021060
2009-10-15 15:07hgbotCheckin
2009-10-15 15:07hgbotNote Added: 0021061
2009-10-15 15:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1b63de618c4b127c472d74dd9a7d269fda043845 [^]
2009-10-15 15:09vmromanosSeveritymajor => minor
2009-10-15 15:09vmromanosFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1b63de618c4b127c472d74dd9a7d269fda043845 [^] =>
2009-10-15 15:09vmromanosSummaryImport AD_ELEMENT_TRL does not work properly => Import translation should show a red message when a trl file is not well formed
2009-10-15 15:09vmromanosDescription Updated
2009-10-15 15:09vmromanosProposed Solution updated
2009-10-15 15:09vmromanosSteps to Reproduce Updated
2009-10-15 15:09vmromanosRelationship deletedblocks 0009781
2009-10-16 13:52psarobePrioritynormal => urgent
2009-10-16 13:52psarobeStatusnew => scheduled
2009-10-16 13:52psarobeTarget Version => 2.50MP9
2010-02-11 18:26rafarodaAssigned Torafaroda => alostale
2010-02-15 15:13alostaleAssigned Toalostale => shuehner
2011-11-22 18:32shuehnerTag Attached: OB3-Reviewed
2012-02-20 11:09shuehnerAssigned Toshuehner => alostale
2012-02-20 13:04alostaleTarget Version2.50MP9 =>
2012-09-26 12:39AugustoMauchAssigned Toalostale => shankarb
2012-09-26 16:55shankarbNote Added: 0052640
2012-09-28 10:24hgbotCheckin
2012-09-28 10:24hgbotNote Added: 0052853
2012-09-28 10:24hgbotStatusscheduled => resolved
2012-09-28 10:24hgbotResolutionopen => fixed
2012-09-28 10:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/35d251a9e6597da463e0665003fc2e2f43f2d4fe [^]
2012-09-28 10:53hgbotCheckin
2012-09-28 10:53hgbotNote Added: 0052855
2012-09-28 10:53AugustoMauchNote Added: 0052856
2012-09-28 10:53AugustoMauchStatusresolved => new
2012-09-28 10:53AugustoMauchResolutionfixed => open
2012-09-28 15:11hgbotCheckin
2012-09-28 15:11hgbotNote Added: 0052927
2012-09-28 15:11hgbotStatusnew => resolved
2012-09-28 15:11hgbotResolutionopen => fixed
2012-09-28 15:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/35d251a9e6597da463e0665003fc2e2f43f2d4fe [^] => http://code.openbravo.com/erp/devel/pi/rev/0bdd29a50fccec52e35b64fb484b080a104ca40e [^]
2012-09-28 15:13AugustoMauchClosed by => AugustoMauch
2012-09-28 15:13AugustoMauchNote Added: 0052928
2012-09-28 15:13AugustoMauchStatusresolved => closed
2012-09-28 15:13AugustoMauchFixed in Version => 3.0MP16
2012-10-04 18:18hudsonbotCheckin
2012-10-04 18:18hudsonbotNote Added: 0053035
2012-10-04 18:18hudsonbotCheckin
2012-10-04 18:18hudsonbotNote Added: 0053037
2012-10-04 18:18hudsonbotCheckin
2012-10-04 18:18hudsonbotNote Added: 0053045
2012-10-10 16:35hudsonbotCheckin
2012-10-10 16:35hudsonbotNote Added: 0053208
2012-10-10 16:35hudsonbotCheckin
2012-10-10 16:35hudsonbotNote Added: 0053210
2012-10-10 16:35hudsonbotCheckin
2012-10-10 16:35hudsonbotNote Added: 0053218

Notes
(0021060)
shuehner   
2009-10-15 15:04   
Note the import failed as one xml file which was to be imported was brkoen (not valid xml). This was shown in the error log but not shown to the user.

Two open issues:
- Improve logging of the exception to mention the file being imported when it happened
- Show error to the user in the UI (but be careful to not break installation of translation pack via an obx file)
(0021061)
hgbot   
2009-10-15 15:07   
Repository: erp/devel/pi
Changeset: 1b63de618c4b127c472d74dd9a7d269fda043845
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Oct 15 15:06:58 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1b63de618c4b127c472d74dd9a7d269fda043845 [^]

Issue 10979: Improve exception logging when importing a translation
Mention filename in the error when an exception happens on parsing an xml file

---
M src/org/openbravo/erpCommon/ad_forms/Translation.java
---
(0052640)
shankarb   
2012-09-26 16:55   
Test plan:
1. In the Import/Export Translation, export a language. eg., Spanish
2. Go the attachments folder where the exported translation xml files are saved.
3. Edit and Save a xml file with some added text in header.
4. In the Import/Export Translation, try to import the same language that you exported.
5. An error appears with the file name.
6. Notice that other proper files have been imported.
(0052853)
hgbot   
2012-09-28 10:24   
Repository: erp/devel/pi
Changeset: 35d251a9e6597da463e0665003fc2e2f43f2d4fe
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Sep 27 17:13:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/35d251a9e6597da463e0665003fc2e2f43f2d4fe [^]

Fixes Issue 0010979 : Display Error for unparsed XML Files.

In Import translation process, added an error message with the files that has not been parsed.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
---
(0052855)
hgbot   
2012-09-28 10:53   
Repository: erp/devel/pi
Changeset: fe3bcfb01f4859fb6a7e035e5d9d62f054764ce5
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 28 10:52:06 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fe3bcfb01f4859fb6a7e035e5d9d62f054764ce5 [^]

Related to issue 10979: Backs out changes until final fix is ready

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
---
(0052856)
AugustoMauch   
2012-09-28 10:53   
Reopened because the changeset http://code.openbravo.com/erp/devel/pi/rev/35d251a9e6597da463e0665003fc2e2f43f2d4fe [^] did not fix it.
(0052927)
hgbot   
2012-09-28 15:11   
Repository: erp/devel/pi
Changeset: 0bdd29a50fccec52e35b64fb484b080a104ca40e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Fri Sep 28 12:59:32 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0bdd29a50fccec52e35b64fb484b080a104ca40e [^]

Fixes Issue 0010979 : Display Error for unparsed XML Files.

In Import translation process, throws an exception when there are unparsable files.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
---
(0052928)
AugustoMauch   
2012-09-28 15:13   
Code reviewed and verified in pi@0bdd29a50fcc
(0053035)
hudsonbot   
2012-10-04 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c067ea513614 [^]

Maturity status: Test
(0053037)
hudsonbot   
2012-10-04 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c067ea513614 [^]

Maturity status: Test
(0053045)
hudsonbot   
2012-10-04 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c067ea513614 [^]

Maturity status: Test
(0053208)
hudsonbot   
2012-10-10 16:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b088fe9dfe19 [^]

Maturity status: Test
(0053210)
hudsonbot   
2012-10-10 16:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b088fe9dfe19 [^]

Maturity status: Test
(0053218)
hudsonbot   
2012-10-10 16:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b088fe9dfe19 [^]

Maturity status: Test